[UIA] Raise ExpandCollapseState for expand-collapse button state changes [chromium/src : main]

0 views
Skip to first unread message

Benjamin Beaudry (Gerrit)

unread,
Jul 7, 2026, 11:15:24 PM (2 days ago) Jul 7
to Jacques Newman, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Jacques Newman

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Jacques Newman
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I21bf60f2f7b8fd4ea743bd5e4ebacba477409bd4
Gerrit-Change-Number: 8029226
Gerrit-PatchSet: 5
Gerrit-Owner: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 03:15:07 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Jacques Newman (Gerrit)

unread,
Jul 8, 2026, 1:17:37 PM (yesterday) Jul 8
to Benjamin Beaudry, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
Attention needed from Benjamin Beaudry

Jacques Newman voted and added 1 comment

Votes added by Jacques Newman

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Jacques Newman . resolved

nit: It might be good to have some event dump tests covering this, but not a blocker IMO.

lgtm!

Open in Gerrit

Related details

Attention is currently required from:
  • Benjamin Beaudry
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I21bf60f2f7b8fd4ea743bd5e4ebacba477409bd4
    Gerrit-Change-Number: 8029226
    Gerrit-PatchSet: 5
    Gerrit-Owner: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
    Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
    Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
    Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
    Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
    Gerrit-Comment-Date: Wed, 08 Jul 2026 17:17:24 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Elly (Gerrit)

    unread,
    Jul 8, 2026, 7:23:57 PM (18 hours ago) Jul 8
    to Benjamin Beaudry, Elly, Jacques Newman, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
    Attention needed from Benjamin Beaudry and Jacques Newman

    Elly voted and added 1 comment

    Votes added by Elly

    Code-Review+1

    1 comment

    Patchset-level comments
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Benjamin Beaudry
    • Jacques Newman
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I21bf60f2f7b8fd4ea743bd5e4ebacba477409bd4
      Gerrit-Change-Number: 8029226
      Gerrit-PatchSet: 6
      Gerrit-Owner: Benjamin Beaudry <benjamin...@microsoft.com>
      Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
      Gerrit-Reviewer: Elly <elly...@chromium.org>
      Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
      Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
      Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
      Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
      Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
      Gerrit-Attention: Jacques Newman <jane...@microsoft.com>
      Gerrit-Comment-Date: Wed, 08 Jul 2026 23:23:43 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Jacques Newman (Gerrit)

      unread,
      Jul 8, 2026, 7:26:01 PM (18 hours ago) Jul 8
      to Benjamin Beaudry, Elly, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
      Attention needed from Benjamin Beaudry

      Jacques Newman voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Benjamin Beaudry
      Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I21bf60f2f7b8fd4ea743bd5e4ebacba477409bd4
        Gerrit-Change-Number: 8029226
        Gerrit-PatchSet: 6
        Gerrit-Owner: Benjamin Beaudry <benjamin...@microsoft.com>
        Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
        Gerrit-Reviewer: Elly <elly...@chromium.org>
        Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-Attention: Benjamin Beaudry <benjamin...@microsoft.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 23:25:48 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Benjamin Beaudry (Gerrit)

        unread,
        Jul 8, 2026, 7:34:56 PM (18 hours ago) Jul 8
        to Jacques Newman, Elly, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

        Benjamin Beaudry voted Commit-Queue+2

        Commit-Queue+2
        Open in Gerrit

        Related details

        Attention set is empty
        Submit Requirements:
        • requirement satisfiedCode-Coverage
        • requirement satisfiedCode-Owners
        • requirement satisfiedCode-Review
        • requirement satisfiedReview-Enforcement
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: comment
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I21bf60f2f7b8fd4ea743bd5e4ebacba477409bd4
        Gerrit-Change-Number: 8029226
        Gerrit-PatchSet: 6
        Gerrit-Owner: Benjamin Beaudry <benjamin...@microsoft.com>
        Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
        Gerrit-Reviewer: Elly <elly...@chromium.org>
        Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>
        Gerrit-Comment-Date: Wed, 08 Jul 2026 23:34:42 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Benjamin Beaudry (Gerrit)

        unread,
        12:07 PM (1 hour ago) 12:07 PM
        to Jacques Newman, Elly, Chromium LUCI CQ, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org
        Gerrit-Comment-Date: Thu, 09 Jul 2026 16:07:22 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: Yes
        satisfied_requirement
        open
        diffy

        Chromium LUCI CQ (Gerrit)

        unread,
        12:12 PM (1 hour ago) 12:12 PM
        to Benjamin Beaudry, Jacques Newman, Elly, Akihiro Ota, chromium...@chromium.org, (Julie)Jeongeun Kim, Kevin Babbitt, abigailbk...@google.com, dtseng...@chromium.org, francisjp...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lucasrada...@google.com, nektar...@chromium.org, yuzo+...@chromium.org

        Chromium LUCI CQ submitted the change

        Change information

        Commit message:
        [UIA] Raise ExpandCollapseState for expand-collapse button state changes

        While working on ViewsAX, we discovered a bug that affects menu buttons
        on web content (and with ViewsAX enabled). This CL fixes it.

        To understand the bug, we must first understand that, in UIA, we differentiate toggled buttons based on whether they are a genuine toggle or whether they have an associated menus. A generic toggle button, like a checkbox, should support the ToggleState pattern, and a toggle button associated with a menu (referenced to as a menu button) should instead support the ExpandCollapseState pattern. Those patterns should be mutually exclusive (see [1]).

        The pattern was already properly exposed from a previous CL I did a long time ago. However, what was uncovered here is that, for menu button, while we expose the right pattern, we still fire the wrong event: we raise ToggleState changed event. This was incorrect.

        To fix this, we introduce a new helper AXPlatformNodeWin::IsExpandCollapseButton to avoid repeating logic, and reuse it for both the state exposed and the event fired.

        [1]: https://source.chromium.org/chromium/chromium/src/+/main:ui/accessibility/platform/ax_platform_node_win.cc;l=9165?q=IsToggleSupported&ss=chromium
        Bug: 40672441
        Change-Id: I21bf60f2f7b8fd4ea743bd5e4ebacba477409bd4
        Commit-Queue: Benjamin Beaudry <benjamin...@microsoft.com>
        Reviewed-by: Jacques Newman <jane...@microsoft.com>
        Reviewed-by: Elly <elly...@chromium.org>
        Cr-Commit-Position: refs/heads/main@{#1659607}
        Files:
        • A chrome/browser/ui/views/toolbar/browser_app_menu_button_dump_accessibility_events_browsertest.cc
        • M chrome/test/BUILD.gn
        • A chrome/test/data/accessibility/events/browser-app-menu-button-expand-collapse-expected-uia-win.txt
        • M content/browser/accessibility/dump_accessibility_events_browsertest.cc
        • M content/test/content_test_bundle_data.filelist
        • A content/test/data/accessibility/event/button-haspopup-checked-state-changed-expected-uia-win.txt
        • A content/test/data/accessibility/event/button-haspopup-checked-state-changed.html
        • M ui/accessibility/platform/ax_platform_node_win.cc
        • M ui/accessibility/platform/ax_platform_node_win.h
        • M ui/accessibility/platform/browser_accessibility_manager_win.cc
        • M ui/accessibility/platform/browser_accessibility_manager_win.h
        • M ui/accessibility/platform/browser_accessibility_manager_win_unittest.cc
        Change size: M
        Delta: 12 files changed, 227 insertions(+), 2 deletions(-)
        Branch: refs/heads/main
        Submit Requirements:
        • requirement satisfiedCode-Review: +1 by Jacques Newman, +1 by Elly
        Open in Gerrit
        Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
        Gerrit-MessageType: merged
        Gerrit-Project: chromium/src
        Gerrit-Branch: main
        Gerrit-Change-Id: I21bf60f2f7b8fd4ea743bd5e4ebacba477409bd4
        Gerrit-Change-Number: 8029226
        Gerrit-PatchSet: 7
        Gerrit-Owner: Benjamin Beaudry <benjamin...@microsoft.com>
        Gerrit-Reviewer: Benjamin Beaudry <benjamin...@microsoft.com>
        Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
        Gerrit-Reviewer: Elly <elly...@chromium.org>
        Gerrit-Reviewer: Jacques Newman <jane...@microsoft.com>
        Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
        Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
        open
        diffy
        satisfied_requirement
        Reply all
        Reply to author
        Forward
        0 new messages