[Contextual Tasks] Switch CHECK in GetOAuthConsumerForContextualTasks [chromium/src : main]

0 views
Skip to first unread message

Duncan Mercer (Gerrit)

unread,
Jul 17, 2026, 12:47:01 PM (4 days ago) Jul 17
to Chrome Signin Team, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Chrome Signin Team

Duncan Mercer voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Chrome Signin Team
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
Gerrit-Change-Number: 8119570
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Chrome Signin Team <chrome-sig...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-Attention: Chrome Signin Team <chrome-sig...@google.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 16:46:41 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Jul 17, 2026, 12:51:12 PM (4 days ago) Jul 17
to Duncan Mercer, Chrome Signin Team, Amelie Schneider, Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Alex Ilin and Amelie Schneider

Message from gwsq

Shadowed: ame...@google.com

Reviewer source(s):
alex...@chromium.org, ame...@google.com is from context(googleclient/chrome/chromium_gwsq/components/signin/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Ilin
  • Amelie Schneider
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
Gerrit-Change-Number: 8119570
Gerrit-PatchSet: 2
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Alex Ilin <alex...@chromium.org>
Gerrit-Attention: Amelie Schneider <ame...@google.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 16:50:35 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Duncan Mercer (Gerrit)

unread,
Jul 17, 2026, 4:35:35 PM (4 days ago) Jul 17
to Chrome Signin Team, Amelie Schneider, Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Alex Ilin and Amelie Schneider

Duncan Mercer voted

Auto-Submit+1
Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alex Ilin
  • Amelie Schneider
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
Gerrit-Change-Number: 8119570
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Alex Ilin <alex...@chromium.org>
Gerrit-Attention: Amelie Schneider <ame...@google.com>
Gerrit-Comment-Date: Fri, 17 Jul 2026 20:35:25 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Amelie Schneider (Gerrit)

unread,
Jul 20, 2026, 4:23:13 AM (yesterday) Jul 20
to Duncan Mercer, Chrome Signin Team, Alex Ilin, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Alex Ilin and Duncan Mercer

Amelie Schneider voted and added 3 comments

Votes added by Amelie Schneider

Code-Review+1

3 comments

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Amelie Schneider . resolved

Thanks!

File chrome/browser/signin/chrome_signin_client_unittest.cc
Line 141, Patchset 3 (Latest): // Scopes from chormium source
Amelie Schneider . unresolved

same here

Line 167, Patchset 3 (Latest): // Scopes from chormium source
Amelie Schneider . unresolved

nit: typo

Open in Gerrit

Related details

Attention is currently required from:
  • Alex Ilin
  • Duncan Mercer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
Gerrit-Change-Number: 8119570
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Alex Ilin <alex...@chromium.org>
Gerrit-Attention: Duncan Mercer <mer...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 08:22:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Alex Ilin (Gerrit)

unread,
Jul 20, 2026, 7:15:38 AM (yesterday) Jul 20
to Duncan Mercer, Alex Ilin, Amelie Schneider, Chrome Signin Team, Chromium LUCI CQ, chromium...@chromium.org
Attention needed from Duncan Mercer

Alex Ilin voted and added 1 comment

Votes added by Alex Ilin

Code-Review+1

1 comment

Patchset-level comments
Alex Ilin . resolved

LGTM % Amelie's comments

Open in Gerrit

Related details

Attention is currently required from:
  • Duncan Mercer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
Gerrit-Change-Number: 8119570
Gerrit-PatchSet: 3
Gerrit-Owner: Duncan Mercer <mer...@google.com>
Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Duncan Mercer <mer...@google.com>
Gerrit-Comment-Date: Mon, 20 Jul 2026 11:15:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Duncan Mercer (Gerrit)

unread,
Jul 20, 2026, 12:12:03 PM (yesterday) Jul 20
to Alex Ilin, Amelie Schneider, Chrome Signin Team, Chromium LUCI CQ, chromium...@chromium.org

Duncan Mercer voted and added 2 comments

Votes added by Duncan Mercer

Auto-Submit+1

2 comments

File chrome/browser/signin/chrome_signin_client_unittest.cc
Line 141, Patchset 3: // Scopes from chormium source
Amelie Schneider . resolved

same here

Duncan Mercer

Done

Line 167, Patchset 3: // Scopes from chormium source
Amelie Schneider . resolved

nit: typo

Duncan Mercer

Done

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
    Gerrit-Change-Number: 8119570
    Gerrit-PatchSet: 4
    Gerrit-Owner: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Mon, 20 Jul 2026 16:11:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Amelie Schneider <ame...@google.com>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jul 20, 2026, 1:12:44 PM (yesterday) Jul 20
    to Duncan Mercer, Alex Ilin, Amelie Schneider, Chrome Signin Team, chromium...@chromium.org

    Chromium LUCI CQ submitted the change with unreviewed changes

    Unreviewed changes

    3 is the latest approved patch-set.
    The change was submitted with unreviewed changes in the following files:

    ```
    The name of the file: chrome/browser/signin/chrome_signin_client_unittest.cc
    Insertions: 2, Deletions: 2.

    @@ -138,7 +138,7 @@
     
       signin::ScopeSet scopes = consumer.GetScopes();
     
    -  // Scopes from chormium source
    +  // Scopes from chromium source
       EXPECT_THAT(scopes, testing::Contains(GaiaConstants::kClearCutOAuth2Scope));
       EXPECT_THAT(scopes, testing::Contains(GaiaConstants::kLensOAuth2Scope));
     
    @@ -164,7 +164,7 @@
     
       signin::ScopeSet scopes = consumer.GetScopes();
     
    -  // Scopes from chormium source
    +  // Scopes from chromium source
       EXPECT_THAT(scopes, testing::Contains(GaiaConstants::kClearCutOAuth2Scope));
       EXPECT_THAT(scopes, testing::Contains(GaiaConstants::kLensOAuth2Scope));
     
    ```

    Change information

    Commit message:
    [Contextual Tasks] Switch CHECK in GetOAuthConsumerForContextualTasks

    Switch the CHECK in GetOAuthConsumerForContextualTasks to check
    IsContextualTasksUIEnabled() instead of kContextualTasks. A previous CL
    added a new flag to allow users to get to the Contextual Tasks side
    panel with the kContextualTasks flag, which causes this CHECK to fail.

    Context: crrev.com/c/8086133
    Bug: b:533533547
    Fixed: b:535862227
    Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
    Reviewed-by: Alex Ilin <alex...@chromium.org>
    Auto-Submit: Duncan Mercer <mer...@google.com>
    Commit-Queue: Duncan Mercer <mer...@google.com>
    Reviewed-by: Amelie Schneider <ame...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1664774}
    Files:
    • M chrome/browser/signin/chrome_signin_client.cc
    • M chrome/browser/signin/chrome_signin_client_unittest.cc
    Change size: S
    Delta: 2 files changed, 28 insertions(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Amelie Schneider, +1 by Alex Ilin
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ica5ecb0c002c3cb0873646a38d10c48bfe77e82c
    Gerrit-Change-Number: 8119570
    Gerrit-PatchSet: 5
    Gerrit-Owner: Duncan Mercer <mer...@google.com>
    Gerrit-Reviewer: Alex Ilin <alex...@chromium.org>
    Gerrit-Reviewer: Amelie Schneider <ame...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Duncan Mercer <mer...@google.com>
    Gerrit-CC: Chrome Signin Team <chrome-sig...@google.com>
    Gerrit-CC: gwsq
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages