[iOS] Announce required state for address fields in VoiceOver [chromium/src : main]

0 views
Skip to first unread message

Sourav Uttam Sinha (Gerrit)

unread,
1:46 PM (4 hours ago) 1:46 PM
to Tommy Martino, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino

Sourav Uttam Sinha added 1 comment

File ios/chrome/browser/autofill/ui_bundled/address_editor/autofill_profile_edit_mediator.mm
Line 349, Patchset 4 (Latest):- (BOOL)isFieldRequired:(NSString*)autofillFieldType {
Sourav Uttam Sinha . unresolved

Added a wrapper method since isAutofillFieldTypeRequiredField is a private method. Is this the correct approach? @tmar...@chromium.org

Open in Gerrit

Related details

Attention is currently required from:
  • Tommy Martino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4d9d7ca6794615a5f13132181ec9261aaf5adaa4
Gerrit-Change-Number: 8054110
Gerrit-PatchSet: 4
Gerrit-Owner: Sourav Uttam Sinha <sinha...@google.com>
Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 17:46:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Sourav Uttam Sinha (Gerrit)

unread,
1:51 PM (4 hours ago) 1:51 PM
to Tommy Martino, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino

Sourav Uttam Sinha added 1 comment

File ios/chrome/browser/autofill/ui_bundled/address_editor/autofill_profile_edit_mediator.mm
Line 349, Patchset 4 (Latest):- (BOOL)isFieldRequired:(NSString*)autofillFieldType {
Sourav Uttam Sinha . unresolved

Added a wrapper method since isAutofillFieldTypeRequiredField is a private method. Is this the correct approach? @tmar...@chromium.org

Sourav Uttam Sinha

Or I can make isAutofillFieldTypeRequiredField not private simply and delete the wrapper as well.

Open in Gerrit

Related details

Attention is currently required from:
  • Tommy Martino
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4d9d7ca6794615a5f13132181ec9261aaf5adaa4
Gerrit-Change-Number: 8054110
Gerrit-PatchSet: 4
Gerrit-Owner: Sourav Uttam Sinha <sinha...@google.com>
Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
Gerrit-Comment-Date: Thu, 09 Jul 2026 17:51:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sourav Uttam Sinha <sinha...@google.com>
satisfied_requirement
unsatisfied_requirement
open
diffy

Tommy Martino (Gerrit)

unread,
2:49 PM (3 hours ago) 2:49 PM
to Sourav Uttam Sinha, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Sourav Uttam Sinha

Tommy Martino added 1 comment

File ios/chrome/browser/autofill/ui_bundled/address_editor/autofill_profile_edit_mediator.mm
Line 349, Patchset 4 (Latest):- (BOOL)isFieldRequired:(NSString*)autofillFieldType {
Sourav Uttam Sinha . unresolved

Added a wrapper method since isAutofillFieldTypeRequiredField is a private method. Is this the correct approach? @tmar...@chromium.org

Sourav Uttam Sinha

Or I can make isAutofillFieldTypeRequiredField not private simply and delete the wrapper as well.

Tommy Martino

Or I can make isAutofillFieldTypeRequiredField not private simply and delete the wrapper as well.

I would do this one

Open in Gerrit

Related details

Attention is currently required from:
  • Sourav Uttam Sinha
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I4d9d7ca6794615a5f13132181ec9261aaf5adaa4
Gerrit-Change-Number: 8054110
Gerrit-PatchSet: 4
Gerrit-Owner: Sourav Uttam Sinha <sinha...@google.com>
Gerrit-Reviewer: Sourav Uttam Sinha <sinha...@google.com>
Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
Gerrit-Attention: Sourav Uttam Sinha <sinha...@google.com>
Gerrit-Comment-Date: Thu, 09 Jul 2026 18:48:54 +0000
satisfied_requirement
unsatisfied_requirement
open
diffy

Sourav Uttam Sinha (Gerrit)

unread,
3:21 PM (2 hours ago) 3:21 PM
to Chromium LUCI CQ, Tommy Martino, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org, tmartino+tran...@chromium.org
Attention needed from Tommy Martino

Sourav Uttam Sinha added 1 comment

File ios/chrome/browser/autofill/ui_bundled/address_editor/autofill_profile_edit_mediator.mm
Line 349, Patchset 4:- (BOOL)isFieldRequired:(NSString*)autofillFieldType {
Sourav Uttam Sinha . resolved

Added a wrapper method since isAutofillFieldTypeRequiredField is a private method. Is this the correct approach? @tmar...@chromium.org

Sourav Uttam Sinha

Or I can make isAutofillFieldTypeRequiredField not private simply and delete the wrapper as well.

Tommy Martino

Or I can make isAutofillFieldTypeRequiredField not private simply and delete the wrapper as well.

I would do this one

Sourav Uttam Sinha

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Tommy Martino
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4d9d7ca6794615a5f13132181ec9261aaf5adaa4
    Gerrit-Change-Number: 8054110
    Gerrit-PatchSet: 5
    Gerrit-Owner: Sourav Uttam Sinha <sinha...@google.com>
    Gerrit-Reviewer: Sourav Uttam Sinha <sinha...@google.com>
    Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
    Gerrit-Attention: Tommy Martino <tmar...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 19:21:26 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    Comment-In-Reply-To: Sourav Uttam Sinha <sinha...@google.com>
    Comment-In-Reply-To: Tommy Martino <tmar...@chromium.org>
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tommy Martino (Gerrit)

    unread,
    3:29 PM (2 hours ago) 3:29 PM
    to Sourav Uttam Sinha, Gauthier Ambard, Chromium LUCI CQ, chromium...@chromium.org, browser-comp...@chromium.org, feature-me...@chromium.org, ios-revie...@chromium.org, ios-r...@chromium.org, marq+...@chromium.org, srahim...@chromium.org, tmartino+tran...@chromium.org
    Attention needed from Gauthier Ambard and Sourav Uttam Sinha

    Tommy Martino voted and added 1 comment

    Votes added by Tommy Martino

    Code-Review+1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 5 (Latest):
    Tommy Martino . resolved

    Overall lgtm, but I would like @gam...@chromium.org to sign off on the changes in `ios/chrome/browser/shared/ui/table_view/cells/table_view_text_edit_item.mm` before we land

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Gauthier Ambard
    • Sourav Uttam Sinha
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I4d9d7ca6794615a5f13132181ec9261aaf5adaa4
    Gerrit-Change-Number: 8054110
    Gerrit-PatchSet: 5
    Gerrit-Owner: Sourav Uttam Sinha <sinha...@google.com>
    Gerrit-Reviewer: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Reviewer: Sourav Uttam Sinha <sinha...@google.com>
    Gerrit-Reviewer: Tommy Martino <tmar...@chromium.org>
    Gerrit-Attention: Sourav Uttam Sinha <sinha...@google.com>
    Gerrit-Attention: Gauthier Ambard <gam...@chromium.org>
    Gerrit-Comment-Date: Thu, 09 Jul 2026 19:28:51 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages