[Security Settings] Implement HFM Balanced Mode row and other UI [chromium/src : main]
0 views
Skip to first unread message
Zack Han (Gerrit)
May 22, 2026, 2:40:02 PM (6 days ago) May 22
to Awad Osman, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Awad Osman
Zack Han voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Awad Osman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Awad Osman (Gerrit)
May 22, 2026, 5:17:56 PM (6 days ago) May 22
to Zack Han, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Zack Han
Awad Osman added 7 comments![]( "Open in Gerrit")
Commit Message
Line 27, Patchset 6 (Latest):
Awad Osman . unresolved
nit: screencast of general behavior would be nice since this CL makes substantial UI changes.
File chrome/browser/resources/settings/privacy_page/security/security_page_feature_row.html
Line 82, Patchset 6 (Latest):
<div style="display: flex; align-items: center; gap: 8px;">Awad Osman . unresolved
nit: instead of inlining the styles I think it'll be better to give the div an id selector and style the selector instead.
File chrome/browser/resources/settings/privacy_page/security/security_page_v2.html
Line 203, Patchset 6 (Latest):
animation: none !important;Awad Osman . unresolved
Is there a way to use these styles without `!important`?. Here and the one below as well.
File chrome/browser/resources/settings/privacy_page/security/security_page_v2.ts
Line 95, Patchset 6 (Latest):
set(path: string, value: unknown): void;Awad Osman . unresolved
Why is this needed?
Line 369, Patchset 6 (Latest):
this.set('showNewBadge_', isNew);Awad Osman . unresolved
nit: can't you just do `this.showNewBadge_ = isNew`?
File chrome/browser/safe_browsing/safe_browsing_service.cc
Line 217, Patchset 6 (Latest):
LOG(ERROR) << "BSS Migration Debug - profile is null!";Awad Osman . unresolved
Think you left the log statement here by accident.
Line 224, Patchset 6 (Latest):
LOG(ERROR) << "BSS Migration Debug - starting checks."Awad Osman . unresolved
Same as above^
Related details
Attention is currently required from:
- Zack Han
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zack Han (Gerrit)
May 27, 2026, 3:51:46 PM (yesterday) May 27
to Awad Osman, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Awad Osman
Zack Han added 8 comments![]( "Open in Gerrit")
Patchset-level comments
Commit Message
nit: screencast of general behavior would be nice since this CL makes substantial UI changes.
Zack Han
Done
File chrome/browser/resources/settings/privacy_page/security/security_page_feature_row.html
Line 82, Patchset 6:
<div style="display: flex; align-items: center; gap: 8px;">Awad Osman . resolved
nit: instead of inlining the styles I think it'll be better to give the div an id selector and style the selector instead.
Zack Han
Done
File chrome/browser/resources/settings/privacy_page/security/security_page_v2.html
Is there a way to use these styles without `!important`?. Here and the one below as well.
Zack Han
Done
File chrome/browser/resources/settings/privacy_page/security/security_page_v2.ts
Line 95, Patchset 6:
set(path: string, value: unknown): void;Awad Osman . resolved
Zack HanWhy is this needed?
Done
nit: can't you just do `this.showNewBadge_ = isNew`?
Zack Han
Done
File chrome/browser/safe_browsing/safe_browsing_service.cc
Think you left the log statement here by accident.
Zack Han
Done
Line 224, Patchset 6:
LOG(ERROR) << "BSS Migration Debug - starting checks."Awad Osman . resolved
Zack HanSame as above^
Done
Related details
Attention is currently required from:
- Awad Osman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Zack Han (Gerrit)
May 27, 2026, 3:52:37 PM (yesterday) May 27
to Chris Thompson, Awad Osman, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Awad Osman and Chris Thompson
Zack Han added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Zack Han . resolved
Hi Chris, can you take a look at the c/b/s/https_first_mode... related changes? Thanks!
Related details
Attention is currently required from:
- Awad Osman
- Chris Thompson
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Awad Osman (Gerrit)
2:34 PM (2 hours ago) 2:34 PM
to Zack Han, Chris Thompson, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Chris Thompson and Zack Han
Awad Osman voted and added 2 comments![]( "Open in Gerrit")
Votes added by Awad Osman
| Code-Review | +1 |
2 comments
Patchset-level comments
Awad Osman . resolved
LGTM % pending failing tests get resolved
File chrome/test/data/webui/settings/security/security_page_v2_test.ts
Line 60, Patchset 8 (Latest):
securityStandardBundleSafeBrowsingDefault: SafeBrowsingSetting.STANDARD,Awad Osman . unresolved
What are these variables used for? Here and in the HATS suite below.
Related details
Attention is currently required from:
- Chris Thompson
- Zack Han
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chris Thompson (Gerrit)
3:33 PM (1 hour ago) 3:33 PM
to Zack Han, Awad Osman, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, chromium-a...@chromium.org, extension...@chromium.org, nwoked...@chromium.org, vakh+safe_br...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Zack Han
Chris Thompson added 1 comment![]( "Open in Gerrit")
File chrome/browser/ssl/https_first_mode_settings_tracker.h
Line 71, Patchset 8 (Parent):
// Migrates existing Enhanced bundle users to Balanced HFM and schedules the
// upgrade Toast if they haven't manually customized HFM.
void MigrateEnhancedBundleUsersAndMaybeShowToast();Chris Thompson . unresolved
Unintended removal of the logic added in the parent CL?
Related details
Attention is currently required from:
- Zack Han
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages