Fix content_unittests with ReduceAcceptLanguageHTTP enabled. [chromium/src : main]

0 views
Skip to first unread message

Victor Tan (Gerrit)

unread,
11:49 AM (6 hours ago) 11:49 AM
to Arthur Sonzogni, chromium...@chromium.org
Attention needed from Arthur Sonzogni

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I76910a4af5ffe8e784be63e31551655dfb40dbd1
Gerrit-Change-Number: 6984425
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Tan <vict...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Thu, 25 Sep 2025 15:48:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
12:06 PM (6 hours ago) 12:06 PM
to Victor Tan, chromium...@chromium.org
Attention needed from Victor Tan

Arthur Sonzogni voted and added 1 comment

Votes added by Arthur Sonzogni

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Arthur Sonzogni . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Tan
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I76910a4af5ffe8e784be63e31551655dfb40dbd1
    Gerrit-Change-Number: 6984425
    Gerrit-PatchSet: 1
    Gerrit-Owner: Victor Tan <vict...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    Gerrit-Attention: Victor Tan <vict...@chromium.org>
    Gerrit-Comment-Date: Thu, 25 Sep 2025 16:06:32 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    12:32 PM (6 hours ago) 12:32 PM
    to Victor Tan, Arthur Sonzogni, chromium...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Fix content_unittests with ReduceAcceptLanguageHTTP enabled.

    This patch fixes the test:
    AcceptLanguageUtilsTests and CreateAcceptLanguageUtilsTest that
    fails when the field trial feature: ReduceAcceptLanguageHTTP is enabled.
    Change-Id: I76910a4af5ffe8e784be63e31551655dfb40dbd1
    Bug: 447306425
    Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
    Reviewed-by: Arthur Sonzogni <arthurs...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1520678}
    Files:
    • M content/browser/reduce_accept_language/reduce_accept_language_utils_unittest.cc
    Change size: XS
    Delta: 1 file changed, 5 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Arthur Sonzogni
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I76910a4af5ffe8e784be63e31551655dfb40dbd1
    Gerrit-Change-Number: 6984425
    Gerrit-PatchSet: 2
    Gerrit-Owner: Victor Tan <vict...@chromium.org>
    Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages