Mitsuru Oshima (Gerrit)

unread,

Feb 25, 2026, 12:33:40 AM (5 days ago) Feb 25

to Chromium LUCI CQ, Keren Zhu, Bryant Chandler, Eriko Kurimoto, Ian Wells, Dan Harrington, Rubber Stamper, AyeAye, chromium...@chromium.org, Tom Lukaszewicz

Mitsuru Oshima has uploaded the change for review

Mitsuru Oshima would like Chromium LUCI CQ, Keren Zhu, Bryant Chandler, Eriko Kurimoto, Ian Wells, Dan Harrington and Rubber Stamper to review this change.

Commit message

Reland "Reland "MockActivationController class to emulate widget activation in test.""

This reverts commit 3be941b09e163f3fac88b833bd5fb315de9101b3.

Reason for revert: TBD: CQ doesn't run mac browser_tests

Original change's description:
> Revert "Reland "MockActivationController class to emulate widget activation in test.""
>
> This reverts commit 8a2462b493e249480a772d9f897a9fdc72ecddce.
>
> Reason for revert: Culprit of GlicInstanceCoordinatorBrowserTest.TabContentsDaisyChaining failure
> First failure log:
> https://ci.chromium.org/ui/p/chromium/builders/ci/mac15-x64-rel-tests/14451/overview
>
> Original change's description:
> > Reland "MockActivationController class to emulate widget activation in test."
> >
> > This reverts commit ca260c6ee8ab166d99d9d20635914db15f490565.
> >
> > Reason for revert: The activation check is incorrect. The check should be done only when activation is requested.
> >
> > Original change's description:
> > > Revert "MockActivationController class to emulate widget activation in test."
> > >
> > > This reverts commit f92674cad33d0849217a25d5c27a2d8848f8d713.
> > >
> > > Reason for revert: Likely cause of numerous test failures around glic window activation, see crbug.com/487109869
> > >
> > > Original change's description:
> > > > MockActivationController class to emulate widget activation in test.
> > > >
> > > > And use this class in BrowserActivator for Win/Mac/Linux
> > > > This class is now deprecated and will be removed in a follow up CL.
> > > >
> > > > Note that this emulation is necessary for Win/Mac/Linux only and not
> > > > necessary on ChromeOS and Android, because on ChromeOS, each
> > > > test creates its own environment, and on Android, all tests run
> > > > in sequence.
> > > >
> > > > Please see the comment for MockActivationController class for the
> > > > detail.
> > > >
> > > > Include-Ci-Only-Tests: chromium.mac:mac15-x64-rel-tests|browser_tests
> > > > Bug: 485886095, 485887814
> > > > Test: covered by views_unittests and browser_tests.
> > > > Change-Id: I9e7e27a71ebcd72caea059b90c06fb2f58ac6174
> > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7586664
> > > > Reviewed-by: Keren Zhu <kere...@chromium.org>
> > > > Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
> > > > Cr-Commit-Position: refs/heads/main@{#1589062}
> > >
> > > Bug: 485886095, 485887814, 487109869
> > > No-Presubmit: true
> > > No-Tree-Checks: true
> > > No-Try: true
> > > Bug: 485886095, 485887814
> > > Change-Id: Icecee913406517dc970d33e917707cf0d4d1bf78
> > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7603216
> > > Commit-Queue: Ian Wells <iwe...@chromium.org>
> > > Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> > > Owners-Override: Ian Wells <iwe...@chromium.org>
> > > Cr-Commit-Position: refs/heads/main@{#1589616}
> >
> > Bug: 485886095, 485887814, 487109869
> > Bug: 485886095, 485887814
> > Change-Id: I0b867765f8cd4e7bc0a35574904762ee0bdb8ba7
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7604892
> > Reviewed-by: Ian Wells <iwe...@chromium.org>
> > Commit-Queue: Mitsuru Oshima <osh...@chromium.org>
> > Reviewed-by: Keren Zhu <kere...@chromium.org>
> > Cr-Commit-Position: refs/heads/main@{#1589850}
>
> Bug: 485886095, 485887814, 487109869
> Bug: 485886095, 485887814
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Change-Id: I9a0a6f6f3449d369183f7df2396755f212bd112b
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7605681
> Bot-Commit: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
> Commit-Queue: Eriko Kurimoto <elk...@chromium.org>
> Auto-Submit: Eriko Kurimoto <elk...@chromium.org>
> Owners-Override: Eriko Kurimoto <elk...@chromium.org>
> Cr-Commit-Position: refs/heads/main@{#1589903}

Bug: 485886095, 485887814, 487109869

Bug: 485886095, 485887814

Change-Id: I9137b63bec582b57ae9da5cccaef0d36194c0304

Change diff

Change information

Files:

M chrome/browser/glic/test_support/BUILD.gn
M chrome/browser/glic/test_support/glic_test_util.cc
M chrome/browser/glic/test_support/glic_test_util.h
M ui/views/BUILD.gn
M ui/views/cocoa/native_widget_mac_ns_window_host.h
M ui/views/cocoa/native_widget_mac_ns_window_host.mm
A ui/views/test/mock_activation_controller.cc
A ui/views/test/mock_activation_controller.h
M ui/views/widget/desktop_aura/desktop_window_tree_host_platform.cc
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
A ui/views/widget/widget_activation_delegate.cc
A ui/views/widget/widget_activation_delegate.h
A ui/views/widget/widget_activation_delegate_unittest.cc

Change size: L

Delta: 13 files changed, 696 insertions(+), 21 deletions(-)

Open in Gerrit

Related details

Attention set is empty

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Mitsuru Oshima (Gerrit)

unread,

12:02 AM (4 hours ago) 12:02 AM

to Chromium LUCI CQ, Keren Zhu, Bryant Chandler, Eriko Kurimoto, Ian Wells, Dan Harrington, Rubber Stamper, AyeAye, chromium...@chromium.org, Tom Lukaszewicz, dewitt...@chromium.org, sky+...@chromium.org, mac-r...@chromium.org, roblia...@chromium.org

Attention needed from Bryant Chandler, Dan Harrington, Eriko Kurimoto, Ian Wells and Keren Zhu

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

Commit-Queue

+1

1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Mitsuru Oshima . resolved

The flakiness has been addressed in crrev.com/c/7619449/7. This CL itself is same as original. PTAL

Open in Gerrit

Related details

Attention is currently required from:

Bryant Chandler
Dan Harrington
Eriko Kurimoto
Ian Wells
Keren Zhu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rubber Stamper (Gerrit)

unread,

12:03 AM (4 hours ago) 12:03 AM

to Mitsuru Oshima, Chromium LUCI CQ, Keren Zhu, Bryant Chandler, Dan Harrington, AyeAye, chromium...@chromium.org, Tom Lukaszewicz, dewitt...@chromium.org, sky+...@chromium.org, mac-r...@chromium.org, roblia...@chromium.org

Attention needed from Bryant Chandler, Dan Harrington and Keren Zhu

Message from Rubber Stamper

Gerrit GetPureRevert API does not mark this CL as a pure revert. Learn more: go/rubber-stamper-user-guide.

Open in Gerrit

Related details

Attention is currently required from:

Bryant Chandler
Dan Harrington
Keren Zhu

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Keren Zhu (Gerrit)

unread,

12:09 AM (4 hours ago) 12:09 AM

to Mitsuru Oshima, Chromium LUCI CQ, Bryant Chandler, Dan Harrington, AyeAye, chromium...@chromium.org, Tom Lukaszewicz, dewitt...@chromium.org, sky+...@chromium.org, mac-r...@chromium.org, roblia...@chromium.org

Attention needed from Bryant Chandler and Dan Harrington

Keren Zhu voted and added 1 comment

Votes added by Keren Zhu

Code-Review

+1

1 comment

Patchset-level comments

File-level comment, Patchset 11 (Latest):

Keren Zhu . resolved

ui/views lgtm

Open in Gerrit

Related details

Attention is currently required from:

Bryant Chandler
Dan Harrington

Submit Requirements:

Code-Coverage
Code-Owners

Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

Reland "Reland "MockActivationController class to emulate widget activation in test."" [chromium/src : main]

Mitsuru Oshima (Gerrit)

Mitsuru Oshima has uploaded the change for review

Commit message

Change diff

Change information

Related details

Mitsuru Oshima (Gerrit)

Mitsuru Oshima voted and added 1 comment

Votes added by Mitsuru Oshima

1 comment

Related details

Rubber Stamper (Gerrit)

Message from Rubber Stamper

Related details

Keren Zhu (Gerrit)

Keren Zhu voted and added 1 comment

Votes added by Keren Zhu

1 comment

Related details