Rob Pitkin (Gerrit)

unread,

Jan 14, 2026, 1:54:27 PM (yesterday) Jan 14

to Matt Reynolds, Alvin Ji, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org

Attention needed from Alvin Ji and Matt Reynolds

Rob Pitkin added 1 comment

Patchset-level comments

File-level comment, Patchset 1 (Latest):

Rob Pitkin . resolved

Matt and I discussed removing this DCHECK_EQ and replacing it with a log in our 1:1 yesterday. PTAL, thanks!

Open in Gerrit

Related details

Attention is currently required from:

Alvin Ji
Matt Reynolds

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matt Reynolds (Gerrit)

unread,

Jan 14, 2026, 4:21:08 PM (yesterday) Jan 14

to Rob Pitkin, Alvin Ji, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org

Attention needed from Alvin Ji and Rob Pitkin

Matt Reynolds added 1 comment

File device/gamepad/gamepad_platform_data_fetcher_mac.mm

Line 174, Patchset 1 (Latest): DVLOG(1) << "XInput gamepad claimed by GamepadPlatformDataFetcherMac";

Matt Reynolds . unresolved

nit: Make this VLOG so we can enable the log message in release builds

Open in Gerrit

Related details

Attention is currently required from:

Alvin Ji
Rob Pitkin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Rob Pitkin (Gerrit)

unread,

Jan 14, 2026, 4:29:35 PM (yesterday) Jan 14

to Matt Reynolds, Alvin Ji, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org

Attention needed from Alvin Ji and Matt Reynolds

Rob Pitkin added 2 comments

Patchset-level comments

File-level comment, Patchset 2 (Latest):

Rob Pitkin . resolved

Thanks for the review! PTAL

File device/gamepad/gamepad_platform_data_fetcher_mac.mm

Line 174, Patchset 1: DVLOG(1) << "XInput gamepad claimed by GamepadPlatformDataFetcherMac";

Matt Reynolds . resolved

nit: Make this VLOG so we can enable the log message in release builds

Rob Pitkin

Done

Open in Gerrit

Related details

Attention is currently required from:

Alvin Ji
Matt Reynolds

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alvin Ji (Gerrit)

unread,

Jan 14, 2026, 5:58:22 PM (yesterday) Jan 14

to Rob Pitkin, Matt Reynolds, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org

Attention needed from Matt Reynolds and Rob Pitkin

Alvin Ji added 1 comment

Commit Message

Line 9, Patchset 2 (Latest):

Gamepads are now being enumerated by GamepadPlatformDataFetcherMac
instead of XboxDataFetcher due to macOS creating a virtual HID for the

Alvin Ji . unresolved

I wonder does this actually mean Xinput gamepads used to be enumerated by XboxDataFetecher but now are enumerated by GamepadPlatformDataFetcherMac instead. So it is now safe to remove the DCHECK_EQ and replace it with just a logging message for XInput gamepads?

Open in Gerrit

Related details

Attention is currently required from:

Matt Reynolds
Rob Pitkin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review

No-Unresolved-Comments

Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Matt Reynolds (Gerrit)

unread,

Jan 14, 2026, 7:25:34 PM (yesterday) Jan 14

to Rob Pitkin, Alvin Ji, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org

Attention needed from Rob Pitkin

Matt Reynolds added 1 comment

Commit Message

Line 9, Patchset 2 (Latest):

Gamepads are now being enumerated by GamepadPlatformDataFetcherMac
instead of XboxDataFetcher due to macOS creating a virtual HID for the

Alvin Ji . unresolved

I wonder does this actually mean Xinput gamepads used to be enumerated by XboxDataFetecher but now are enumerated by GamepadPlatformDataFetcherMac instead. So it is now safe to remove the DCHECK_EQ and replace it with just a logging message for XInput gamepads?

Matt Reynolds

On older macOS XInput gamepads will still be enumerated by XboxDataFetcher but on newer macOS XboxDataFetcher can't claim the USB interface because it's claimed by macOS. Newer macOS also creates a virtual HID gamepad representing the XInput gamepad, this virtual HID is the device seen by GamepadPlatformDataFetcherMac.

The DCHECK was originally added to make sure we weren't double-counting XInput devices in RecordConnectedGamepad which is called from both data fetchers. The DCHECK doesn't actually guard against double-counting, it's just a sanity check, so removing it shouldn't have any adverse effect.

I asked Rob to remove the DCHECK because on newer macOS it causes an unnecessary DCHECK failure whenever an XInput gamepad is connected.

Open in Gerrit

Related details

Attention is currently required from:

Rob Pitkin

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Alvin Ji (Gerrit)

unread,

6:25 PM (2 hours ago) 6:25 PM

to Rob Pitkin, Matt Reynolds, Chromium LUCI CQ, chromium...@chromium.org, mac-r...@chromium.org, mattreyno...@chromium.org

Attention needed from Rob Pitkin

Alvin Ji added 1 comment

Commit Message

Line 9, Patchset 2 (Latest):

Gamepads are now being enumerated by GamepadPlatformDataFetcherMac
instead of XboxDataFetcher due to macOS creating a virtual HID for the

Alvin Ji . unresolved

I wonder does this actually mean Xinput gamepads used to be enumerated by XboxDataFetecher but now are enumerated by GamepadPlatformDataFetcherMac instead. So it is now safe to remove the DCHECK_EQ and replace it with just a logging message for XInput gamepads?

Matt Reynolds

On older macOS XInput gamepads will still be enumerated by XboxDataFetcher but on newer macOS XboxDataFetcher can't claim the USB interface because it's claimed by macOS. Newer macOS also creates a virtual HID gamepad representing the XInput gamepad, this virtual HID is the device seen by GamepadPlatformDataFetcherMac.
The DCHECK was originally added to make sure we weren't double-counting XInput devices in RecordConnectedGamepad which is called from both data fetchers. The DCHECK doesn't actually guard against double-counting, it's just a sanity check, so removing it shouldn't have any adverse effect.
I asked Rob to remove the DCHECK because on newer macOS it causes an unnecessary DCHECK failure whenever an XInput gamepad is connected.

Alvin Ji

Thanks, in that case I wonder how would we address double enumeration case the original DCHECK wish to prevent. Wouldn't remove the DCHECK now reveal the original issue where the same controller can be duplicate in chooser? Should we log the message and return early?

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

gamepad: Remove DCHECK_EQ for XInput in GamepadPlatformDataFetcherMac [chromium/src : main]

Rob Pitkin (Gerrit)

Rob Pitkin added 1 comment

Related details

Matt Reynolds (Gerrit)

Matt Reynolds added 1 comment

Related details

Rob Pitkin (Gerrit)

Rob Pitkin added 2 comments

Related details

Alvin Ji (Gerrit)

Alvin Ji added 1 comment

Related details

Matt Reynolds (Gerrit)

Matt Reynolds added 1 comment

Related details

Alvin Ji (Gerrit)

Alvin Ji added 1 comment