Global media controls crashing with libstdc++

[Evangelos Foutras]

Chromium 100 enables kGlobalMediaControlsCastStartStop by default and it makes my libstdc++ build crash with a double free of some sort. The crash is reproducible by clicking on global media controls while a video is playing and then dismissing the dialog. I tried building with libstdc++ and ASan but it reports a violation while starting Chromium so that wasn't much help. A libc++ and ASan build did not report any issues while opening and closing the global media controls dialog.

I tested adding "cast_controller_->RemoveObserver(this)" to MediaItemUIDeviceSelectorView's destructor and it seemed to work, but I have no idea if it's the correct thing to do.

Perhaps someone more familiar with Chromium's code can spot the cause of this? I have attached a backtrace, though I'm not sure where the double free is originating.

[Lei Zhang]

I would suggest filing a report on crbug.com. Then it can be more
easily routed to the folks who work on this feature.

> --
> You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packag...@chromium.org.
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAA407mzibyN%2BP6FPgEtNfECF2P0D8TBKuD6w1GsHCaUKgPKy2A%40mail.gmail.com.

[Evangelos Foutras]

Hi Lei, filed it as https://crbug.com/1314342

(I was a bit hesitant to file it on crbug due to the non-standard configuration and no clear code bug, which is why I poked in here first.)