Fail build latest Dev channel 77.0.3854.3

34 views
Skip to first unread message

sL1pKn07 SpinFlo

unread,
Jul 21, 2019, 11:22:43 AM7/21/19
to chromium-...@chromium.org

Thomas Anderson

unread,
Jul 22, 2019, 2:29:38 PM7/22/19
to sL1pKn07 SpinFlo, chromium-packagers
Could you verify that this fixes the issue? https://chromium-review.googlesource.com/c/chromium/src/+/1713435

--
You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packag...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAAaYXTtpmTPjru%3DQpD9nOjoRfusa3Z2JETA0w7JZGMjAncJXdA%40mail.gmail.com.

sL1pKn07 SpinFlo

unread,
Jul 22, 2019, 3:07:48 PM7/22/19
to Thomas Anderson, chromium-packagers
El lun., 22 jul. 2019 a las 20:29, Thomas Anderson
(<thomasa...@chromium.org>) escribió:
Hi. thanks for the patch

yep, the error is gone. now in build process (when finish i'll report
again if works all as expected)

greetings

sL1pKn07 SpinFlo

unread,
Jul 22, 2019, 3:27:11 PM7/22/19
to Thomas Anderson, chromium-packagers
El lun., 22 jul. 2019 a las 21:07, sL1pKn07 SpinFlo
(<sl1p...@gmail.com>) escribió:
Hi. explodes in other site

FAILED: obj/ui/aura/aura/drag_drop_client.o
/tmp/makepkg/chromium-dev/src/chromium-77.0.3854.3/third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/ui/aura/aura/drag_drop_client.o.d -DAURA_IMPLEMENTATION
-DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSIN
G_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES
-D_GNU_SOURCE -DCR_CLANG_REVISION=\"365097-f7e52fbd-2\"
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2
-DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIO
NS_ENABLED=0 -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32
-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DWEBP_EXTERN=extern
-DVK_NO_PROTOTYPES -DGL_GLEXT_PROTOTYPES -DUSE_GLX -DUSE_EGL -DSK_GL
-DSK_HAS_PNG_LIBRARY -DSK_HAS_WEBP_LIBRARY
-DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig
.h\" -DSK_HAS_JPEG_LIBRARY
-DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\"
-DSK_VULKAN=1 -DSK_SUPPORT_GPU=1
-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"
-DVK_NO_PROTOTYPES -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0
-DUSE_CHROMIUM_ICU=1 -DU_STATIC
_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
-DUCHAR_TYPE=uint16_t -DGOOGLE_PROTOBUF_NO_RTTI
-DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD
-DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1
-DUSE_VULKAN_XLIB -I../.. -Igen -Igen/shim_headers/libpng_shim
-I../../thi
rd_party/libwebp/src -Igen/shim_headers/libdrm_shim
-I../../third_party/khronos -I../../gpu
-I../../third_party/vulkan/include -Igen/shim_headers/re2_shim
-I../../third_party/libyuv/include -Igen/shim_headers/opus_shim
-Igen/shim_headers/snappy_shim -Igen/third_party/dawn
-I../../third_party/
dawn/src/include -I../../third_party/skia
-I../../third_party/vulkan/include
-I../../third_party/skia/third_party/vulkanmemoryallocator
-I../../third_party/vulkan/include
-I../../third_party/boringssl/src/include -I../../third_party/ced/src
-I../../third_party/icu/source/common -I../../third_
party/icu/source/i18n -I../../third_party/protobuf/src
-I../../third_party/libwebm/source -I../../third_party/protobuf/src
-Igen/protoc_out -I../../third_party/leveldatabase
-I../../third_party/leveldatabase/src
-I../../third_party/leveldatabase/src/include
-I../../third_party/mesa_headers -f
profile-sample-use=../../chrome/android/profiles/afdo.prof
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread
-fcolor-diagnostics -fmerge-all-constants
-fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclan
g -mllvm -Xclang -instcombine-lower-dbg-declare=0 -flto=thin
-fsplit-lto-unit -fwhole-program-vtables -m64 -march=x86-64
-no-canonical-prefixes -Wall -Wextra -Wimplicit-fallthrough
-Wthread-safety -Wextra-semi -Wno-missing-field-initializers
-Wno-unused-parameter -Wno-c++11-narrowing -Wno-unn
eeded-internal-declaration -Wno-undefined-var-template
-Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections
-ffunction-sections -fno-omit-frame-pointer -g0 -fsanitize=cfi-vcall
-fsanitize-blacklist=../../tools/cfi/blacklist.txt
-fsanitize=cfi-icall -fvisibility=hidden -Xclang -add-plug
in -Xclang find-bad-constructs -Xclang -plugin-arg-find-bad-constructs
-Xclang check-ipc -Wheader-hygiene -Wstring-conversion
-Wtautological-overlap-compare -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include -I/usr/lib/libffi-3.2.1/include
-Wno-shorten-64-to-32 -std=c++14 -fno-exceptions -fn
o-rtti -fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -D__DATE__=
-D__TIME__= -D__TIMESTAMP__= -DNO_UNWIND_TABLES -march=native -O2
-pipe -fno-plt -Wno-builtin-macro-redefined -fno-unwind-tables
-fno-asynchronous-unwind-tables -c
../../ui/aura/client/drag_drop_client.cc -o obj/ui/aura/aura
/drag_drop_client.o
In file included from ../../ui/aura/client/drag_drop_client.cc:5:
../../ui/aura/client/drag_drop_client.h:35:37: error: no template
named 'unique_ptr' in namespace 'std'
virtual int StartDragAndDrop(std::unique_ptr<ui::OSExchangeData> data,
~~~~~^
1 error generated.


i think needs add a header in the file. searching on gerrit this type
of fail is a little pain

greetings

Thomas Anderson

unread,
Jul 22, 2019, 3:40:05 PM7/22/19
to sL1pKn07 SpinFlo, chromium-packagers
Those types of errors are common if you're setting use_custom_libcxx=false.  We recommend leaving it set to true.

sL1pKn07 SpinFlo

unread,
Jul 22, 2019, 3:50:35 PM7/22/19
to Thomas Anderson, chromium-packagers
El lun., 22 jul. 2019 a las 21:40, Thomas Anderson
Hi

the history why i use use_custom_libcxx=false
https://bugs.chromium.org/p/chromium/issues/detail?id=871078

greetings

Thomas Anderson

unread,
Jul 22, 2019, 4:05:38 PM7/22/19
to sL1pKn07 SpinFlo, chromium-packagers
libc++ and re2 are not compatible.  You need to use the bundled re2.

sL1pKn07 SpinFlo

unread,
Jul 22, 2019, 4:50:46 PM7/22/19
to Thomas Anderson, chromium-packagers
El lun., 22 jul. 2019 a las 22:05, Thomas Anderson
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAMEXDrmWF0BF1RobQ6x_v%2BsNwfM3-Yo0%3D6d7SjkbzHyuTdad2g%40mail.gmail.com.

hi again, this also related with the use_custom_libcxx=false?

FAILED: obj/chrome/browser/ui/ui/bookmark_drag_drop.o
/tmp/makepkg/chromium-dev/src/chromium-77.0.3854.3/third_party/llvm-build/Release+Asserts/bin/clang++
-MMD -MF obj/chrome/browser/ui/ui/bookmark_drag_drop.o.d -DUSE_DBUS
-DUSE_UDEV -DUSE_AURA=1 -DUSE_GLIB=1 -DUSE_NSS_CERTS=1 -DUSE_X11=1
-DFULL_SAFE_BROWSING -DSAFE_BROWSING_CSD -DSAFE_BROWSING
_DB_LOCAL -DOFFICIAL_BUILD -DCHROMIUM_BUILD -D_FILE_OFFSET_BITS=64
-D_LARGEFILE_SOURCE -D_LARGEFILE64_SOURCE -DNO_UNWIND_TABLES
-D_GNU_SOURCE -DCR_CLANG_REVISION=\"365097-f7e52fbd-2\"
-D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D_FORTIFY_SOURCE=2
-DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATION
S_ENABLED=0 -DUSE_CUPS -DGLIB_VERSION_MAX_ALLOWED=GLIB_VERSION_2_32
-DGLIB_VERSION_MIN_REQUIRED=GLIB_VERSION_2_26 -DWEBP_EXTERN=extern
-DTOOLKIT_VIEWS=1 -DVK_NO_PROTOTYPES -DGL_GLEXT_PROTOTYPES -DUSE_GLX
-DUSE_EGL -DSYNC_PASSWORD_REUSE_DETECTION_ENABLED
-DEXPAT_RELATIVE_PATH -DGOOGLE_PROTOBUF
_NO_RTTI -DGOOGLE_PROTOBUF_NO_STATIC_INITIALIZER -DHAVE_PTHREAD
-DLEVELDB_PLATFORM_CHROMIUM=1 -DLEVELDB_PLATFORM_CHROMIUM=1
-DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DUSE_CHROMIUM_ICU=1
-DU_STATIC_IMPLEMENTATION -DICU_UTIL_DATA_IMPL=ICU_UTIL_DATA_FILE
-DUCHAR_TYPE=uint16_t -DWEBRTC_NON_S
TATIC_TRACE_EVENT_HANDLERS=0 -DWEBRTC_CHROMIUM_BUILD -DWEBRTC_POSIX
-DWEBRTC_LINUX -DABSL_ALLOCATOR_NOTHROW=1 -DNO_MAIN_THREAD_WRAPPING
-DV8_USE_EXTERNAL_STARTUP_DATA -DSK_GL -DSK_HAS_PNG_LIBRARY
-DSK_HAS_WEBP_LIBRARY
-DSK_USER_CONFIG_HEADER=\"../../skia/config/SkUserConfig.h\"
-DSK_HAS_JPEG_
LIBRARY -DSK_VULKAN_HEADER=\"../../skia/config/SkVulkanConfig.h\"
-DSK_VULKAN=1 -DSK_SUPPORT_GPU=1
-DSK_GPU_WORKAROUNDS_HEADER=\"gpu/config/gpu_driver_bug_workaround_autogen.h\"
-DVK_NO_PROTOTYPES -DV8_DEPRECATION_WARNINGS
-DPERFETTO_BUILD_WITH_EMBEDDER -DPERFETTO_BUILD_WITH_CHROMIUM -DPERFET
TO_FORCE_DLOG=0
-DI18N_ADDRESS_VALIDATION_DATA_URL=\"https://chromium-i18n.appspot.com/ssl-aggregate-address/\"
-I../.. -Igen -Igen/shim_headers/re2_shim
-Igen/shim_headers/snappy_shim -I../../third_party/libyuv/include
-Igen/shim_headers/libpng_shim -I../../third_party/libwebp/src
-Igen/shim
_headers/libdrm_shim -I../../third_party/khronos -I../../gpu
-I../../third_party/vulkan/include -Igen/shim_headers/opus_shim
-Igen/third_party/dawn -I../../third_party/dawn/src/include
-Igen/shim_headers/flac_shim -I../../third_party/protobuf/src
-Igen/protoc_out -I../../third_party/protobuf/
src -I../../third_party/boringssl/src/include
-I../../third_party/cacheinvalidation/overrides
-I../../third_party/cacheinvalidation/src
-I../../third_party/leveldatabase
-I../../third_party/leveldatabase/src
-I../../third_party/leveldatabase/src/include
-I../../third_party/ced/src -I../../thi
rd_party/icu/source/common -I../../third_party/icu/source/i18n
-I../../third_party/webrtc_overrides -I../../third_party/webrtc
-Igen/third_party/webrtc -I../../third_party/abseil-cpp
-I../../third_party/skia -I../../third_party/vulkan/include
-I../../third_party/skia/third_party/vulkanmemorya
llocator -I../../third_party/vulkan/include
-I../../third_party/libwebm/source -I../../v8/include -Igen/v8/include
-I../../third_party/perfetto/include -Igen/third_party/perfetto/protos
-Igen/third_party/perfetto/protos -Igen/third_party/perfetto/protos
-Igen/third_party/perfetto/protos -Igen
/third_party/perfetto/protos -Igen/third_party/perfetto/protos
-Igen/third_party/metrics_proto -I../../third_party/mesa_headers -Igen
-Igen -Igen -Igen -I../../third_party/libaddressinput/src/cpp/include
-Igen/components/sync/protocol
-I../../third_party/flatbuffers/src/include -I../../third_
party/brotli/include -I../../third_party/zlib -Igen -Igen -Igen -Igen
-Igen -fprofile-sample-use=../../chrome/android/profiles/afdo.prof
-fno-strict-aliasing --param=ssp-buffer-size=4 -fstack-protector
-fno-unwind-tables -fno-asynchronous-unwind-tables -fPIC -pthread
-fcolor-diagnostics -fmer
ge-all-constants
-fcrash-diagnostics-dir=../../tools/clang/crashreports -Xclang -mllvm
-Xclang -instcombine-lower-dbg-declare=0 -flto=thin -fsplit-lto-unit
-fwhole-program-vtables -m64 -march=x86-64 -no-canonical-prefixes
-Wall -Wextra -Wimplicit-fallthrough -Wthread-safety -Wextra-semi
-Wno-
missing-field-initializers -Wno-unused-parameter -Wno-c++11-narrowing
-Wno-unneeded-internal-declaration -Wno-undefined-var-template
-Wno-ignored-pragma-optimize -O2 -fno-ident -fdata-sections
-ffunction-sections -fno-omit-frame-pointer -g0 -fsanitize=cfi-vcall
-fsanitize-blacklist=../../tool
s/cfi/blacklist.txt -fsanitize=cfi-icall -fvisibility=hidden -Xclang
-add-plugin -Xclang find-bad-constructs -Xclang
-plugin-arg-find-bad-constructs -Xclang check-ipc -Wheader-hygiene
-Wstring-conversion -Wtautological-overlap-compare
-Wexit-time-destructors -I/usr/include/glib-2.0 -I/usr/lib
/glib-2.0/include -I/usr/lib/libffi-3.2.1/include
-Wno-shorten-64-to-32 -Wno-header-guard -I/usr/include/nss
-I/usr/include/nspr -I/usr/include/dbus-1.0
-I/usr/lib/dbus-1.0/include -std=c++14 -fno-exceptions -fno-rtti
-fvisibility-inlines-hidden -D_FORTIFY_SOURCE=2 -D__DATE__=
-D__TIME__= -
D__TIMESTAMP__= -DNO_UNWIND_TABLES -march=native -O2 -pipe -fno-plt
-Wno-builtin-macro-redefined -fno-unwind-tables
-fno-asynchronous-unwind-tables -c
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.cc -o
obj/chrome/browser/ui/ui/bookmark_drag_drop.o
In file included from ../../chrome/browser/ui/bookmarks/bookmark_drag_drop.cc:5:
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:31:34: error:
no member named 'unique_ptr' in namespace 'std'
base::OnceCallback<void(std::unique_ptr<ui::OSExchangeData> drag_data,
~~~~~^
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:31:63: error:
expected '(' for function-style cast or type construction
base::OnceCallback<void(std::unique_ptr<ui::OSExchangeData> drag_data,
~~~~~~~~~~~~~~~~~~^
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:31:65: error:
use of undeclared identifier 'drag_data'
base::OnceCallback<void(std::unique_ptr<ui::OSExchangeData> drag_data,
^
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:32:45: error:
expected '(' for function-style cast or type construction
gfx::NativeView native_view,
~~~~~~~~~~~~~~~ ^
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:33:64: error:
expected '(' for function-style cast or type construction
ui::DragDropTypes::DragEventSource source,
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:34:40: error:
expected '(' for function-style cast or type construction
gfx::Point start_point,
~~~~~~~~~~ ^
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:35:33: error:
expected '(' for function-style cast or type construction
int operation)>;
~~~ ^
../../chrome/browser/ui/bookmarks/bookmark_drag_drop.h:66:27: error:
unknown type name 'DoBookmarkDragCallback'
DoBookmarkDragCallback do_drag_callback);
^
8 errors generated.


greetings

Lei Zhang

unread,
Jul 22, 2019, 5:15:25 PM7/22/19
to sL1pKn07 SpinFlo, Thomas Anderson, chromium-packagers
It may just be that particular header not doing IWYU. If you #include <memory>, does that fix the problem?

sL1pKn07 SpinFlo

unread,
Jul 22, 2019, 5:19:55 PM7/22/19
to Lei Zhang, Thomas Anderson, chromium-packagers
Hi

memory in ui/aura/client/drag_drop_client.h yes. but explode in the
other part (see mi last email)


now in test/build with use_custom_libcxx=true and bundled Re2

greetings

Lei Zhang

unread,
Jul 22, 2019, 5:21:55 PM7/22/19
to sL1pKn07 SpinFlo, Thomas Anderson, chromium-packagers

sL1pKn07 SpinFlo

unread,
Jul 22, 2019, 5:31:55 PM7/22/19
to Lei Zhang, Thomas Anderson, chromium-packagers
Hi, let me check

thanks for the help @thestig & @thomasanderson


greetings

sL1pKn07 SpinFlo

unread,
Jul 23, 2019, 9:58:24 AM7/23/19
to Lei Zhang, Thomas Anderson, chromium-packagers
El lun., 22 jul. 2019 a las 23:31, sL1pKn07 SpinFlo
Hi

with libcxx=false, system RE2 and your patch fail in the last rule

FAILED: chromium-dev
/tmp/makepkg/chromium-dev/src/chromium-77.0.3854.3/third_party/llvm-build/Release+Asserts/bin/clang++
-Wl,--version-script=../../build/linux/chrome.map -Wl,--fatal-warnings
-Wl,--build-id=sha1 -fPIC -Wl,-z,noexecstack -Wl,-z,relro -Wl,-z,now
-Wl,-z,defs -Wl,--as-needed -fuse-ld=/tmp/makepkg/c
hromium-dev/src/chromium-77.0.3854.3/third_party/llvm-build/Release+Asserts/bin/ld.lld
-Wl,--icf=all -Wl,--color-diagnostics -flto=thin -Wl,--thinlto-jobs=8
-Wl,--thinlto-cache-dir=thinlto-cache
-Wl,--thinlto-cache-policy,cache_size=10\%:cache_size_bytes=10g:cache_size_files=100000
-Wl,--lto-
O0 -fwhole-program-vtables -m64 -Wl,-O2 -Wl,--gc-sections -rdynamic
-fsanitize=cfi-vcall -fsanitize=cfi-icall -pie -Wl,--disable-new-dtags
-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now -o "./chromium-dev"
-Wl,--start-group @"./chromium-dev.rsp" -Wl,--end-group -latomic
-ldl -lpthread -
lrt -lX11 -lX11-xcb -lxcb -lXcomposite -lXcursor -lXdamage -lXext
-lXfixes -lXi -lXrender -lXtst -lgmodule-2.0 -lgobject-2.0
-lgthread-2.0 -lglib-2.0 -lsmime3 -lnss3 -lnssutil3 -lplds4 -lplc4
-lnspr4 -lva -lcups -lgssapi_krb5 -lkrb5 -lk5crypto -lcom_err -lz -lm
-lcrypt -lxml2 -lfontconfig -ld
bus-1 -lXss -lresolv -lpng16 -lfreetype -ljpeg -lexpat -lharfbuzz
-ldrm -lXrandr -lre2 -lsnappy -lpci -lasound -lpulse -lopus -latk-1.0
-latk-bridge-2.0 -lpangocairo-1.0 -lpango-1.0 -lcairo -latspi -lFLAC
-lgtk-3 -lgdk-3 -lcairo-gobject -lgdk_pixbuf-2.0 -lgio-2.0 -lxslt
-lopenh264
ld.lld: error: undefined symbol: hb_subset_input_destroy
>>> referenced by ld-temp.o
>>> lto.tmp:(base::internal::Invoker<base::internal::BindState<base::OnceCallback<void (std::unique_ptr<media::AudioDecoder, std::default_delete<media::AudioDecoder> >, std::unique_ptr<media::DecryptingDemuxerStream, std::default_delete<media::DecryptingDemuxerStream> >)>, std::
unique_ptr<media::AudioDecoder,
std::default_delete<media::AudioDecoder> >,
std::unique_ptr<media::DecryptingDemuxerStream,
std::default_delete<media::DecryptingDemuxerStream> > >, void
()>::RunOnce(base::internal::BindStateBase*))
>>> referenced by SkPDFSubsetFont.cpp
>>> thinlto-cache/Thin-91392f.tmp.o:(SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int))

ld.lld: error: undefined symbol: hb_subset_input_create_or_fail
>>> referenced by SkPDFSubsetFont.cpp
>>> thinlto-cache/Thin-91392f.tmp.o:(SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int))

ld.lld: error: undefined symbol: hb_subset_input_glyph_set
>>> referenced by SkPDFSubsetFont.cpp
>>> thinlto-cache/Thin-91392f.tmp.o:(SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int))

ld.lld: error: undefined symbol: hb_subset_input_set_retain_gids
>>> referenced by SkPDFSubsetFont.cpp
>>> thinlto-cache/Thin-91392f.tmp.o:(SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int))

ld.lld: error: undefined symbol: hb_subset_input_set_drop_hints
>>> referenced by SkPDFSubsetFont.cpp
>>> thinlto-cache/Thin-91392f.tmp.o:(SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int))

ld.lld: error: undefined symbol: hb_subset
>>> referenced by SkPDFSubsetFont.cpp
>>> thinlto-cache/Thin-91392f.tmp.o:(SkPDFSubsetFont(sk_sp<SkData>, SkPDFGlyphUse const&, SkPDF::Metadata::Subsetter, char const*, int))
clang: error: linker command failed with exit code 1 (use -v to see invocation)
ninja: build stopped: subcommand failed.

now in test libcxx=true, bundled RE2 and of course, your patch

greetings

sL1pKn07 SpinFlo

unread,
Jul 23, 2019, 12:09:32 PM7/23/19
to Lei Zhang, Thomas Anderson, chromium-packagers
El mar., 23 jul. 2019 a las 15:57, sL1pKn07 SpinFlo
Hi. same exactly output in the last rule with libcxx=true, bundled RE2
and the patch

greetings

Raphael Kubo Da Costa

unread,
Jul 23, 2019, 12:32:02 PM7/23/19
to chromium-packagers, the...@google.com, thomasa...@chromium.org
I think this one's caused by you setting use_system_harfbuzz=true. Upstream HarfBuzz's build system creates libharfbuzz.so, libharfbuzz-subset.so and a few other libraries, while //third_party/harfbuzz-ng/BUILD.gn just generates a source set that gets built into libfreetype_harfbuzz.{so,a}.

Those missing symbols are in libharfbuzz-subset.so; does it work if you add "harfbuzz-subset" to |packages| in the |use_system_harfbuzz| block in //third_party/harfbuzz-ng/BUILD.gn?

sL1pKn07 SpinFlo

unread,
Jul 23, 2019, 1:24:16 PM7/23/19
to Raphael Kubo Da Costa, chromium-packagers, the...@google.com, thomasa...@chromium.org
El mar., 23 jul. 2019 a las 18:32, Raphael Kubo Da Costa
(<raphael.ku...@intel.com>) escribió:
> --
> You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packag...@chromium.org.
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/64de0f1f-3c56-4276-8727-a7fbf07d8d7b%40chromium.org.

Hi raphael,

thrird_party/harfbuzz-ng is "removed" in the build with
'remove_bundled_libraries.py' script. libharfbuzz-subset.so is part
(/usr/lib/libharfbuzz-subset.so) of the system harfbuzz 2.5.3 package
https://www.archlinux.org/packages/extra/x86_64/harfbuzz/files/

greetings

Kubo Da Costa, Raphael

unread,
Jul 23, 2019, 1:56:07 PM7/23/19
to sl1p...@gmail.com, thomasa...@chromium.org, chromium-...@chromium.org, the...@google.com
remove_bundled_libraries.py doesn't remove the GN files (i.e.
third_party/harfbuzz-ng/BUILD.gn is still there), so my point, which is
that you probably need to link against both libharfbuzz.so as well as
libharfbuzz-subset.so rather than only the former, is still valid.

sL1pKn07 SpinFlo

unread,
Jul 23, 2019, 2:55:02 PM7/23/19
to Kubo Da Costa, Raphael, thomasa...@chromium.org, chromium-...@chromium.org, the...@google.com
El mar., 23 jul. 2019 a las 19:56, Kubo Da Costa, Raphael
(<raphael.ku...@intel.com>) escribió:
> --
> You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packag...@chromium.org.
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/65b34ccf2987e47f4b18137941837800b790697f.camel%40intel.com.


Hi raphael, for that i point removed word with " "

then, i understand ok, i need add the word "harfbuzz-subset" into
`packages = [ "harfbuzz" ]` ?

greetings

Kubo Da Costa, Raphael

unread,
Jul 23, 2019, 3:01:15 PM7/23/19
to sl1p...@gmail.com, thomasa...@chromium.org, chromium-...@chromium.org, the...@google.com
On Tue, 2019-07-23 at 20:54 +0200, sL1pKn07 SpinFlo wrote:
> Hi raphael, for that i point removed word with " "
>
> then, i understand ok, i need add the word "harfbuzz-subset" into
> `packages = [ "harfbuzz" ]` ?

You need something like this:

diff --git a/third_party/harfbuzz-ng/BUILD.gn b/third_party/harfbuzz-
ng/BUILD.gn
index 37d8e334c262..6610cc6a15ac 100644
--- a/third_party/harfbuzz-ng/BUILD.gn
+++ b/third_party/harfbuzz-ng/BUILD.gn
@@ -16,7 +16,7 @@ if (use_system_harfbuzz) {
"//third_party:freetype_harfbuzz",
"//third_party/freetype:freetype_source",
]
- packages = [ "harfbuzz" ]
+ packages = [ "harfbuzz", "harfbuzz-subset" ]
}
} else {
config("harfbuzz_config") {

I'm testing a build with use_system_harfbuzz=true here and will send a
CL if I'm able to reproduce the failure locally.

sL1pKn07 SpinFlo

unread,
Jul 23, 2019, 3:04:21 PM7/23/19
to Kubo Da Costa, Raphael, thomasa...@chromium.org, chromium-...@chromium.org, the...@google.com
El mar., 23 jul. 2019 a las 21:01, Kubo Da Costa, Raphael
(<raphael.ku...@intel.com>) escribió:
>
> --
> You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packag...@chromium.org.
> To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/f5fd0b83f38aefe319d20dbf7d9146b255f69da5.camel%40intel.com.

Roger!

testing in my machine now. at the moment, seems i need rebuild all
with this change. in 2h (or more/less) back

greethings and very thanks for point me in the correct way in this issue snip!

greetings

sL1pKn07 SpinFlo

unread,
Jul 23, 2019, 6:05:47 PM7/23/19
to Kubo Da Costa, Raphael, thomasa...@chromium.org, chromium-...@chromium.org, the...@google.com
El mar., 23 jul. 2019 a las 21:03, sL1pKn07 SpinFlo
(<sl1p...@gmail.com>) escribió:
>
Hi again

tested and works without problem! (libcxx=true + bundled RE2 + Raphael
workground)

waiting to official patch/review

greetings!

Kubo Da Costa, Raphael

unread,
Jul 24, 2019, 6:59:07 AM7/24/19
to sl1p...@gmail.com, chromium-...@chromium.org
On Wed, 2019-07-24 at 00:05 +0200, sL1pKn07 SpinFlo wrote:
> Hi again
>
> tested and works without problem! (libcxx=true + bundled RE2 +
> Raphael
> workground)
>
> waiting to official patch/review
>
> greetings!

I'm glad to hear that. The patch above has been submitted as
https://chromium-review.googlesource.com/c/chromium/src/+/1715288
Reply all
Reply to author
Forward
0 new messages