recent gn changes break the chromium build

[Olivier Tilloy]

Hello chromium packagers,

The following two gn changes were rolled out in the latest stable tarball (74.0.3729.169):

    https://gn-review.googlesource.com/c/gn/+/4960

    https://gn-review.googlesource.com/c/gn/+/4980

They broke the chromium build because the corresponding changes in chromium aren't in the tarball, and I had to distro-patch to revert them in the ubuntu packages.

It seems to me those changes were rolled out a bit too eagerly, especially considering it's a stable update.

Regards,

 Olivier

[Raphael Kubo Da Costa]

That's an unfortunate consequence of the tarballs being created with GN's latest master. FWIW, the "Build from tarball" bot is equally broken, even for M76: https://ci.chromium.org/p/infra/builders/cron/Build%20From%20Tarball/b8912764678745993152

Non-tarball builds are not affected because the GN binary is pinned in either //buildtools/<arch>/gn.sha1 or in //DEPS (depending on the branch), I wonder if something similar could be done when creating the tarball, as this is not the first time we've had issues caused by GN for a non-dev release being out of sync with the rest of the code.

[Thomas Anderson]

(Resending from my @chromium.org account)

I've been meaning to checkout a versioned gn for the tarball for a while now.  I guess now's a good time to make that happen :)

Created bug 966066 which I'll try to get to today.  Once it's fixed, the tarballs should start working again.

[Olivier Tilloy]

On Wed, May 22, 2019 at 7:06 PM Thomas Anderson <thomasa...@chromium.org> wrote:

(Resending from my @chromium.org account)

I've been meaning to checkout a versioned gn for the tarball for a while now.  I guess now's a good time to make that happen :)

Created bug 966066 which I'll try to get to today.  Once it's fixed, the tarballs should start working again.

Thanks Raphael and Thomas. I wasn't aware the tarballs were created with the latest master for GN. That explains it, indeed. I'll be eagerly waiting for that fix.

On Wed, May 22, 2019 at 8:56 AM Raphael Kubo Da Costa <raphael.ku...@intel.com> wrote:

That's an unfortunate consequence of the tarballs being created with GN's latest master. FWIW, the "Build from tarball" bot is equally broken, even for M76: https://ci.chromium.org/p/infra/builders/cron/Build%20From%20Tarball/b8912764678745993152

Non-tarball builds are not affected because the GN binary is pinned in either //buildtools/<arch>/gn.sha1 or in //DEPS (depending on the branch), I wonder if something similar could be done when creating the tarball, as this is not the first time we've had issues caused by GN for a non-dev release being out of sync with the rest of the code.

On Wednesday, May 22, 2019 at 10:31:20 AM UTC+2, Olivier Tilloy wrote:

Hello chromium packagers,

The following two gn changes were rolled out in the latest stable tarball (74.0.3729.169):

    https://gn-review.googlesource.com/c/gn/+/4960

    https://gn-review.googlesource.com/c/gn/+/4980

They broke the chromium build because the corresponding changes in chromium aren't in the tarball, and I had to distro-patch to revert them in the ubuntu packages.

It seems to me those changes were rolled out a bit too eagerly, especially considering it's a stable update.

Regards,

 Olivier

--
You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packag...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/CAMEXDr%3Dwk%3DW20si08CLkVVnGTHkYu-eia3iPjWNrkqTKnwDhZA%40mail.gmail.com.