Chromium 66.0.3359.106 tarball missing third_party/blink/tools/blinkpy/common/* files

[Tomáš Popela]

Hi,

just a heads-up that I'm not able to build Chromium from the 66.0.3359.106 tarball:

ninja -C out/Release -vvv chrome chromedriver chrome_sandbox widevinecdmadapter policy_templates

ninja: Entering directory `out/Release'

ninja: error: '../../third_party/blink/tools/blinkpy/common/name_style_converter.py', needed by 'gen/blink/bindings/core/v8/add_event_listener_options_or_boolean.cc', missing and no known rule to make it

the third_party/blink/tools/blinkpy/common directory is indeed empty. It's probably a regression after https://bugs.chromium.org/p/chromium/issues/detail?id=829697

Tom

[Raphael Kubo Da Costa]

Yep, this is https://bugs.chromium.org/p/chromium/issues/detail?id=832283, which was fixed earlier today.

[Tomáš Popela]

It's not fixed. The 66.0.3359.117 tarball is still not buildable..

Dne pátek 13. dubna 2018 13:59:19 UTC+2 Raphael Kubo Da Costa napsal(a):

[Raphael Kubo Da Costa]

It was fixed and un-fixed :-)

The bug was reopened earlier today, so upstream's aware of the issue (https://ci.chromium.org/buildbot/chromium.infra.cron/Build%20From%20Tarball/ is also broken). For now I guess anyone packaging M66 will need to manually add the contents https://chromium.googlesource.com/chromium/src.git/+/66.0.3359.117/third_party/blink to their source tree.

[Tomáš Popela]

Dne středa 18. dubna 2018 11:03:45 UTC+2 Raphael Kubo Da Costa napsal(a):

It was fixed and un-fixed :-)

The bug was reopened earlier today, so upstream's aware of the issue (https://ci.chromium.org/buildbot/chromium.infra.cron/Build%20From%20Tarball/ is also broken). For now I guess anyone packaging M66 will need to manually add the contents https://chromium.googlesource.com/chromium/src.git/+/66.0.3359.117/third_party/blink to their source tree.

That's not very convenient.. Wouldn't it be possible to regenerate the tarball once it's fixed and upload it again?

[Raphael Kubo Da Costa]

Maybe (+thomasanderson and tkent, as I don't know how feasible it is from a Google-infra point of view). My point is that anyone trying to package 66.0.3359.117 _now_ will need to add those missing files themselves.

[Olivier Tilloy]

On Wed, Apr 18, 2018 at 11:03 AM, Raphael Kubo Da Costa
<raphael.ku...@intel.com> wrote:
> It was fixed and un-fixed :-)
>
> The bug was reopened earlier today, so upstream's aware of the issue
> (https://ci.chromium.org/buildbot/chromium.infra.cron/Build%20From%20Tarball/
> is also broken). For now I guess anyone packaging M66 will need to manually
> add the contents
> https://chromium.googlesource.com/chromium/src.git/+/66.0.3359.117/third_party/blink
> to their source tree.

This is what we do for the Ubuntu packages, currently building:
https://bazaar.launchpad.net/~chromium-team/chromium-browser/bionic-stable/view/head:/debian/patches/add-missing-blink-tools.patch

> On Wednesday, April 18, 2018 at 10:52:56 AM UTC+2, Tomáš Popela wrote:
>>
>> It's not fixed. The 66.0.3359.117 tarball is still not buildable..
>>
>> Dne pátek 13. dubna 2018 13:59:19 UTC+2 Raphael Kubo Da Costa napsal(a):
>>>
>>> Yep, this is
>>> https://bugs.chromium.org/p/chromium/issues/detail?id=832283, which was
>>> fixed earlier today.
>>>
>>> On Friday, April 13, 2018 at 1:50:53 PM UTC+2, Tomáš Popela wrote:
>>>>
>>>> Hi,
>>>>
>>>> just a heads-up that I'm not able to build Chromium from the
>>>> 66.0.3359.106 tarball:
>>>>
>>>> ninja -C out/Release -vvv chrome chromedriver chrome_sandbox
>>>> widevinecdmadapter policy_templates
>>>> ninja: Entering directory `out/Release'
>>>> ninja: error:
>>>> '../../third_party/blink/tools/blinkpy/common/name_style_converter.py',
>>>> needed by
>>>> 'gen/blink/bindings/core/v8/add_event_listener_options_or_boolean.cc',
>>>> missing and no known rule to make it
>>>>
>>>> the third_party/blink/tools/blinkpy/common directory is indeed empty.
>>>> It's probably a regression after
>>>> https://bugs.chromium.org/p/chromium/issues/detail?id=829697
>>>>
>>>> Tom
>

> --
> You received this message because you are subscribed to the Google Groups
> "chromium-packagers" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to chromium-packag...@chromium.org.
> To view this discussion on the web visit
> https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/0eebb9a8-6601-4411-b969-c78fd4b2691f%40chromium.org.

[Raphael Kubo Da Costa]

Thinking out loud here: it should be possible to regenerate the tarball if the existing one is removed from Google Storage and the tag is pushed again (the latter has already happened before in https://bugs.chromium.org/p/chromium/issues/detail?id=815124, not sure about the former).

[Michael Moss]

Can you clarify why the tag needs to be pushed again? Is there something wrong with what's in the tagged DEPS? I thought this was just an issue with the tarball scripts. 

--
You received this message because you are subscribed to the Google Groups "chromium-packagers" group.

To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packagers+unsub...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/1d2df6e8-950f-4a7a-9e06-822222cb1621%40chromium.org.

[Raphael Kubo Da Costa]

On Wednesday, April 18, 2018 at 4:40:11 PM UTC+2, Michael Moss wrote:

On Wed, Apr 18, 2018 at 2:16 AM, Raphael Kubo Da Costa <raphael.ku...@intel.com> wrote:

On Wednesday, April 18, 2018 at 11:10:33 AM UTC+2, Raphael Kubo Da Costa wrote:

On Wednesday, April 18, 2018 at 11:07:09 AM UTC+2, Tomáš Popela wrote:

Dne středa 18. dubna 2018 11:03:45 UTC+2 Raphael Kubo Da Costa napsal(a):

It was fixed and un-fixed :-)

The bug was reopened earlier today, so upstream's aware of the issue (https://ci.chromium.org/buildbot/chromium.infra.cron/Build%20From%20Tarball/ is also broken). For now I guess anyone packaging M66 will need to manually add the contents https://chromium.googlesource.com/chromium/src.git/+/66.0.3359.117/third_party/blink to their source tree.

That's not very convenient.. Wouldn't it be possible to regenerate the tarball once it's fixed and upload it again?

Maybe (+thomasanderson and tkent, as I don't know how feasible it is from a Google-infra point of view). My point is that anyone trying to package 66.0.3359.117 _now_ will need to add those missing files themselves.

Thinking out loud here: it should be possible to regenerate the tarball if the existing one is removed from Google Storage and the tag is pushed again (the latter has already happened before in https://bugs.chromium.org/p/chromium/issues/detail?id=815124, not sure about the former).

Can you clarify why the tag needs to be pushed again? Is there something wrong with what's in the tagged DEPS? I thought this was just an issue with the tarball scripts. 

Like I said, I'm not familiar with how things work internally over there, and I recalled that earlier tag push + tarball publishing bug. In retrospect, I guess in that case the publish_tarball bot was being triggered because of the lack of a tarball corresponding to a specific version, not because the tag was pushed again, so sorry for the false alarm there.

[Michael Moss]

Yeah, in that case, the tagged DEPS file was completely broken. Normally tags should be immutable, but since it was basically useless (for everyone, not just tarball creation), we decided to repush it. I don't think that's the case here. 

--
You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packagers+unsub...@chromium.org.

To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/ee67882e-a81a-4f18-826e-57f83e3c8838%40chromium.org.