gn needs C++17 support to compile

11 views
Skip to first unread message

Saikrishna Arcot

unread,
Mar 15, 2020, 1:22:05 PM3/15/20
to chromium-packagers
The source code used to compile gn needs C++17 support. However, the C++ headers in buildtools/third_party directory only have C++14 headers, and Ubuntu Xenial's libstdc++ doesn't have C++17 support. Is it possible to update the headers there to have C++17 support?

Thomas Anderson

unread,
Mar 16, 2020, 1:59:00 PM3/16/20
to Saikrishna Arcot, chromium-packagers, Tom Anderson
On Sun, Mar 15, 2020 at 10:22 AM Saikrishna Arcot <saiar...@gmail.com> wrote:
The source code used to compile gn needs C++17 support. However, the C++ headers in buildtools/third_party directory only have C++14 headers,

The headers in buildtools/third_party/libc++ are bleeding edge.  They have C++2a support.
 
and Ubuntu Xenial's libstdc++ doesn't have C++17 support. Is it possible to update the headers there to have C++17 support?

Are you building with tools/gn/bootstrap/bootstrap.py --use-custom-libcxx ?  The build_from_tarball bot is running Xenial and builds using that (https://source.chromium.org/chromium/infra/infra/+/master:recipes/recipes/build_from_tarball.py;drc=f03dc51e54cda2deb6d7783ea85d191ca7937a3c;l=116?originalUrl=https:%2F%2Fcs.chromium.org%2F), and the bot is currently green:

--
You received this message because you are subscribed to the Google Groups "chromium-packagers" group.
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-packag...@chromium.org.
To view this discussion on the web visit https://groups.google.com/a/chromium.org/d/msgid/chromium-packagers/344d03a6-30c4-439d-854d-3b15314b14dc%40chromium.org.

Saikrishna Arcot

unread,
Mar 19, 2020, 11:00:51 AM3/19/20
to chromium-packagers

I had a local patch that was messing things up. The --use-custom-libcxx flag works fine.

-- 
Saikrishna Arcot
signature.asc
Reply all
Reply to author
Forward
0 new messages