TESTONLY: disable CONFIG_DRM_FBDEV_EMULATION [chromiumos/third_party/kernel : chromeos-4.4]

44 views
Skip to first unread message

Jeffy Chen (Gerrit)

unread,
Oct 26, 2016, 12:27:10 AM10/26/16
to Douglas Anderson, Brian Norris
Hello Douglas Anderson, Brian Norris,

I'd like you to do a code review. Please visit

https://chromium-review.googlesource.com/403629

to review the following change.


Change subject: TESTONLY: disable CONFIG_DRM_FBDEV_EMULATION
......................................................................

TESTONLY: disable CONFIG_DRM_FBDEV_EMULATION

Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Signed-off-by: Jeffy Chen <jeffy...@rock-chips.com>
---
M chromeos/config/base.config
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/chromeos/config/base.config b/chromeos/config/base.config
index f2ae30b..3de3798 100644
--- a/chromeos/config/base.config
+++ b/chromeos/config/base.config
@@ -522,7 +522,7 @@
CONFIG_DRM=y
CONFIG_DRM_BRIDGE=y
CONFIG_DRM_EVDI=m
-CONFIG_DRM_FBDEV_EMULATION=y
+# CONFIG_DRM_FBDEV_EMULATION is not set
# CONFIG_DRM_I2C_ADV7511 is not set
# CONFIG_DRM_I2C_CH7006 is not set
# CONFIG_DRM_I2C_NXP_TDA998X is not set

--
To view, visit https://chromium-review.googlesource.com/403629
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Owner: Jeffy Chen <jeffy...@rock-chips.com>
Gerrit-Reviewer: Brian Norris <brian...@chromium.org>
Gerrit-Reviewer: Douglas Anderson <dian...@chromium.org>

Douglas Anderson (Gerrit)

unread,
Oct 26, 2016, 3:23:40 PM10/26/16
to Jeffy Chen, Tomasz Figa, Brian Norris
Douglas Anderson has posted comments on this change. (
https://chromium-review.googlesource.com/403629 )

Change subject: TESTONLY: disable CONFIG_DRM_FBDEV_EMULATION
......................................................................


Patch Set 1:

See chrome-os-partner:58765 for reference. Do we want to add a proper
description to this and land it?
--
To view, visit https://chromium-review.googlesource.com/403629
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Owner: Jeffy Chen <jeffy...@rock-chips.com>
Gerrit-Reviewer: Brian Norris <brian...@chromium.org>
Gerrit-Reviewer: Douglas Anderson <dian...@chromium.org>
Gerrit-Reviewer: Tomasz Figa <tf...@chromium.org>
Gerrit-HasComments: No

Stéphane Marchesin (Gerrit)

unread,
Oct 27, 2016, 7:57:42 PM10/27/16
to Jeffy Chen, Sean Paul, Dominik Behr, Douglas Anderson, Tomasz Figa, Brian Norris

Stéphane Marchesin uploaded patch set #2 to CHROMIUM: config: disable FBDEV.

View Change

CHROMIUM: config: disable FBDEV

This disables CONFIG_DRM_FBDEV_EMULATION.

BUG=chrome-os-partner:58765,chromium:655820

Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Signed-off-by: Jeffy Chen <jeffy...@rock-chips.com>
---
M chromeos/config/base.config
1 file changed, 1 insertion(+), 1 deletion(-)

To view, visit this change. To unsubscribe, visit settings.

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Gerrit-PatchSet: 2

Stéphane Marchesin (Gerrit)

unread,
Oct 27, 2016, 7:57:54 PM10/27/16
to Jeffy Chen, Dominik Behr, Sean Paul, Douglas Anderson, Tomasz Figa, Brian Norris
Stéphane Marchesin has posted comments on this change. (
https://chromium-review.googlesource.com/403629 )

Change subject: CHROMIUM: config: disable FBDEV
......................................................................


Patch Set 2: Verified+1 Code-Review+2 Commit-Queue+1

yeah let's land this.
--
To view, visit https://chromium-review.googlesource.com/403629
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Owner: Jeffy Chen <jeffy...@rock-chips.com>
Gerrit-Reviewer: Brian Norris <brian...@chromium.org>
Gerrit-Reviewer: Dominik Behr <db...@chromium.org>
Gerrit-Reviewer: Douglas Anderson <dian...@chromium.org>
Gerrit-Reviewer: Sean Paul <sean...@chromium.org>
Gerrit-Reviewer: Stéphane Marchesin <mar...@chromium.org>

Dominik Behr (Gerrit)

unread,
Oct 27, 2016, 8:07:40 PM10/27/16
to Stéphane Marchesin, Jeffy Chen, Sean Paul, Douglas Anderson, Tomasz Figa, Brian Norris
Dominik Behr has posted comments on this change. (
https://chromium-review.googlesource.com/403629 )

Change subject: CHROMIUM: config: disable FBDEV
......................................................................


Patch Set 2: Code-Review+2

yay!
--
To view, visit https://chromium-review.googlesource.com/403629
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Owner: Jeffy Chen <jeffy...@rock-chips.com>
Gerrit-Reviewer: Brian Norris <brian...@chromium.org>

ChromeOS Commit Bot (Gerrit)

unread,
Oct 28, 2016, 4:01:22 AM10/28/16
to Jeffy Chen, Sean Paul, Dominik Behr, Douglas Anderson, Stéphane Marchesin, Tomasz Figa, Brian Norris
Hello Sean Paul, Dominik Behr, Douglas Anderson, Stéphane Marchesin, Tomasz
Figa, Jeffy Chen, Brian Norris,

I'd like you to reexamine a change. Please visit

https://chromium-review.googlesource.com/403629

to look at the new patch set (#3).

Change subject: CHROMIUM: config: disable FBDEV
......................................................................

CHROMIUM: config: disable FBDEV

This disables CONFIG_DRM_FBDEV_EMULATION.

BUG=chrome-os-partner:58765,chromium:655820

Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Signed-off-by: Jeffy Chen <jeffy...@rock-chips.com>
Reviewed-on: https://chromium-review.googlesource.com/403629
Commit-Ready: Stéphane Marchesin <mar...@chromium.org>
Tested-by: Stéphane Marchesin <mar...@chromium.org>
Reviewed-by: Dominik Behr <db...@chromium.org>
Reviewed-by: Stéphane Marchesin <mar...@chromium.org>
---
M chromeos/config/base.config
1 file changed, 1 insertion(+), 1 deletion(-)


--
To view, visit https://chromium-review.googlesource.com/403629
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Owner: Jeffy Chen <jeffy...@rock-chips.com>
Gerrit-Reviewer: Brian Norris <brian...@chromium.org>

ChromeOS Commit Bot (Gerrit)

unread,
Oct 28, 2016, 4:01:24 AM10/28/16
to Jeffy Chen, Dominik Behr, Stéphane Marchesin, Sean Paul, Douglas Anderson, Tomasz Figa, Brian Norris
ChromeOS Commit Bot has submitted this change and it was merged. (
https://chromium-review.googlesource.com/403629 )

Change subject: CHROMIUM: config: disable FBDEV
......................................................................

CHROMIUM: config: disable FBDEV

This disables CONFIG_DRM_FBDEV_EMULATION.

BUG=chrome-os-partner:58765,chromium:655820

Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Signed-off-by: Jeffy Chen <jeffy...@rock-chips.com>
Reviewed-on: https://chromium-review.googlesource.com/403629
Commit-Ready: Stéphane Marchesin <mar...@chromium.org>
Tested-by: Stéphane Marchesin <mar...@chromium.org>
Reviewed-by: Dominik Behr <db...@chromium.org>
Reviewed-by: Stéphane Marchesin <mar...@chromium.org>
---
M chromeos/config/base.config
1 file changed, 1 insertion(+), 1 deletion(-)



diff --git a/chromeos/config/base.config b/chromeos/config/base.config
index f2ae30b..3de3798 100644
--- a/chromeos/config/base.config
+++ b/chromeos/config/base.config
@@ -522,7 +522,7 @@
CONFIG_DRM=y
CONFIG_DRM_BRIDGE=y
CONFIG_DRM_EVDI=m
-CONFIG_DRM_FBDEV_EMULATION=y
+# CONFIG_DRM_FBDEV_EMULATION is not set
# CONFIG_DRM_I2C_ADV7511 is not set
# CONFIG_DRM_I2C_CH7006 is not set
# CONFIG_DRM_I2C_NXP_TDA998X is not set

--
To view, visit https://chromium-review.googlesource.com/403629
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I946f9c4438e2ef1e482f09b2bf6d971696d8201e
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Owner: Jeffy Chen <jeffy...@rock-chips.com>
Gerrit-Reviewer: Brian Norris <brian...@chromium.org>
Reply all
Reply to author
Forward
0 new messages