hack: i2c: i2c-exynos5: use devm_request_and_ioremap functio... [chromiumos/third_party/kernel-next : chromeos-3.8]

1 view
Skip to first unread message

Arun Kumar K (Code Review)

unread,
May 22, 2013, 12:03:26 PM5/22/13
to naveen krishna chatradhi, Olof Johansson
Hello naveen krishna chatradhi,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/56217

to review the following change.

Change subject: hack: i2c: i2c-exynos5: use devm_request_and_ioremap function
......................................................................

hack: i2c: i2c-exynos5: use devm_request_and_ioremap function

use devm_ioremap_resource instead of devm_request_and_ioremap
as the kernel does not support devm_request_and_ioremap yet.

BUG=chrome-os-partner:19007
TEST=should be able to build kernel-next for peach

Change-Id: I4b0c5bd8f6a2054efc03f784f897a8daeb748423
Signed-off-by: Naveen Krishna Chatradhi <ch.n...@samsung.com>
---
M drivers/i2c/busses/i2c-exynos5.c
1 file changed, 1 insertion(+), 1 deletion(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel-next refs/changes/17/56217/1

diff --git a/drivers/i2c/busses/i2c-exynos5.c b/drivers/i2c/busses/i2c-exynos5.c
index 33c481d..e513d15 100644
--- a/drivers/i2c/busses/i2c-exynos5.c
+++ b/drivers/i2c/busses/i2c-exynos5.c
@@ -723,7 +723,7 @@
clk_prepare_enable(i2c->clk);

mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- i2c->regs = devm_ioremap_resource(&pdev->dev, mem);
+ i2c->regs = devm_request_and_ioremap(&pdev->dev, mem);
if (IS_ERR(i2c->regs)) {
dev_err(&pdev->dev, "cannot map HS-I2C IO\n");
ret = PTR_ERR(i2c->regs);

--
To view, visit https://gerrit.chromium.org/gerrit/56217
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4b0c5bd8f6a2054efc03f784f897a8daeb748423
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <aru...@samsung.com>
Gerrit-Reviewer: naveen krishna chatradhi <nav...@chromium.org>

Andrew Bresticker (Code Review)

unread,
May 22, 2013, 1:11:51 PM5/22/13
to Arun Kumar K, naveen krishna chatradhi, ChromeBot, Doug Anderson, Simon Glass
Andrew Bresticker has posted comments on this change.

Change subject: hack: i2c: i2c-exynos5: use devm_request_and_ioremap function
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Perhaps merge this with the previous patch and add a note in the commit message about it?

--
To view, visit https://gerrit.chromium.org/gerrit/56217
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b0c5bd8f6a2054efc03f784f897a8daeb748423
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <aru...@samsung.com>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

naveen krishna chatradhi (Code Review)

unread,
May 23, 2013, 1:12:58 AM5/23/13
to Arun Kumar K, ChromeBot, Doug Anderson, Simon Glass, Andrew Bresticker
naveen krishna chatradhi has posted comments on this change.

Change subject: hack: i2c: i2c-exynos5: use devm_request_and_ioremap function
......................................................................


Patch Set 1:

The previous patch is the one that i've submitted as v9 to linux-i2c mainling list. So, i thought of using this as a separate patch. As this fix will not be needed in future versions of kernel which support devm_ioremap_resource

--
To view, visit https://gerrit.chromium.org/gerrit/56217
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b0c5bd8f6a2054efc03f784f897a8daeb748423
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <aru...@samsung.com>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Doug Anderson (Code Review)

unread,
May 23, 2013, 11:59:22 PM5/23/13
to Arun Kumar K, naveen krishna chatradhi, ChromeBot, Simon Glass, Andrew Bresticker
Doug Anderson has posted comments on this change.

Change subject: hack: i2c: i2c-exynos5: use devm_request_and_ioremap function
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Since I don't think the mailing list one landed (otherwise prev patch should be marked UPSTREAM), perhaps you should take prev and send it up as v10? CC Andrew and he can reply with Tested-by and Reviewed-by...

Abandon this?

--
To view, visit https://gerrit.chromium.org/gerrit/56217
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4b0c5bd8f6a2054efc03f784f897a8daeb748423
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <aru...@samsung.com>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Arun Kumar K (Code Review)

unread,
May 30, 2013, 2:35:14 AM5/30/13
to naveen krishna chatradhi, ChromeBot, Doug Anderson, Simon Glass, Andrew Bresticker
Arun Kumar K has abandoned this change.

Change subject: hack: i2c: i2c-exynos5: use devm_request_and_ioremap function
......................................................................


Patch Set 1: Abandoned

Abandon as per Doug's comment

--
To view, visit https://gerrit.chromium.org/gerrit/56217
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I4b0c5bd8f6a2054efc03f784f897a8daeb748423
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <arunkk....@gmail.com>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>
Reply all
Reply to author
Forward
0 new messages