CHROMIUM: arm: exynos5420: dt: add device tree support [chromiumos/third_party/kernel-next : chromeos-3.8]

2 views
Skip to first unread message

Prathyush Kalashwaram (Code Review)

unread,
Apr 29, 2013, 10:18:52 AM4/29/13
to Alim Akhtar, Olof Johansson
Hello Alim Akhtar,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/49474

to review the following change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support
......................................................................

CHROMIUM: arm: exynos5420: dt: add device tree support

This patch adds initial device tree files for exynos5420 socs and for
SMDK5420 board.

BUG=chrome-os-partner:19007
TEST=Boot kernel on SMDK5420. Boot on snow and test s2r

Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Signed-off-by: Alim Akhtar <alim....@samsung.com>
Signed-off-by: Prathyush K <prath...@samsung.com>
---
M arch/arm/boot/dts/Makefile
A arch/arm/boot/dts/exynos5420-smdk5420.dts
A arch/arm/boot/dts/exynos5420.dtsi
3 files changed, 177 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel-next refs/changes/74/49474/1

diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
index 5ebb44f..fecd9f7 100644
--- a/arch/arm/boot/dts/Makefile
+++ b/arch/arm/boot/dts/Makefile
@@ -45,6 +45,7 @@
exynos4412-smdk4412.dtb \
exynos5250-smdk5250.dtb \
exynos5250-snow.dtb \
+ exynos5420-smdk5420.dtb \
exynos5440-ssdk5440.dtb
dtb-$(CONFIG_ARCH_HIGHBANK) += highbank.dtb \
ecx-2000.dtb
diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
new file mode 100644
index 0000000..f324d14
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -0,0 +1,57 @@
+/*
+ * SAMSUNG SMDK5420 board device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/dts-v1/;
+/include/ "exynos5420.dtsi"
+
+/ {
+ model = "SAMSUNG SMDK5420 board based on EXYNOS5420";
+ compatible = "samsung,smdk5420", "samsung,exynos5420";
+
+ memory {
+ reg = <0x20000000 0x10000000
+ 0x30000000 0x10000000
+ 0x40000000 0x10000000
+ 0x50000000 0x10000000
+ 0x60000000 0x10000000
+ 0x70000000 0x10000000
+ 0x80000000 0x10000000
+ 0x90000000 0x10000000>;
+ };
+
+ chosen {
+ bootargs = "root=/dev/mmcblk1p3 console=ttySAC3,115200 rootwait";
+ };
+
+ watchdog {
+ status = "okay";
+ };
+
+ rtc {
+ status = "okay";
+ };
+
+ serial@12C00000 {
+ status = "okay";
+ };
+
+ serial@12C10000 {
+ status = "okay";
+ };
+
+ serial@12C20000 {
+ status = "okay";
+ };
+
+ serial@12C30000 {
+ status = "okay";
+ };
+};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
new file mode 100644
index 0000000..346c923
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -0,0 +1,119 @@
+/*
+ * SAMSUNG EXYNOS5420 SoC device tree source
+ *
+ * Copyright (c) 2013 Samsung Electronics Co., Ltd.
+ * http://www.samsung.com
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+*/
+
+/include/ "skeleton.dtsi"
+
+/ {
+ compatible = "samsung,exynos5420";
+ interrupt-parent = <&gic>;
+
+ gic:interrupt-controller@10481000 {
+ compatible = "arm,cortex-a9-gic";
+ #interrupt-cells = <3>;
+ #address-cells = <0>;
+ #size-cells = <0>;
+ interrupt-controller;
+ reg = <0x10481000 0x1000>, <0x10482000 0x2000>;
+ };
+
+ combiner:interrupt-controller@10440000 {
+ compatible = "samsung,exynos4210-combiner";
+ #interrupt-cells = <2>;
+ interrupt-controller;
+ samsung,combiner-nr = <32>;
+ reg = <0x10440000 0x1000>;
+ interrupts = <0 0 0>, <0 1 0>, <0 2 0>, <0 3 0>,
+ <0 4 0>, <0 5 0>, <0 6 0>, <0 7 0>,
+ <0 8 0>, <0 9 0>, <0 10 0>, <0 11 0>,
+ <0 12 0>, <0 13 0>, <0 14 0>, <0 15 0>,
+ <0 16 0>, <0 17 0>, <0 18 0>, <0 19 0>,
+ <0 20 0>, <0 21 0>, <0 22 0>, <0 23 0>,
+ <0 24 0>, <0 25 0>, <0 26 0>, <0 27 0>,
+ <0 28 0>, <0 29 0>, <0 30 0>, <0 31 0>;
+ };
+
+ watchdog {
+ compatible = "samsung,s3c2410-wdt";
+ reg = <0x101D0000 0x100>;
+ interrupts = <0 42 0>;
+ status = "disabled";
+ };
+
+ rtc {
+ compatible = "samsung,s3c6410-rtc";
+ reg = <0x101E0000 0x100>;
+ interrupts = <0 43 0>, <0 44 0>;
+ status = "disabled";
+ };
+
+ serial@12C00000 {
+ compatible = "samsung,exynos4210-uart";
+ reg = <0x12C00000 0x100>;
+ interrupts = <0 51 0>;
+ status = "disabled";
+ };
+
+ serial@12C10000 {
+ compatible = "samsung,exynos4210-uart";
+ reg = <0x12C10000 0x100>;
+ interrupts = <0 52 0>;
+ status = "disabled";
+ };
+
+ serial@12C20000 {
+ compatible = "samsung,exynos4210-uart";
+ reg = <0x12C20000 0x100>;
+ interrupts = <0 53 0>;
+ status = "disabled";
+ };
+
+ serial@12C30000 {
+ compatible = "samsung,exynos4210-uart";
+ reg = <0x12C30000 0x100>;
+ interrupts = <0 54 0>;
+ status = "disabled";
+ };
+
+ amba {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "arm,amba-bus";
+ interrupt-parent = <&gic>;
+ ranges;
+
+ pdma0: pdma@121A0000 {
+ compatible = "arm,pl330", "arm,primecell";
+ reg = <0x121A0000 0x1000>;
+ interrupts = <0 34 0>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <32>;
+ };
+
+ pdma1: pdma@121B0000 {
+ compatible = "arm,pl330", "arm,primecell";
+ reg = <0x121B0000 0x1000>;
+ interrupts = <0 35 0>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <32>;
+ };
+
+ adma: adma@03880000 {
+ compatible = "arm,pl330", "arm,primecell";
+ reg = <0x03880000 0x1000>;
+ interrupts = <0 110 0>;
+ #dma-cells = <1>;
+ #dma-channels = <8>;
+ #dma-requests = <32>;
+ };
+ };
+};

--
To view, visit https://gerrit.chromium.org/gerrit/49474
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Prathyush Kalashwaram (Code Review)

unread,
Apr 29, 2013, 10:18:52 AM4/29/13
to Alim Akhtar, Olof Johansson
Hello Alim Akhtar,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/49481

to review the following change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................

CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc

This patch adds alias names, device tree nodes for dw-mmc controller for
exynos5420 soc.

BUG=chrome-os-partner:19007
TEST=Boot kernel on SMDK5420. Boot on snow and test s2r

Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Signed-off-by: Alim Akhtar <alim....@samsung.com>
Signed-off-by: Prathyush K <prath...@samsung.com>
---
M arch/arm/boot/dts/exynos5420-smdk5420.dts
M arch/arm/boot/dts/exynos5420.dtsi
M arch/arm/mach-exynos/mach-exynos5-dt.c
3 files changed, 83 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel-next refs/changes/81/49481/1

diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts
index f324d14..0849774 100644
--- a/arch/arm/boot/dts/exynos5420-smdk5420.dts
+++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts
@@ -54,4 +54,48 @@
serial@12C30000 {
status = "okay";
};
+
+ dwmmc0@12200000 {
+ status = "okay";
+ num-slots = <1>;
+ broken-cd;
+ supports-highspeed;
+ fifo-depth = <0x40>;
+ card-detect-delay = <200>;
+ samsung,dw-mshc-ciu-div = <7>;
+ samsung,dw-mshc-sdr-timing = <0 4>;
+ samsung,dw-mshc-ddr-timing = <0 2>;
+
+ slot@0 {
+ reg = <0>;
+ bus-width = <8>;
+ gpios = <&gpc0 0 2 0 3>, <&gpc0 1 2 0 3>,
+ <&gpc3 0 2 3 3>, <&gpc3 1 2 3 3>,
+ <&gpc3 2 2 3 3>, <&gpc3 3 2 3 3>,
+ <&gpc0 3 2 3 3>, <&gpc0 4 2 3 3>,
+ <&gpc0 5 2 3 3>, <&gpc0 6 2 3 3>;
+ };
+ };
+
+ dwmmc2@12220000 {
+ status = "okay";
+ num-slots = <1>;
+ supports-highspeed;
+ fifo-depth = <0x40>;
+ card-detect-delay = <200>;
+ samsung,dw-mshc-ciu-div = <3>;
+ samsung,dw-mshc-sdr-timing = <2 3>;
+ samsung,dw-mshc-ddr-timing = <1 2>;
+
+ slot@0 {
+ reg = <0>;
+ bus-width = <4>;
+ samsung,cd-pinmux-gpio = <&gpc2 2 2 0 3>;
+ wp-gpios = <&gpc4 0 2 3 3>;
+ gpios = <&gpc2 0 2 0 3>, <&gpc2 1 2 0 3>,
+ <&gpc2 3 2 3 3>, <&gpc2 4 2 3 3>,
+ <&gpc2 5 2 3 3>, <&gpc2 6 2 3 3>;
+ };
+ };
+
};
diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index f9db1c3..1a5b1e2 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -15,6 +15,12 @@
compatible = "samsung,exynos5420";
interrupt-parent = <&gic>;

+ aliases {
+ mshc0 = &dwmmc_0;
+ mshc1 = &dwmmc_1;
+ mshc2 = &dwmmc_2;
+ };
+
gic:interrupt-controller@10481000 {
compatible = "arm,cortex-a9-gic";
#interrupt-cells = <3>;
@@ -304,4 +310,31 @@
#gpio-cells = <4>;
};
};
+
+ dwmmc_0: dwmmc0@12200000 {
+ compatible = "samsung,exynos5420-dw-mshc";
+ reg = <0x12200000 0x2000>;
+ interrupts = <0 75 0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ dwmmc_1: dwmmc1@12210000 {
+ compatible = "samsung,exynos5420-dw-mshc";
+ reg = <0x12210000 0x2000>;
+ interrupts = <0 76 0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
+
+ dwmmc_2: dwmmc2@12220000 {
+ compatible = "samsung,exynos5420-dw-mshc";
+ reg = <0x12220000 0x2000>;
+ interrupts = <0 77 0>;
+ #address-cells = <1>;
+ #size-cells = <0>;
+ status = "disabled";
+ };
};
diff --git a/arch/arm/mach-exynos/mach-exynos5-dt.c b/arch/arm/mach-exynos/mach-exynos5-dt.c
index a110f84..50401e7 100644
--- a/arch/arm/mach-exynos/mach-exynos5-dt.c
+++ b/arch/arm/mach-exynos/mach-exynos5-dt.c
@@ -339,6 +339,12 @@
"exynos4210-uart.2", NULL),
OF_DEV_AUXDATA("samsung,exynos4210-uart", EXYNOS5_PA_UART3,
"exynos4210-uart.3", NULL),
+ OF_DEV_AUXDATA("samsung,exynos5420-dw-mshc", EXYNOS5_PA_DWMCI0,
+ "dw_mmc.0", NULL),
+ OF_DEV_AUXDATA("samsung,exynos5420-dw-mshc", EXYNOS5_PA_DWMCI1,
+ "dw_mmc.1", NULL),
+ OF_DEV_AUXDATA("samsung,exynos5420-dw-mshc", EXYNOS5_PA_DWMCI2,
+ "dw_mmc.2", NULL),
{},
};


--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d

Doug Anderson (Code Review)

unread,
Apr 30, 2013, 12:49:07 PM4/30/13
to Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Simon Glass
Doug Anderson has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(2 inline comments)

This CL will look very different after pinmux and common clock framework changes.

....................................................
File arch/arm/boot/dts/exynos5420.dtsi
Line 338: status = "disabled";
dwmmc_3?


....................................................
File arch/arm/mach-exynos/mach-exynos5-dt.c
Line 343: "dw_mmc.0", NULL),
Likely won't be needed after common clock framework stuff.


--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Doug Anderson (Code Review)

unread,
Apr 30, 2013, 1:24:56 PM4/30/13
to Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Simon Glass
Doug Anderson has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support
......................................................................


Patch Set 1: I would prefer that you didn't submit this

Expect respin atop common clock/pinmux. Didn't review.

--
To view, visit https://gerrit.chromium.org/gerrit/49474
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Simon Glass (Code Review)

unread,
May 20, 2013, 8:31:39 PM5/20/13
to Arun Kumar K, Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Doug Anderson
Simon Glass has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/49474
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>
Gerrit-Reviewer: Arun Kumar K <aru...@samsung.com>

Simon Glass (Code Review)

unread,
May 21, 2013, 5:30:21 PM5/21/13
to Arun Kumar K, Prathyush Kalashwaram, ChromeBot, Doug Anderson, Alim Akhtar
Simon Glass has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 2: I would prefer that you didn't submit this

(1 inline comment)

Just a question

....................................................
File arch/arm/boot/dts/exynos5420-smdk5420.dts
Line 94: pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
Is SD_1_INTn needed here?


--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Alim Akhtar (Code Review)

unread,
May 21, 2013, 9:25:45 PM5/21/13
to Arun Kumar K, Prathyush Kalashwaram, ChromeBot, Doug Anderson, Simon Glass
Alim Akhtar has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File arch/arm/boot/dts/exynos5420-smdk5420.dts
Line 94: pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
yes..as SD_1_INT is missing from the actual pinctrl.dtsi file...it is not added...i have reviewed the pinctrl.dtsi file...will add and respin today


--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Alim Akhtar (Code Review)

unread,
May 22, 2013, 8:43:44 AM5/22/13
to Arun Kumar K, Prathyush Kalashwaram, ChromeBot, Doug Anderson, Simon Glass
Alim Akhtar has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File arch/arm/boot/dts/exynos5420-smdk5420.dts
Line 94: pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_cd &sd2_bus4>;
smdk is not using dw_mmc channel 1, will add this for pit


--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Simon Glass (Code Review)

unread,
May 22, 2013, 4:20:11 PM5/22/13
to Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Doug Anderson, Arun Kumar K
Simon Glass has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support
......................................................................


Patch Set 3: (2 inline comments)

....................................................
File arch/arm/boot/dts/exynos5420-smdk5420.dts
Line 19: memory {
Should be removed


Line 36: compatible = "samsung,exynos5420-oscclk";
Should be samsung,clock-xxti


--
To view, visit https://gerrit.chromium.org/gerrit/49474
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Simon Glass (Code Review)

unread,
May 22, 2013, 4:27:37 PM5/22/13
to Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Doug Anderson, Arun Kumar K
Simon Glass has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support
......................................................................


Patch Set 4: Looks good to me, approved; Ready; Verified

Fix problems found by Doug, pushing

--
To view, visit https://gerrit.chromium.org/gerrit/49474
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Gerrit-PatchSet: 4
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Simon Glass (Code Review)

unread,
May 22, 2013, 6:56:59 PM5/22/13
to Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Doug Anderson, Arun Kumar K
Simon Glass has submitted this change and it was merged.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support
......................................................................


CHROMIUM: arm: exynos5420: dt: add device tree support

This patch adds initial device tree files for exynos5420 socs and for
SMDK5420 board.

BUG=chrome-os-partner:19007
TEST=Boot kernel on SMDK5420. Boot on snow and test s2r

Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Signed-off-by: Alim Akhtar <alim....@samsung.com>
Signed-off-by: Prathyush K <prath...@samsung.com>
Signed-off-by: Arun Kumar K <aru...@samsung.com>
Signed-off-by: Simon Glass <s...@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/49474
---
M arch/arm/boot/dts/Makefile
A arch/arm/boot/dts/exynos5420-smdk5420.dts
A arch/arm/boot/dts/exynos5420.dtsi
3 files changed, 217 insertions(+), 0 deletions(-)

Approvals:
Simon Glass: Looks good to me, approved; Ready; Verified


--
To view, visit https://gerrit.chromium.org/gerrit/49474
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie81c23ac8461947755d8948957d45054c237fc17
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Simon Glass (Code Review)

unread,
May 23, 2013, 12:06:08 PM5/23/13
to Arun Kumar K, Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Doug Anderson
Simon Glass has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 5: Looks good to me, approved; Ready; Verified

--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Simon Glass (Code Review)

unread,
May 23, 2013, 12:13:13 PM5/23/13
to Arun Kumar K, Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Doug Anderson
Simon Glass has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 5: Not Ready

I think we should wait until clock numbering is confirmed

--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Doug Anderson (Code Review)

unread,
May 23, 2013, 5:15:42 PM5/23/13
to Arun Kumar K, Prathyush Kalashwaram, Alim Akhtar, ChromeBot, Simon Glass
Doug Anderson has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 5: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 5
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>

Andrew Bresticker (Code Review)

unread,
May 23, 2013, 11:38:27 PM5/23/13
to Arun Kumar K, Prathyush Kalashwaram, ChromeBot, Doug Anderson, Simon Glass, Alim Akhtar
Andrew Bresticker has posted comments on this change.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


Patch Set 6: Looks good to me, approved; Ready; Verified

Rebased; i2c and pmic depend on this and stuff that has already been merged.

--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 6
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>
Gerrit-Reviewer: Andrew Bresticker <abre...@chromium.org>

Doug Anderson (Code Review)

unread,
May 24, 2013, 12:40:46 AM5/24/13
to Arun Kumar K, Prathyush Kalashwaram, ChromeBot, Simon Glass, Alim Akhtar, Andrew Bresticker
Doug Anderson has submitted this change and it was merged.

Change subject: CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc
......................................................................


CHROMIUM: arm: exynos5420: dt: add device tree support for dwmmc

This patch adds alias names, device tree nodes for dw-mmc controller for
exynos5420 soc.

BUG=chrome-os-partner:19007
TEST=Boot kernel on SMDK5420. Boot on snow and test s2r

Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Signed-off-by: Alim Akhtar <alim....@samsung.com>
Signed-off-by: Prathyush K <prath...@samsung.com>
Signed-off-by: Arun Kumar K <aru...@samsung.com>
Reviewed-on: https://gerrit.chromium.org/gerrit/49481
Commit-Queue: Andrew Bresticker <abre...@chromium.org>
Reviewed-by: Andrew Bresticker <abre...@chromium.org>
Tested-by: Andrew Bresticker <abre...@chromium.org>
---
M arch/arm/boot/dts/exynos5420-smdk5420.dts
M arch/arm/boot/dts/exynos5420.dtsi
2 files changed, 74 insertions(+), 0 deletions(-)

Approvals:
Andrew Bresticker: Looks good to me, approved; Ready; Verified
Doug Anderson:


--
To view, visit https://gerrit.chromium.org/gerrit/49481
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I00fdebe10497d864be8fd16f80225dd728cfbb6d
Gerrit-PatchSet: 7
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Prathyush Kalashwaram <prat...@chromium.org>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>
Reply all
Reply to author
Forward
0 new messages