mtd-utils: pull in latest stable version [chromiumos/overlays/portage-stable : master]

0 views
Skip to first unread message

Mike Frysinger (Code Review)

unread,
May 16, 2012, 12:07:56 PM5/16/12
to Mike Frysinger
Mike Frysinger has uploaded a new change for review.

Change subject: mtd-utils: pull in latest stable version
......................................................................

mtd-utils: pull in latest stable version

Upgraded sys-fs/mtd-utils to version 1.4.8 on amd64, arm, x86.

We want it for some simple testing. Nothing pulls it in yet.

BUG=None
TEST=`emerge-amd64-generic mtd-utils` works
TEST=`emerge-arm-generic mtd-utils` works
TEST=`emerge-x86-generic mtd-utils` works

Change-Id: I5b385e3fe2d491936be12db0da3ae28a02a5d397
---
A metadata/md5-cache/sys-fs/mtd-utils-1.4.8
A sys-fs/mtd-utils/Manifest
A sys-fs/mtd-utils/files/mtd-utils-1.4.8-install.patch
A sys-fs/mtd-utils/mtd-utils-1.4.8.ebuild
4 files changed, 113 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/portage-stable refs/changes/22/22822/1
--
To view, visit https://gerrit.chromium.org/gerrit/22822
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5b385e3fe2d491936be12db0da3ae28a02a5d397
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>

Bryan Freed (Code Review)

unread,
May 16, 2012, 4:13:27 PM5/16/12
to Mike Frysinger
Bryan Freed has posted comments on this change.

Change subject: mtd-utils: pull in latest stable version
......................................................................


Patch Set 1: Verified; Looks good to me, approved

I confirmed flash_erase provides the functionality of mtderase of https://gerrit.chromium.org/gerrit/#change,22765.
I notice it does not utilize the whole ChipErase option so it takes 14 seconds instead of 1 second. But it does provide the option of partial erases.

All other mtd-utils features either do not currently work or are unnecessary. But there is the potential for increasing our use of it beyond merely flash_erase as we get the SPI driver working better.
Flash locking and unlocking in particular would be nice if they worked.

So while our current intention is to get flashrom fully supported, mtd-utils will at least get us able to erase the flash today.
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b385e3fe2d491936be12db0da3ae28a02a5d397
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Bryan Freed <bfr...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 4:46:32 PM5/16/12
to Mike Frysinger, Bryan Freed
Mike Frysinger has posted comments on this change.

Change subject: mtd-utils: pull in latest stable version
......................................................................


Patch Set 1: Ready

hmm, i can probably bring that up with upstream. the current code walks sector by sector so that it can handle OOB, but if we don't care about that, then there's no reason to do that.
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b385e3fe2d491936be12db0da3ae28a02a5d397
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Bryan Freed <bfr...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 5:21:05 PM5/16/12
to Mike Frysinger, Bryan Freed
Mike Frysinger has posted comments on this change.

Change subject: mtd-utils: pull in latest stable version
......................................................................


Patch Set 1: Ready

nothing pulls this in, so couldn't be the source of the failure
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b385e3fe2d491936be12db0da3ae28a02a5d397
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 6:07:26 PM5/16/12
to Mike Frysinger, Bryan Freed
Mike Frysinger has posted comments on this change.

Change subject: mtd-utils: pull in latest stable version
......................................................................


Patch Set 1: Ready

this didn't cause the shill unittest failure
Gerrit-MessageType: comment
Gerrit-Change-Id: I5b385e3fe2d491936be12db0da3ae28a02a5d397
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/portage-stable
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Reply all
Reply to author
Forward
0 new messages