shill: WiFi: Reload hidden services after restart [chromiumos/platform/shill : release-R23-2913.B]

[Paul Stewart (Code Review)]

Hello Christopher Wiley, mukesh agrawal,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/36898

to review the following change.

Change subject: shill: WiFi: Reload hidden services after restart
......................................................................

shill: WiFi: Reload hidden services after restart

Hidden services in WiFi are loaded in two situations:

(1) When the WiFi Device is registered, WiFi::Load() is called
each profile.

(2) When a profile is pushed, WiFi::Load() is called with the
new profile.

When WiFi::Stop() is called, all services are removed, so some
mechanism needs to be used to reload these hidden services when
WiFi::Start() is called.

BUG=chromium-os:35703
TEST=Unit tests + manual: Disable / Re-Enable WiFi and make sure
remembered hidden networks are still visible.

Change-Id: Ie6b9351db940860cb20c39e0575c3d5dd8c921d0
Reviewed-on: https://gerrit.chromium.org/gerrit/36736
Reviewed-by: Christopher Wiley <wi...@chromium.org>
Reviewed-by: mukesh agrawal <qui...@chromium.org>
Commit-Ready: Paul Stewart <ps...@chromium.org>
Tested-by: Paul Stewart <ps...@chromium.org>
(cherry picked from commit 87a4ae88915e3dc22dbb1327002e1daf769ef23e)
---
M manager.cc
M manager.h
M mock_manager.h
M wifi.cc
M wifi_unittest.cc
5 files changed, 20 insertions(+), 7 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/shill refs/changes/98/36898/1
--
To view, visit https://gerrit.chromium.org/gerrit/36898
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie6b9351db940860cb20c39e0575c3d5dd8c921d0
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Christopher Wiley <wi...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

[Paul Stewart (Code Review)]

Paul Stewart has posted comments on this change.

Change subject: shill: WiFi: Reload hidden services after restart
......................................................................

Patch Set 1: Verified; Looks good to me, approved

Merge approved -- trybot success.

--
To view, visit https://gerrit.chromium.org/gerrit/36898
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: Ie6b9351db940860cb20c39e0575c3d5dd8c921d0
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Christopher Wiley <wi...@chromium.org>

Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

[Paul Stewart (Code Review)]

Paul Stewart has submitted this change and it was merged.

Approvals:
Paul Stewart: Verified; Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/36898
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged

Gerrit-Change-Id: Ie6b9351db940860cb20c39e0575c3d5dd8c921d0
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Christopher Wiley <wi...@chromium.org>