Fix bug where CQ doesn't test patches. [chromiumos/chromite : master]

1 view
Skip to first unread message

David James (Code Review)

unread,
May 23, 2013, 11:12:48 PM5/23/13
to ChromeBot, Mike Frysinger
David James has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 1: Ready; Verified

--
To view, visit https://gerrit.chromium.org/gerrit/56560
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4d071b84247645b38f05d02c50525098d250fec
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: David James <david...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

David James (Code Review)

unread,
May 23, 2013, 11:21:09 PM5/23/13
to ChromeBot, Mike Frysinger
David James has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 1: Looks good to me, approved

TBR to save the CQ

Mike Frysinger (Code Review)

unread,
May 23, 2013, 11:23:38 PM5/23/13
to David James, ChromeBot, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 1: Looks good to me, approved

David James (Code Review)

unread,
May 23, 2013, 11:26:07 PM5/23/13
to ChromeBot, Mike Frysinger
David James has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File buildbot/validation_pool.py
Line 297: if parent_lookup and not query.isdigit():
TODO, find out why this is needed as this doesn't make any sense :)

David James (Code Review)

unread,
May 24, 2013, 12:25:24 AM5/24/13
to ChromeBot, Mike Frysinger
David James has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 1: Not Ready

David James (Code Review)

unread,
May 24, 2013, 12:16:51 PM5/24/13
to ChromeBot, Mike Frysinger
David James has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 2: Looks good to me, approved; Ready

Rebase / Inheriting LGTM

--
To view, visit https://gerrit.chromium.org/gerrit/56560
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If4d071b84247645b38f05d02c50525098d250fec
Gerrit-PatchSet: 2

David James (Code Review)

unread,
May 24, 2013, 12:16:59 PM5/24/13
to ChromeBot, Mike Frysinger
David James has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 2: Verified

David James (Code Review)

unread,
May 24, 2013, 12:34:49 PM5/24/13
to ChromeBot, Mike Frysinger
David James has posted comments on this change.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Patch Set 2:

Chump to fix CQ

David James (Code Review)

unread,
May 24, 2013, 12:34:50 PM5/24/13
to ChromeBot, Mike Frysinger
David James has submitted this change and it was merged.

Change subject: Fix bug where CQ doesn't test patches.
......................................................................


Fix bug where CQ doesn't test patches.

The CQ currently fails to apply many patches in slave paladin builders
with the following error:
"Failed creating transaction for ... Query ... AND 51178 had no results."

This patch fixes the bug, ensuring that patches are tested again by the
CQ.

BUG=chromium:243604
TEST=Unit tests.
TEST=Launch slave paladins and confirm they now include all patches.

Change-Id: If4d071b84247645b38f05d02c50525098d250fec
Reviewed-on: https://gerrit.chromium.org/gerrit/56560
Commit-Queue: David James <david...@chromium.org>
Reviewed-by: David James <david...@chromium.org>
Tested-by: David James <david...@chromium.org>
---
M buildbot/validation_pool.py
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
David James: Looks good to me, approved; Ready; Verified


--
To view, visit https://gerrit.chromium.org/gerrit/56560
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If4d071b84247645b38f05d02c50525098d250fec
Gerrit-PatchSet: 3
Reply all
Reply to author
Forward
0 new messages