Cherry-pick two previous CLs to fontconfig and merge to the ... [chromiumos/overlays/chromiumos-overlay : 0.12.433.B]

1 view
Skip to first unread message

Jungshik Shin (jungshik at google) (Code Review)

unread,
May 28, 2011, 4:04:15 AM5/28/11
to
Jungshik Shin (jungshik at google) has uploaded a new change for review.

Change subject: Cherry-pick two previous CLs to fontconfig and merge to the R12 branch.
......................................................................

Cherry-pick two previous CLs to fontconfig and merge to the R12 branch.

A. Update and clean up fontconfig.
(commit: 5f52014916757f1b50983c840feaf51c8a18034a)

1. Add Droid Arabic {Kufi,Nashk},Droid {Sans,Serif} Thai, SIL Absinnica fonts
to the alias list for serif, sans-serif and monospace in local.conf

2. Do not install 60-latin.conf, 65-nonlatin.conf, 65-fonts-persian.conf. They have a long list of fonts that we don't have on CrOS or we already list in local.conf in the order we want them to be in.

3. Add Lohit Oriya and Lohit Malayalam to the list of fonts for
serif, sans-serif and monospace in local.conf.

4. Put 'Song ASC' for serif instead of Droid Sans Fallback. 'Song ASC' is a serif font.

BUG=1175
Review URL: http://codereview.chromium.org/6901136

B. Adjust fontconfig for Chinese and Korean fonts.
(commit a7c3e74e7b106458fcc4b0d78b910e040722dda6)

This is done for two reasons:

a. To get Chinese text look better when the UI langauge is not Japanese
nor Korean. That is, it'll make Chinese text look better in Chinese
locales as well.
b. To get Korean Hangul look better when the UI language is not Korean.

This CL does the following:

1. Do not use embedded bitmap glyphs in PMingLiU/MingLiU/Song ASC/N Song
ASC.
2. Turn on light autohints for Song ASC/N Song ASC and BCI hints for
(P)MingLiu. PMingLiU and MingLiU have component glyphs that are moved
and scaled with byte code instructions and autohinting does not
work well.
3. Turn off sub-pixel anti-aliasing for the above fonts and Droid Sans
Fallback.
4. Put Song ASC/N Song ASC, PMingLiU/MingLiU and NanumGothic before Droid Sans
Fallback. (see http:/crosbug.com/14691). Note that PMingLiU and Song ASC
are serif fonts so they're not supposed to be in sans-serif section, but
until bug 14691 is resolved, we have to put them before Droid Sans
Fallback.

BUG=chromium-os:8757
TEST=Go to http://news.google.hk and characters look 'prettier' than
before overall.

Reviewed-on: http://gerrit.chromium.org/gerrit/709
Reviewed-by: Brian Stell <bst...@chromium.org>
Tested-by: Jungshik Shin (jungshik at google) <js...@chromium.org>
(cherry picked from commit a7c3e74e7b106458fcc4b0d78b910e040722dda6)

Change-Id: I8745c140efd52d67d64ff9df91e8ed806e0daced
---
M media-libs/fontconfig/files/fontconfig-2.7.1-conf-d.patch
M media-libs/fontconfig/files/local.conf
R media-libs/fontconfig/fontconfig-2.7.1-r20.ebuild
3 files changed, 226 insertions(+), 9 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/81/1781/1
--
To view, visit http://gerrit.chromium.org/gerrit/1781
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8745c140efd52d67d64ff9df91e8ed806e0daced
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: 0.12.433.B
Gerrit-Owner: Jungshik Shin (jungshik at google) <js...@chromium.org>

Jungshik Shin (jungshik at google) (Code Review)

unread,
May 29, 2011, 1:15:05 AM5/29/11
to Orit Mazor, Brian Stell
Jungshik Shin (jungshik at google) has posted comments on this change.

Change subject: Cherry-pick two previous CLs to fontconfig and merge to the R12 branch.
......................................................................


Patch Set 1:

Hi Orit,

Sorry for the last minute merge request, but it's very critical to merge this to R12 branch. Otherwise, the rendering of Chinese (and Korean and Japanese to a less degree) looks so bad that it's very embarrassing. This change will make it at least decent although not great.

It'd be great if you could approve this merge to R12 branch.

BTW, more extensive changes are coming in the trunk.

Thank you.

P.S. I've just built R12 with this CL and tested on CR-48. Everything worked as expected. Chinese rendering is much more decent than the current R12 build in various UI locales.

--
To view, visit http://gerrit.chromium.org/gerrit/1781
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment


Gerrit-Change-Id: I8745c140efd52d67d64ff9df91e8ed806e0daced
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: 0.12.433.B
Gerrit-Owner: Jungshik Shin (jungshik at google) <js...@chromium.org>

Gerrit-Reviewer: Brian Stell <bst...@chromium.org>
Gerrit-Reviewer: Jungshik Shin (jungshik at google) <js...@chromium.org>
Gerrit-Reviewer: Orit Mazor <or...@chromium.org>

Zelidrag Hornung (Code Review)

unread,
May 30, 2011, 9:43:56 PM5/30/11
to Jungshik Shin (jungshik at google), Orit Mazor, Brian Stell
Zelidrag Hornung has posted comments on this change.

Change subject: Cherry-pick two previous CLs to fontconfig and merge to the R12 branch.
......................................................................


Patch Set 1: Looks good to me, approved

approved for merge

--
To view, visit http://gerrit.chromium.org/gerrit/1781
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment


Gerrit-Change-Id: I8745c140efd52d67d64ff9df91e8ed806e0daced
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: 0.12.433.B
Gerrit-Owner: Jungshik Shin (jungshik at google) <js...@chromium.org>

Gerrit-Reviewer: Brian Stell <bst...@chromium.org>
Gerrit-Reviewer: Jungshik Shin (jungshik at google) <js...@chromium.org>
Gerrit-Reviewer: Orit Mazor <or...@chromium.org>
Gerrit-Reviewer: Zelidrag Hornung <zeli...@chromium.org>

Jungshik Shin (jungshik at google) (Code Review)

unread,
May 31, 2011, 5:16:58 AM5/31/11
to Orit Mazor, Zelidrag Hornung, Brian Stell
Jungshik Shin (jungshik at google) has posted comments on this change.

Change subject: Cherry-pick two previous CLs to fontconfig and merge to the R12 branch.
......................................................................


Patch Set 1: Verified

Thank you for the approval !! I'm landing it because I've already built on both x86-generic and mario (CR-48)

--
To view, visit http://gerrit.chromium.org/gerrit/1781
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment


Gerrit-Change-Id: I8745c140efd52d67d64ff9df91e8ed806e0daced
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: 0.12.433.B
Gerrit-Owner: Jungshik Shin (jungshik at google) <js...@chromium.org>

Jungshik Shin (jungshik at google) (Code Review)

unread,
May 31, 2011, 5:17:05 AM5/31/11
to Orit Mazor, Zelidrag Hornung, Brian Stell
Jungshik Shin (jungshik at google) has submitted this change and it was merged.

Approvals:
Zelidrag Hornung: Looks good to me, approved
Jungshik Shin (jungshik at google): Verified


--
To view, visit http://gerrit.chromium.org/gerrit/1781
To unsubscribe, visit http://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged


Gerrit-Change-Id: I8745c140efd52d67d64ff9df91e8ed806e0daced
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: 0.12.433.B
Gerrit-Owner: Jungshik Shin (jungshik at google) <js...@chromium.org>

Reply all
Reply to author
Forward
0 new messages