sync_package_status: fix bug in determining index of Tracker... [chromiumos/chromite : master]

0 views
Skip to first unread message

Matt Tennant (Code Review)

unread,
May 14, 2012, 12:58:36 PM5/14/12
to Chris Sosa, Ryan Cui, Brian Harring
Matt Tennant has uploaded a new change for review.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................

sync_package_status: fix bug in determining index of Tracker column.

All runs of sync_package_status were failing to write to the spreadsheet,
but really the problem was that it did not have a valid index for the
Tracker column in the spreadsheet. Since this script only ever writes
to that column the issue seemed like a general write problem, but it
was not.

The lookup of the Tracker column simply needed to change the name
from "Tracker" to "tracker" before looking it up, as it does in
other calls to the spreadsheet API.

BUG=chromium-os:30779
TEST=`sync_package_status --owner=mtennant` runs through now, creating
issues for outdated packages and inserting links into spreadsheet.

Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
---
M scripts/sync_package_status.py
1 file changed, 3 insertions(+), 2 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/chromite refs/changes/84/22584/1
--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 14, 2012, 1:06:37 PM5/14/12
to
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 2: Verified

This was the problem all along. Which is weird, because that means I left it in a broken state before, since I did not touch in while I was on leave. Oh well.

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>
Gerrit-Reviewer: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 15, 2012, 8:08:02 PM5/15/12
to Mike Frysinger
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 2:

I'm an idiot. I thought I added vapier to this review before.

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>
Gerrit-Reviewer: Matt Tennant <mten...@chromium.org>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 12:35:30 PM5/16/12
to Matt Tennant, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 2: Looks good to me, approved

(1 inline comment)

....................................................
File scripts/sync_package_status_unittest.py
Line 220: mocked_scomm.GetColumnIndex('tracker').AndReturn(1) # Any index ok.
should we add a unittest for the case where the Get returns None ?

might it be better to use COL_TRACKER from the imported module rather than 'tracker' ?

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 16, 2012, 12:50:13 PM5/16/12
to Mike Frysinger
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 2: (1 inline comment)

....................................................
File scripts/sync_package_status_unittest.py
Line 220: mocked_scomm.GetColumnIndex('tracker').AndReturn(1) # Any index ok.
Both good points. Patch coming.

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 16, 2012, 12:53:45 PM5/16/12
to Mike Frysinger
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 3: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Mike Frysinger (Code Review)

unread,
May 16, 2012, 1:43:33 PM5/16/12
to Matt Tennant, Mike Frysinger
Mike Frysinger has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 16, 2012, 3:37:54 PM5/16/12
to Mike Frysinger
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 16, 2012, 4:31:51 PM5/16/12
to Mike Frysinger
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 16, 2012, 9:32:39 PM5/16/12
to Mike Frysinger
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>

Matt Tennant (Code Review)

unread,
May 17, 2012, 12:15:27 PM5/17/12
to Mike Frysinger
Matt Tennant has posted comments on this change.

Change subject: sync_package_status: fix bug in determining index of Tracker column.
......................................................................


Patch Set 3: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22584
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I7b1c75b3563d907a35c4b3c21509580b7d999c36
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/chromite
Gerrit-Branch: master
Gerrit-Owner: Matt Tennant <mten...@chromium.org>
Reply all
Reply to author
Forward
0 new messages