hterm: Move hterm.NaSSH out to NaSSH. [chromiumos/platform/assets : master]

3 views
Skip to first unread message

Robert Ginda (Code Review)

unread,
May 16, 2012, 2:33:17 PM5/16/12
to
Robert Ginda has uploaded a new change for review.

Change subject: hterm: Move hterm.NaSSH out to NaSSH.
......................................................................

hterm: Move hterm.NaSSH out to NaSSH.

* Move hterm.NaSSH out to NaSSH. This is in preparation for upcoming changes
to further isolate the terminal from commands that run within it.

BUG=None
TEST=Connect to a host directly, and via a relay.
TEST=test_harness.html, 59/59 tests passed.

Change-Id: If0a1936ca32b39db2ff2c3718913a904f51780e3
---
M chromeapps/hterm/doc/changelog-dev.txt
M chromeapps/hterm/js/google_relay.js
M chromeapps/hterm/js/nassh.js
M chromeapps/hterm/js/nassh_streams.js
4 files changed, 92 insertions(+), 91 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/assets refs/changes/37/22837/1
--
To view, visit https://gerrit.chromium.org/gerrit/22837
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If0a1936ca32b39db2ff2c3718913a904f51780e3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/assets
Gerrit-Branch: master
Gerrit-Owner: Robert Ginda <rgi...@chromium.org>

Marius Schilder (Code Review)

unread,
May 16, 2012, 2:38:03 PM5/16/12
to Robert Ginda
Marius Schilder has posted comments on this change.

Change subject: hterm: Move hterm.NaSSH out to NaSSH.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/22837
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0a1936ca32b39db2ff2c3718913a904f51780e3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/assets
Gerrit-Branch: master
Gerrit-Owner: Robert Ginda <rgi...@chromium.org>
Gerrit-Reviewer: Marius Schilder <msch...@google.com>

Robert Ginda (Code Review)

unread,
May 16, 2012, 2:38:20 PM5/16/12
to Marius Schilder
Robert Ginda has posted comments on this change.

Change subject: hterm: Move hterm.NaSSH out to NaSSH.
......................................................................


Patch Set 1: Verified; Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22837
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0a1936ca32b39db2ff2c3718913a904f51780e3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/assets
Gerrit-Branch: master
Gerrit-Owner: Robert Ginda <rgi...@chromium.org>
Gerrit-Reviewer: Marius Schilder <msch...@google.com>
Gerrit-Reviewer: Robert Ginda <rgi...@chromium.org>

Robert Ginda (Code Review)

unread,
May 16, 2012, 4:35:57 PM5/16/12
to Marius Schilder
Robert Ginda has posted comments on this change.

Change subject: hterm: Move hterm.NaSSH out to NaSSH.
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22837
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0a1936ca32b39db2ff2c3718913a904f51780e3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/assets
Gerrit-Branch: master
Gerrit-Owner: Robert Ginda <rgi...@chromium.org>

Robert Ginda (Code Review)

unread,
May 16, 2012, 6:15:09 PM5/16/12
to Marius Schilder
Robert Ginda has posted comments on this change.

Change subject: hterm: Move hterm.NaSSH out to NaSSH.
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22837
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If0a1936ca32b39db2ff2c3718913a904f51780e3
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/assets
Gerrit-Branch: master
Gerrit-Owner: Robert Ginda <rgi...@chromium.org>
Reply all
Reply to author
Forward
0 new messages