build_image: filter out unused glibc files [chromiumos/platform/crosutils : master]

1 view
Skip to first unread message

Mike Frysinger (Code Review)

unread,
Nov 5, 2012, 5:18:43 PM11/5/12
to David James, Ryan Cui, Brian Harring, Chris Sosa, Mike Frysinger
Hello David James,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/37378

to review the following change.

Change subject: build_image: filter out unused glibc files
......................................................................

build_image: filter out unused glibc files

This removes files only used at link time, or when manually debugging,
or by glibc's charset routines (gconv) which are not used by Chromium.

BUG=chromium-os:22939
BUG=chromium-os:23105
TEST=build_image for daisy works
TEST=`cbuildbot {x86,x86_64,arm}-generic-full` worked
TEST=`cbuildbot chromiumos-sdk` worked

Change-Id: I68d848c2e307c98d53a8faa73924f57571f7887b
---
M build_library/base_image_util.sh
1 file changed, 13 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/crosutils refs/changes/78/37378/1
--
To view, visit https://gerrit.chromium.org/gerrit/37378
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I68d848c2e307c98d53a8faa73924f57571f7887b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>

David James (Code Review)

unread,
Nov 5, 2012, 7:47:02 PM11/5/12
to Mike Frysinger, Gerrit
David James has posted comments on this change.

Change subject: build_image: filter out unused glibc files
......................................................................


Patch Set 1: Looks good to me, approved

(1 inline comment)

....................................................
Commit Message
Line 14: TEST=build_image for daisy works
Might be good to test on a real device too :)

--
To view, visit https://gerrit.chromium.org/gerrit/37378
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68d848c2e307c98d53a8faa73924f57571f7887b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>

Mike Frysinger (Code Review)

unread,
Nov 9, 2012, 8:09:46 PM11/9/12
to Mike Frysinger, Gerrit, David James, asharif, Yunlian Jiang
Mike Frysinger has posted comments on this change.

Change subject: build_image: filter out unused glibc files
......................................................................


Patch Set 1: (1 inline comment)

....................................................
Commit Message
Line 14: TEST=build_image for daisy works
all the vmtests passed for all paladins, but i'll try a real device next week

--
To view, visit https://gerrit.chromium.org/gerrit/37378
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68d848c2e307c98d53a8faa73924f57571f7887b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: Yunlian Jiang <yun...@chromium.org>
Gerrit-Reviewer: asharif <ash...@google.com>

Mike Frysinger (Code Review)

unread,
Nov 30, 2012, 4:22:19 PM11/30/12
to Mike Frysinger, Gerrit, David James, asharif, Yunlian Jiang
Mike Frysinger has posted comments on this change.

Change subject: build_image: filter out unused glibc files
......................................................................


Patch Set 2: Verified

(2 inline comments)

PTAL

....................................................
File build_library/base_image_util.sh
Line 194: 'lib*/libBrokenLocale*.so*'
added this new filter pattern

....................................................
File build_library/dev_image_util.sh
Line 65
happened to notice this todo, so i delete that and updated the cp to always kick in for dev images (and to copy from the target rather than the host ldd)

--
To view, visit https://gerrit.chromium.org/gerrit/37378
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68d848c2e307c98d53a8faa73924f57571f7887b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>

David James (Code Review)

unread,
Nov 30, 2012, 4:46:04 PM11/30/12
to Mike Frysinger, Gerrit, asharif, Yunlian Jiang
David James has posted comments on this change.

Change subject: build_image: filter out unused glibc files
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37378
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68d848c2e307c98d53a8faa73924f57571f7887b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>

Mike Frysinger (Code Review)

unread,
Nov 30, 2012, 6:05:21 PM11/30/12
to Mike Frysinger, Gerrit, David James, asharif, Yunlian Jiang
Mike Frysinger has posted comments on this change.

Change subject: build_image: filter out unused glibc files
......................................................................


Patch Set 2: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/37378
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I68d848c2e307c98d53a8faa73924f57571f7887b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Reply all
Reply to author
Forward
0 new messages