wpa_supplicant: Don't remove a BSS that is in use [chromiumos/third_party/hostap : master]

2 views
Skip to first unread message

Paul Stewart (Code Review)

unread,
May 16, 2012, 10:00:01 AM5/16/12
to
Paul Stewart has uploaded a new change for review.

Change subject: wpa_supplicant: Don't remove a BSS that is in use
......................................................................

wpa_supplicant: Don't remove a BSS that is in use

When looking for a BSS to eject due to too many entries, never not pick one
that is in use. Otherwise, we run the risk of having pointers to freed
data in fast-reconnect.

BUG=chromium-os:30050
TEST=Run in-system with DEFAULT_BSS_MAX_COUNT set to 2 and 1. Ensure
connected network remains in scan list.

Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
---
M wpa_supplicant/bss.c
1 file changed, 45 insertions(+), 27 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/hostap refs/changes/19/22819/1
--
To view, visit https://gerrit.chromium.org/gerrit/22819
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/hostap
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>

mukesh agrawal (Code Review)

unread,
May 16, 2012, 4:11:39 PM5/16/12
to Paul Stewart
mukesh agrawal has posted comments on this change.

Change subject: wpa_supplicant: Don't remove a BSS that is in use
......................................................................


Patch Set 1: (3 inline comments)

just nits.

....................................................
Commit Message
Line 7: wpa_supplicant: Don't remove a BSS that is in use
do we need to prefix with CHROMIUM-OS ?

....................................................
File wpa_supplicant/bss.c
Line 172: if (wpa_bss_remove_oldest_not_in_use(wpa_s) == 0)
could simplify to just "return wpa_bss_remove..."

Line 206: wpa_printf(MSG_ERROR, "We need to increase the MAX BSS count "
s/We need to increase/Increasing/. (Current message doesn't make it clear that supplicant is re-configuring on its own.)

--
To view, visit https://gerrit.chromium.org/gerrit/22819
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/hostap
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 4:20:41 PM5/16/12
to mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: CHROMIUMOS: wpa_supplicant: Don't remove a BSS that is in use
......................................................................


Patch Set 3:

Thanks! PTAL. Eliminated a function.

--
To view, visit https://gerrit.chromium.org/gerrit/22819
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/hostap
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>

mukesh agrawal (Code Review)

unread,
May 16, 2012, 4:25:25 PM5/16/12
to Paul Stewart
mukesh agrawal has posted comments on this change.

Change subject: CHROMIUMOS: wpa_supplicant: Don't remove a BSS that is in use
......................................................................


Patch Set 3: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22819
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/hostap
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 4:54:26 PM5/16/12
to mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: CHROMIUMOS: wpa_supplicant: Don't remove a BSS that is in use
......................................................................


Patch Set 3: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22819
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/hostap
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 5:20:05 PM5/16/12
to mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: CHROMIUMOS: wpa_supplicant: Don't remove a BSS that is in use
......................................................................


Patch Set 3: Ready

Binutils issue?

--
To view, visit https://gerrit.chromium.org/gerrit/22819
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/hostap
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 6:28:47 PM5/16/12
to mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: CHROMIUMOS: wpa_supplicant: Don't remove a BSS that is in use
......................................................................


Patch Set 3: Ready

shill wimax unittest segfault.

--
To view, visit https://gerrit.chromium.org/gerrit/22819
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iaaf2a3a1a7d6a32c69d0a7f67bb0cf590946c2ed
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/hostap
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Reply all
Reply to author
Forward
0 new messages