HID: give bool option HID_BATTERY_STRENGTH a description [chromiumos/third_party/kernel : chromeos-3.4]

17 views
Skip to first unread message

Yufeng Shen (Code Review)

unread,
Feb 27, 2013, 6:19:41 PM2/27/13
to Olof Johansson, Mandeep Singh Baines
Yufeng Shen has uploaded a new change for review.

https://gerrit.chromium.org/gerrit/44243


Change subject: HID: give bool option HID_BATTERY_STRENGTH a description
......................................................................

HID: give bool option HID_BATTERY_STRENGTH a description

HID_BATTERY_STRENGTH is currently a bool option without description
and default to n, which means one can't enable the option in config
file by setting CONFIG_HID_BATTERY_STRENGTH=y. Fix it by giving it
a description.

Signed-off-by: Yufeng Shen <mil...@chromium.org>

BUG=chromium-os:39317
TEST=set CONFIG_HID_BATTERY_STRENGTH=y in base.config. build the
kernel, and check that this option is enabled in the built kernel

Change-Id: Ib102be911d922522136160f6f8cdded8f9716d94
---
M drivers/hid/Kconfig
1 file changed, 1 insertion(+), 1 deletion(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/43/44243/1

diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
index ffddcba..7b9f384 100644
--- a/drivers/hid/Kconfig
+++ b/drivers/hid/Kconfig
@@ -32,7 +32,7 @@
If unsure, say Y.

config HID_BATTERY_STRENGTH
- bool
+ bool "HID device battery strength support"
depends on HID && POWER_SUPPLY && HID = POWER_SUPPLY
default n


--
To view, visit https://gerrit.chromium.org/gerrit/44243
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib102be911d922522136160f6f8cdded8f9716d94
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>

Olof Johansson (Code Review)

unread,
Feb 27, 2013, 6:22:29 PM2/27/13
to Yufeng Shen, ChromeBot
Olof Johansson has posted comments on this change.

Change subject: HID: give bool option HID_BATTERY_STRENGTH a description
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Just a nit. Otherwise fine with me.

....................................................
File drivers/hid/Kconfig
Line 37: default n
You can remove "default n" when you do this too.


--
To view, visit https://gerrit.chromium.org/gerrit/44243
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib102be911d922522136160f6f8cdded8f9716d94
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Olof Johansson <ol...@chromium.org>

Yufeng Shen (Code Review)

unread,
Feb 27, 2013, 6:29:01 PM2/27/13
to ChromeBot, Olof Johansson
Yufeng Shen has posted comments on this change.

Change subject: HID: give bool option HID_BATTERY_STRENGTH a description
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File drivers/hid/Kconfig
Line 37: default n
Done


--
To view, visit https://gerrit.chromium.org/gerrit/44243
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib102be911d922522136160f6f8cdded8f9716d94
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>

Yufeng Shen (Code Review)

unread,
Feb 27, 2013, 6:44:25 PM2/27/13
to ChromeBot, Olof Johansson
Yufeng Shen has abandoned this change.

Change subject: CHROMIUM: HID: give bool option HID_BATTERY_STRENGTH a description
......................................................................


Patch Set 3: Abandoned

oops, there is already a upstream patch for this

http://git.kernel.org/?p=linux/kernel/git/stable/linux-stable.git;a=blobdiff;f=drivers/hid/Kconfig;h=a6f6b50b67af985cdbcc47327fe16b3f8cf67e29;hp=ffddcba32af62b637baa09fd9487f515451fca4f;hb=692d30d63b80b174d0ed24bbffb7a1ea536d5fee;hpb=0a97e1e9f9a6765e6243030ac42b04694f3f3647


will cherry-pick that one

--
To view, visit https://gerrit.chromium.org/gerrit/44243
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Ib102be911d922522136160f6f8cdded8f9716d94
Gerrit-PatchSet: 3
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.4
Gerrit-Owner: Yufeng Shen <mil...@chromium.org>
Reply all
Reply to author
Forward
0 new messages