[autotest] Re-land "Put dev server error strings in exceptio... [chromiumos/third_party/autotest : master]

0 views
Skip to first unread message

Chris Masone (Code Review)

unread,
May 16, 2012, 3:48:17 PM5/16/12
to Scott Zawalski, Chris Sosa
Hello Scott Zawalski, Chris Sosa,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/22847

to review the following change.

Change subject: [autotest] Re-land "Put dev server error strings in exceptions"
......................................................................

[autotest] Re-land "Put dev server error strings in exceptions"

We've been ignoring error messages coming back from the dev server.
Strip out the HTML that comes in (some of) them and wrap them
in exceptions.

This reverts commit 0dcf3a4c80b66d7598f3d7391bc1f9bf5492d8e2.

BUG=chromium-os:30279
TEST=unit
TEST=use atest suite create to run a suite that doesn't exist on build that doesn't exist.

Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
---
M client/common_lib/cros/dev_server.py
M client/common_lib/cros/dev_server_unittest.py
M frontend/afe/site_rpc_interface.py
M server/cros/control_file_getter.py
M server/cros/control_file_getter_unittest.py
M server/cros/dynamic_suite.py
M site_utils/test_scheduler.py
7 files changed, 102 insertions(+), 77 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/47/22847/1
--
To view, visit https://gerrit.chromium.org/gerrit/22847
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Sosa <so...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 3:48:42 PM5/16/12
to Chris Sosa, Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Re-land "Put dev server error strings in exceptions"
......................................................................


Patch Set 1:

How does this look? And how can I test the legacy scheduler?

--
To view, visit https://gerrit.chromium.org/gerrit/22847
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>

Scott Zawalski (Code Review)

unread,
May 16, 2012, 3:51:39 PM5/16/12
to Chris Masone, Chris Sosa
Scott Zawalski has posted comments on this change.

Change subject: [autotest] Re-land "Put dev server error strings in exceptions"
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22847
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 3:52:15 PM5/16/12
to Chris Sosa, Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Re-land "Put dev server error strings in exceptions"
......................................................................


Patch Set 1: Verified; Ready

Scott will stage this gently and we'll be sure the legacy scheduler won't die before deploying this in prod

--
To view, visit https://gerrit.chromium.org/gerrit/22847
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 5:01:24 PM5/16/12
to Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Re-land "Put dev server error strings in exceptions"
......................................................................


Patch Set 1: Ready

chromeos-ec unittest failure. Again, not me.

--
To view, visit https://gerrit.chromium.org/gerrit/22847
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Chris Masone <cma...@chromium.org>
Gerrit-Reviewer: Scott Zawalski <sco...@chromium.org>

Chris Masone (Code Review)

unread,
May 16, 2012, 5:03:06 PM5/16/12
to Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Re-land "Put dev server error strings in exceptions"
......................................................................


Patch Set 1: Ready

Thanks for removing the Ready bit again, CQ!

--
To view, visit https://gerrit.chromium.org/gerrit/22847
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>

Chris Masone (Code Review)

unread,
May 17, 2012, 9:48:56 AM5/17/12
to Scott Zawalski
Chris Masone has posted comments on this change.

Change subject: [autotest] Re-land "Put dev server error strings in exceptions"
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22847
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9d684d8b1c959d17c4b17082ef6892112b860493
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: master
Gerrit-Owner: Chris Masone <cma...@chromium.org>
Reply all
Reply to author
Forward
0 new messages