crash: only stash daemon store spools on request. [chromiumos/platform/tast-tests : master]

3 views
Skip to first unread message

Miriam Zimmerman (Gerrit)

unread,
Apr 7, 2020, 5:41:21 PM4/7/20
to Ian Barkley-Yeung

Patch set 1:Verified +1Commit-Queue +1

View Change

    To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromiumos/platform/tast-tests
    Gerrit-Branch: master
    Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
    Gerrit-Change-Number: 2139447
    Gerrit-PatchSet: 1
    Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
    Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
    Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
    Gerrit-Comment-Date: Tue, 07 Apr 2020 21:41:16 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    Gerrit-MessageType: comment

    Ian Barkley-Yeung (Gerrit)

    unread,
    Apr 7, 2020, 7:10:13 PM4/7/20
    to Miriam Zimmerman, Fergus Dall

    +side...@google.com FYI for crostini.CrashReporter test

    Patch set 1:Code-Review +2

    View Change

      To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/platform/tast-tests
      Gerrit-Branch: master
      Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
      Gerrit-Change-Number: 2139447
      Gerrit-PatchSet: 1
      Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
      Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
      Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
      Gerrit-CC: Commit Bot <commi...@chromium.org>
      Gerrit-CC: Fergus Dall <side...@google.com>
      Gerrit-Comment-Date: Tue, 07 Apr 2020 23:10:08 +0000

      Miriam Zimmerman (Gerrit)

      unread,
      Apr 7, 2020, 7:12:23 PM4/7/20
      to Tast Owners, Ian Barkley-Yeung, Fergus Dall

      Patch Set 1: Code-Review+2

      +side...@google.com FYI for crostini.CrashReporter test

      Good call, thanks

      View Change

        To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromiumos/platform/tast-tests
        Gerrit-Branch: master
        Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
        Gerrit-Change-Number: 2139447
        Gerrit-PatchSet: 1
        Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
        Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
        Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
        Gerrit-Reviewer: Tast Owners <tast-...@google.com>
        Gerrit-CC: Commit Bot <commi...@chromium.org>
        Gerrit-CC: Fergus Dall <side...@google.com>
        Gerrit-Comment-Date: Tue, 07 Apr 2020 23:12:15 +0000
        Gerrit-HasComments: No
        Gerrit-Has-Labels: No
        Gerrit-MessageType: comment

        Fergus Dall (Gerrit)

        unread,
        Apr 7, 2020, 8:13:09 PM4/7/20
        to Miriam Zimmerman, Tast Owners, Oleh Lamzin, Ian Barkley-Yeung

        Note that session_manager is not the same as chrome, so starting just session_manager should be less flaky then restarting chrome

        Patch set 1:Code-Review +2

        View Change

          To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromiumos/platform/tast-tests
          Gerrit-Branch: master
          Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
          Gerrit-Change-Number: 2139447
          Gerrit-PatchSet: 1
          Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
          Gerrit-Reviewer: Fergus Dall <side...@google.com>
          Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
          Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
          Gerrit-Reviewer: Oleh Lamzin <lam...@google.com>
          Gerrit-CC: Commit Bot <commi...@chromium.org>
          Gerrit-CC: Tast Owners <tast-...@google.com>
          Gerrit-Comment-Date: Wed, 08 Apr 2020 00:13:02 +0000

          Miriam Zimmerman (Gerrit)

          unread,
          Apr 7, 2020, 8:53:43 PM4/7/20
          to Fergus Dall, Tast Owners, Oleh Lamzin, Ian Barkley-Yeung

          Patch Set 1: Code-Review+2

          Note that session_manager is not the same as chrome, so starting just session_manager should be less flaky then restarting chrome

          I agree, but I was concerned because of the pushback that got on https://crrev.com/c/2138867, and wanted a fix that we could land fairly quickly (since this is flaking CQ-blocking tests)

          Patch set 1:Auto-Submit +1

          View Change

            To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromiumos/platform/tast-tests
            Gerrit-Branch: master
            Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
            Gerrit-Change-Number: 2139447
            Gerrit-PatchSet: 1
            Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Fergus Dall <side...@google.com>
            Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
            Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Oleh Lamzin <lam...@google.com>
            Gerrit-CC: Commit Bot <commi...@chromium.org>
            Gerrit-CC: Tast Owners <tast-...@google.com>
            Gerrit-Comment-Date: Wed, 08 Apr 2020 00:53:39 +0000

            Oleh Lamzin (Gerrit)

            unread,
            Apr 8, 2020, 5:38:27 AM4/8/20
            to Miriam Zimmerman, Fergus Dall, Tast Owners, Ian Barkley-Yeung

            LGTM % nit

            Patch set 1:Code-Review +2

            View Change

            1 comment:

            To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromiumos/platform/tast-tests
            Gerrit-Branch: master
            Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
            Gerrit-Change-Number: 2139447
            Gerrit-PatchSet: 1
            Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Fergus Dall <side...@google.com>
            Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
            Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Oleh Lamzin <lam...@google.com>
            Gerrit-CC: Commit Bot <commi...@chromium.org>
            Gerrit-CC: Tast Owners <tast-...@google.com>
            Gerrit-Comment-Date: Wed, 08 Apr 2020 09:38:22 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Gerrit-MessageType: comment

            Miriam Zimmerman (Gerrit)

            unread,
            Apr 8, 2020, 12:31:01 PM4/8/20
            to Ian Barkley-Yeung, Fergus Dall, Oleh Lamzin, Tast Owners

            Miriam Zimmerman uploaded patch set #2 to this change.

            View Change

            crash: only stash daemon store spools on request.

            The session manager is not reliably available, especially in tests where
            Chrome isn't yet running. Work around this by only trying to grab daemon
            store directories on request.

            NOTE: crostini.CrashReporter.artifact failed because I'm running a
            developer build:

            Required data file crostini_guest_images.tar missing: ...
            build artifact URL is unknown (running a developer build?)

            BUG=chromium:1068641
            TEST=(dut) `stop ui`; tast run $DUT platform.ServiceFailure.mock_consent
            TEST=tast run $DUT crostini.CrashReporter.*

            Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
            ---
            M src/chromiumos/tast/local/bundles/cros/crostini/crash_reporter.go
            M src/chromiumos/tast/local/crash/fixture.go
            2 files changed, 69 insertions(+), 40 deletions(-)

            To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromiumos/platform/tast-tests
            Gerrit-Branch: master
            Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
            Gerrit-Change-Number: 2139447
            Gerrit-PatchSet: 2
            Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Fergus Dall <side...@google.com>
            Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
            Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Oleh Lamzin <lam...@google.com>
            Gerrit-CC: Commit Bot <commi...@chromium.org>
            Gerrit-CC: Tast Owners <tast-...@google.com>
            Gerrit-MessageType: newpatchset

            Miriam Zimmerman (Gerrit)

            unread,
            Apr 8, 2020, 12:42:51 PM4/8/20
            to Oleh Lamzin, Fergus Dall, Tast Owners, Ian Barkley-Yeung

            Patch set 2:-Auto-Submit

            View Change

            1 comment:

              • nit: tearDownOption if you don't wanna export this type […]

                Done

            To view, visit change 2139447. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromiumos/platform/tast-tests
            Gerrit-Branch: master
            Gerrit-Change-Id: I39b68e8930092cff4965445eb54aec1d20547e14
            Gerrit-Change-Number: 2139447
            Gerrit-PatchSet: 2
            Gerrit-Owner: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Fergus Dall <side...@google.com>
            Gerrit-Reviewer: Ian Barkley-Yeung <i...@chromium.org>
            Gerrit-Reviewer: Miriam Zimmerman <mute...@chromium.org>
            Gerrit-Reviewer: Oleh Lamzin <lam...@google.com>
            Gerrit-CC: Commit Bot <commi...@chromium.org>
            Gerrit-CC: Tast Owners <tast-...@google.com>
            Gerrit-Comment-Date: Wed, 08 Apr 2020 16:42:46 +0000
            Gerrit-HasComments: Yes
            Gerrit-Has-Labels: Yes
            Comment-In-Reply-To: Oleh Lamzin <lam...@google.com>
            Gerrit-MessageType: comment
            Reply all
            Reply to author
            Forward
            0 new messages