shill: service: Update connectability when EAP parameters ar... [chromiumos/platform/shill : master]

0 views
Skip to first unread message

Paul Stewart (Code Review)

unread,
May 16, 2012, 2:23:59 PM5/16/12
to mukesh agrawal, Thieu Le
Hello mukesh agrawal, Thieu Le,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/22835

to review the following change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................

shill: service: Update connectability when EAP parameters are changed

When EAP parameters that affect connectability change over the RPC
interface, call set_eap, which will trigger an update of the
connectability of any service subclasses.

BUG=chromium-os:29374
TEST=New unit tests

Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
---
M service.cc
M service.h
M service_unittest.cc
M wifi_service.h
4 files changed, 85 insertions(+), 6 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/shill refs/changes/35/22835/1
--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Thieu Le <thi...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

mukesh agrawal (Code Review)

unread,
May 16, 2012, 2:56:06 PM5/16/12
to Paul Stewart, Thieu Le
mukesh agrawal has posted comments on this change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

No concerns on my part, but will let thieule have the honor of +2. :)

--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Paul Stewart (Code Review)

unread,
May 16, 2012, 3:41:40 PM5/16/12
to Thieu Le, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................


Patch Set 1: Verified

Tested on a real-live system -- with EAP.{ClientCert, Identity, PrivateKey} set via set-service-property, service transitions to "Connectable = True".

--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>

Thieu Le (Code Review)

unread,
May 16, 2012, 3:58:29 PM5/16/12
to Paul Stewart, mukesh agrawal
Thieu Le has posted comments on this change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 4:07:40 PM5/16/12
to Thieu Le, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................


Patch Set 1: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 5:02:45 PM5/16/12
to Thieu Le, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................


Patch Set 1: Ready

chromeos-ec failure

--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 5:19:19 PM5/16/12
to Thieu Le, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................


Patch Set 1: Ready

Toolchain issues on ARM?

--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 6:29:21 PM5/16/12
to Thieu Le, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: shill: service: Update connectability when EAP parameters are changed
......................................................................


Patch Set 1: Ready

Wimax unit test segfault unrelated to this change.

--
To view, visit https://gerrit.chromium.org/gerrit/22835
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6f0a78f771827b4fc941a27cce983d4790cbfd2a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/shill
Gerrit-Branch: master
Gerrit-Owner: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Reply all
Reply to author
Forward
0 new messages