clk: samsung: exynos5420: Add support for USB IPs' clocks [chromiumos/third_party/kernel-next : chromeos-3.8]

1 view
Skip to first unread message

Vivek Gautam (Code Review)

unread,
May 23, 2013, 11:00:47 AM5/23/13
to Olof Johansson
Vivek Gautam has uploaded a new change for review.

https://gerrit.chromium.org/gerrit/56399


Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................

clk: samsung: exynos5420: Add support for USB IPs' clocks

Adding required GATE definitions for USB 2.0 clock,
as well as clocks for both USB 3.0 channels.
These clocks are derived from ACLK_200_FSYS clock.

BUG=chrome-os-partner:19007
TEST=build and boot on smdk5420 and peach pit;
tested usb HID devices and mass storage devices on
USB 2.0 and USB 3.0 ports.

Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Signed-off-by: Vivek Gautam <gautam...@samsung.com>
---
M drivers/clk/samsung/clk-exynos5420.c
1 file changed, 3 insertions(+), 0 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel-next refs/changes/99/56399/1

diff --git a/drivers/clk/samsung/clk-exynos5420.c b/drivers/clk/samsung/clk-exynos5420.c
index 2b49f8f..49143d9 100755
--- a/drivers/clk/samsung/clk-exynos5420.c
+++ b/drivers/clk/samsung/clk-exynos5420.c
@@ -572,6 +572,9 @@
GATE(smmu_jpeg, "smmu_jpeg", "aclk300_jpeg", GATE_IP_GEN, 7, 0, 0),
GATE(smmu_mdma1, "smmu_mdma1", "aclk266", GATE_IP_GEN, 9, 0, 0),
GATE(g3d, "g3d", "mout_user_aclk_g3d", GATE_IP_G3D, 9, 0, 0),
+ GATE(usbh20, "usbh20", "aclk200_fsys", GATE_IP_FSYS, 18, 0, 0),
+ GATE(usbd300, "usbd300", "aclk200_fsys", GATE_IP_FSYS, 19, 0, 0),
+ GATE(usbd301, "usbd301", "aclk200_fsys", GATE_IP_FSYS, 20, 0, 0),
};

static __initdata struct of_device_id ext_clk_match[] = {

--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>

Julius Werner (Code Review)

unread,
May 23, 2013, 5:17:48 PM5/23/13
to Vivek Gautam, ChromeBot, Doug Anderson, Simon Glass, Alim Akhtar, Julius Werner
Julius Werner has posted comments on this change.

Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Julius Werner <jwe...@chromium.org>
Gerrit-Reviewer: Julius Werner <jwe...@google.com>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>

Doug Anderson (Code Review)

unread,
May 23, 2013, 8:19:36 PM5/23/13
to Vivek Gautam, ChromeBot, Simon Glass, Abhilash Kesavan, Alim Akhtar, Julius Werner, Julius Werner
Doug Anderson has posted comments on this change.

Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................


Patch Set 1:

May need a rebase since I touched this file a bit heavily.

Abhliash (or anyone from SLSI who feels like they know this well): can you give this a review and add your +1?

--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>
Gerrit-Reviewer: Abhilash Kesavan <a.ke...@samsung.com>

Abhilash Kesavan (Code Review)

unread,
May 23, 2013, 11:50:15 PM5/23/13
to Vivek Gautam, ChromeBot, Doug Anderson, Simon Glass, Alim Akhtar, Julius Werner, Julius Werner
Abhilash Kesavan has posted comments on this change.

Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

(1 inline comment)

....................................................
File drivers/clk/samsung/clk-exynos5420.c
Line 577: GATE(usbd301, "usbd301", "aclk200_fsys", GATE_IP_FSYS, 20, 0, 0),
usbd seems to need a PMU register to be set. We could set it up in the pmu file (the register is undocumented but we are using it for S2R as well) later.


--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>

Vivek Gautam (Code Review)

unread,
May 24, 2013, 2:45:58 AM5/24/13
to ChromeBot, Doug Anderson, Simon Glass, Abhilash Kesavan, Alim Akhtar, Julius Werner, Julius Werner
Vivek Gautam has posted comments on this change.

Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File drivers/clk/samsung/clk-exynos5420.c
Line 577: GATE(usbd301, "usbd301", "aclk200_fsys", GATE_IP_FSYS, 20, 0, 0),
USBDEV_PHY_CONTROL (@ 0x10040704) and USBDEV1_PHY_CONTROL (@ 0x10040708), these registers are getting programmed by samsung_usbphy_set_isolation() in https://gerrit.chromium.org/gerrit/#/c/56398/1/drivers/usb/phy/samsung-usbphy.c

Is it something else that i am missing ?


--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>
Gerrit-Reviewer: Abhilash Kesavan <a.ke...@samsung.com>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Julius Werner <jwe...@chromium.org>
Gerrit-Reviewer: Julius Werner <jwe...@google.com>
Gerrit-Reviewer: Simon Glass <s...@chromium.org>
Gerrit-Reviewer: Vivek Gautam <gautam...@samsung.com>

Vivek Gautam (Code Review)

unread,
May 24, 2013, 7:14:25 AM5/24/13
to ChromeBot, Doug Anderson, Simon Glass, Abhilash Kesavan, Alim Akhtar, Julius Werner, Julius Werner
Vivek Gautam has posted comments on this change.

Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................


Patch Set 2: Verified

--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>

Doug Anderson (Code Review)

unread,
May 24, 2013, 11:27:25 AM5/24/13
to Vivek Gautam, ChromeBot, Simon Glass, Abhilash Kesavan, Alim Akhtar, Julius Werner, Julius Werner
Doug Anderson has posted comments on this change.

Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................


Patch Set 2: Looks good to me, approved; Verified

--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>

Julius Werner (Code Review)

unread,
May 24, 2013, 3:22:13 PM5/24/13
to Vivek Gautam, ChromeBot, Doug Anderson, Simon Glass, Abhilash Kesavan, Alim Akhtar, Julius Werner
Julius Werner has posted comments on this change.

Change subject: clk: samsung: exynos5420: Add support for USB IPs' clocks
......................................................................


Patch Set 2: Looks good to me, approved; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/56399
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I338d0c910d8f357b953c0992bdfaa7448fcb515b
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Vivek Gautam <gautam...@samsung.com>
Reply all
Reply to author
Forward
0 new messages