CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence [chromiumos/third_party/kernel : chromeos-3.18]
11 views
Skip to first unread message
Balamurugan Selvarajan (Gerrit)
Jun 17, 2016, 12:45:55 PM6/17/16
to chromium-...@chromium.org
Balamurugan Selvarajan has uploaded a new change for review.
https://chromium-review.googlesource.com/353592
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
Modified audio_hw_params to have stereo config reset in the beginning
to ensure cleaner I2S state machines. This reset should done before
configuring the I2S parameters.
BUG=chrome-os-partner:53767
TEST=unit tested audio driver with below test cases.
1. Tested for static noise during playback
2. Tested for noise during the start/end of the audio
3. Loop audio playback for 500 times. Should play without
random noise, crash or hangs.
Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Signed-off-by: Balamurugan Selvarajan <bsel...@codeaurora.org>
---
M sound/soc/qca/ipq4019-cpu-dai.c
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/sound/soc/qca/ipq4019-cpu-dai.c
b/sound/soc/qca/ipq4019-cpu-dai.c
index 5f7b3ce..0542224 100644
--- a/sound/soc/qca/ipq4019-cpu-dai.c
+++ b/sound/soc/qca/ipq4019-cpu-dai.c
@@ -187,8 +187,13 @@
bclk = rate * bit_act * channels;
mclk = bclk * MCLK_MULTI;
+ /*
+ * Stereo config reset here will resets I2S buffers and state machine
+ * and the configuration sequence to be in the below order.
+ */
+ ipq4019_stereo_config_reset(stereo_id);
+ ipq4019_stereo_config_enable(DISABLE, stereo_id);
ipq4019_glb_clk_enable_oe(substream->stream);
-
ipq4019_config_master(ENABLE, stereo_id);
ret = ipq4019_cfg_bit_width(bit_width, stereo_id);
@@ -197,9 +202,6 @@
return ret;
}
- ipq4019_stereo_config_enable(DISABLE, stereo_id);
-
- ipq4019_stereo_config_reset(ENABLE, stereo_id);
ipq4019_stereo_config_mic_reset(ENABLE, stereo_id);
mdelay(5);
@@ -211,7 +213,6 @@
return ret;
}
- ipq4019_stereo_config_reset(DISABLE, stereo_id);
ipq4019_stereo_config_mic_reset(DISABLE, stereo_id);
ipq4019_stereo_config_enable(ENABLE, stereo_id);
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
https://chromium-review.googlesource.com/353592
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
Modified audio_hw_params to have stereo config reset in the beginning
to ensure cleaner I2S state machines. This reset should done before
configuring the I2S parameters.
BUG=chrome-os-partner:53767
TEST=unit tested audio driver with below test cases.
1. Tested for static noise during playback
2. Tested for noise during the start/end of the audio
3. Loop audio playback for 500 times. Should play without
random noise, crash or hangs.
Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Signed-off-by: Balamurugan Selvarajan <bsel...@codeaurora.org>
---
M sound/soc/qca/ipq4019-cpu-dai.c
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/sound/soc/qca/ipq4019-cpu-dai.c
b/sound/soc/qca/ipq4019-cpu-dai.c
index 5f7b3ce..0542224 100644
--- a/sound/soc/qca/ipq4019-cpu-dai.c
+++ b/sound/soc/qca/ipq4019-cpu-dai.c
@@ -187,8 +187,13 @@
bclk = rate * bit_act * channels;
mclk = bclk * MCLK_MULTI;
+ /*
+ * Stereo config reset here will resets I2S buffers and state machine
+ * and the configuration sequence to be in the below order.
+ */
+ ipq4019_stereo_config_reset(stereo_id);
+ ipq4019_stereo_config_enable(DISABLE, stereo_id);
ipq4019_glb_clk_enable_oe(substream->stream);
-
ipq4019_config_master(ENABLE, stereo_id);
ret = ipq4019_cfg_bit_width(bit_width, stereo_id);
@@ -197,9 +202,6 @@
return ret;
}
- ipq4019_stereo_config_enable(DISABLE, stereo_id);
-
- ipq4019_stereo_config_reset(ENABLE, stereo_id);
ipq4019_stereo_config_mic_reset(ENABLE, stereo_id);
mdelay(5);
@@ -211,7 +213,6 @@
return ret;
}
- ipq4019_stereo_config_reset(DISABLE, stereo_id);
ipq4019_stereo_config_mic_reset(DISABLE, stereo_id);
ipq4019_stereo_config_enable(ENABLE, stereo_id);
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Grant Grundler (Gerrit)
Jun 20, 2016, 6:27:45 PM6/20/16
to Balamurugan Selvarajan, Grant Grundler, Jaiganesh Narayanan, Varadarajan Narayanan, Suresh Rajashekara, Nitheesh Sekar, Dmitry Torokhov, Sreedhar Sambangi
Grant Grundler has posted comments on this change.
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
Patch Set 1: Code-Review+2 Trybot-Ready+1
(1 comment)
In the comments, I'm just picking nits at this point. Think about "why"
something needs to be done (or in a particular order), not just declare
some particular order is right.
https://chromium-review.googlesource.com/#/c/353592/1/sound/soc/qca/ipq4019-cpu-dai.c
File sound/soc/qca/ipq4019-cpu-dai.c:
Line 192: * and the configuration sequence to be in the below order.
The second line of this comment isn't very useful. It's a tautology.
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
Gerrit-Reviewer: Jaiganesh Narayanan <njai...@codeaurora.org>
Gerrit-Reviewer: Nitheesh Sekar <nse...@codeaurora.org>
Gerrit-Reviewer: Sreedhar Sambangi <ssam...@codeaurora.org>
Gerrit-Reviewer: Suresh Rajashekara <sure...@chromium.org>
Gerrit-Reviewer: Varadarajan Narayanan <var...@codeaurora.org>
Gerrit-HasComments: Yes
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
(1 comment)
In the comments, I'm just picking nits at this point. Think about "why"
something needs to be done (or in a particular order), not just declare
some particular order is right.
https://chromium-review.googlesource.com/#/c/353592/1/sound/soc/qca/ipq4019-cpu-dai.c
File sound/soc/qca/ipq4019-cpu-dai.c:
Line 192: * and the configuration sequence to be in the below order.
The second line of this comment isn't very useful. It's a tautology.
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-Reviewer: Dmitry Torokhov <dt...@chromium.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
Gerrit-Reviewer: Jaiganesh Narayanan <njai...@codeaurora.org>
Gerrit-Reviewer: Nitheesh Sekar <nse...@codeaurora.org>
Gerrit-Reviewer: Sreedhar Sambangi <ssam...@codeaurora.org>
Gerrit-Reviewer: Suresh Rajashekara <sure...@chromium.org>
Gerrit-Reviewer: Varadarajan Narayanan <var...@codeaurora.org>
Gerrit-HasComments: Yes
Balamurugan Selvarajan (Gerrit)
Jun 21, 2016, 1:42:36 AM6/21/16
to ChromeOS Commit Bot, Jaiganesh Narayanan, Dmitry Torokhov, Sreedhar Sambangi, Varadarajan Narayanan, Suresh Rajashekara, Nitheesh Sekar, Grant Grundler
Balamurugan Selvarajan has posted comments on this change.
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
Patch Set 1: Verified+1 Commit-Queue+1
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Reviewer: ChromeOS Commit Bot <chromeos-...@chromium.org>
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-Reviewer: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-Reviewer: ChromeOS Commit Bot <chromeos-...@chromium.org>
Gerrit-Reviewer: Dmitry Torokhov <dt...@chromium.org>
Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
Gerrit-Reviewer: Jaiganesh Narayanan <njai...@codeaurora.org>
Gerrit-Reviewer: Nitheesh Sekar <nse...@codeaurora.org>
Gerrit-Reviewer: Sreedhar Sambangi <ssam...@codeaurora.org>
Gerrit-Reviewer: Suresh Rajashekara <sure...@chromium.org>
Gerrit-Reviewer: Varadarajan Narayanan <var...@codeaurora.org>
Gerrit-HasComments: No
Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
Gerrit-Reviewer: Jaiganesh Narayanan <njai...@codeaurora.org>
Gerrit-Reviewer: Nitheesh Sekar <nse...@codeaurora.org>
Gerrit-Reviewer: Sreedhar Sambangi <ssam...@codeaurora.org>
Gerrit-Reviewer: Suresh Rajashekara <sure...@chromium.org>
Gerrit-Reviewer: Varadarajan Narayanan <var...@codeaurora.org>
Balamurugan Selvarajan (Gerrit)
Jun 22, 2016, 12:59:05 AM6/22/16
to ChromeOS Commit Bot, Jaiganesh Narayanan, Dmitry Torokhov, Sreedhar Sambangi, Varadarajan Narayanan, Suresh Rajashekara, Nitheesh Sekar, Grant Grundler
Balamurugan Selvarajan has posted comments on this change.
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
Patch Set 2: Verified+1 Commit-Queue+1
......................................................................
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Balamurugan Selvarajan (Gerrit)
Jun 22, 2016, 11:30:52 AM6/22/16
to ChromeOS Commit Bot, Jaiganesh Narayanan, Dmitry Torokhov, Sreedhar Sambangi, Varadarajan Narayanan, Suresh Rajashekara, Nitheesh Sekar, Grant Grundler
Balamurugan Selvarajan has posted comments on this change.
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
Patch Set 2: Commit-Queue+1
......................................................................
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 2
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Grant Grundler (Gerrit)
Jun 22, 2016, 3:27:49 PM6/22/16
to Balamurugan Selvarajan, ChromeOS Commit Bot, Jaiganesh Narayanan, Dmitry Torokhov, Sreedhar Sambangi, Varadarajan Narayanan, Suresh Rajashekara, Nitheesh Sekar, Grant Grundler
Grant Grundler has posted comments on this change.
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
Patch Set 2:
This patch actually landed. DO not change it's state. See
https://bugs.chromium.org/p/chromium/issues/detail?id=617666#c22
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Change subject: CHROMIUM: ASoC: ipq4019: Modify I2S configuration sequence
......................................................................
This patch actually landed. DO not change it's state. See
https://bugs.chromium.org/p/chromium/issues/detail?id=617666#c22
--
To view, visit https://chromium-review.googlesource.com/353592
To unsubscribe, visit https://chromium-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 2
Gerrit-Change-Id: I6385cce722c7a90098b7a56754ac81fde9d549f6
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Gerrit-Branch: chromeos-3.18
Gerrit-Owner: Balamurugan Selvarajan <bsel...@codeaurora.org>
Reply all
Reply to author
Forward
0 new messages