autotest: sound_infrastructure: remove unused function [chromiumos/third_party/autotest : release-R20-2268.B]

2 views
Skip to first unread message

Taylor Hutt (Code Review)

unread,
May 18, 2012, 11:49:18 AM5/18/12
to Dylan Reid, Taylor Hutt
Hello Dylan Reid,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/23033

to review the following change.

Change subject: autotest: sound_infrastructure: remove unused function
......................................................................

autotest: sound_infrastructure: remove unused function

The load_asound_state() function is no longer used by this test, so it
can be removed.

BUG=none
TEST=Tested against 'stumpy'; test passes before & after change.
Change-Id: I5777afc8a7b5499d1a63c5a9eb102a9ef1a01092
Signed-off-by: Taylor Hutt <th...@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/22821
Reviewed-by: Dylan Reid <dgr...@chromium.org>
---
M client/tests/sound_infrastructure/sound_infrastructure.py
1 file changed, 0 insertions(+), 4 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/autotest refs/changes/33/23033/1
--
To view, visit https://gerrit.chromium.org/gerrit/23033
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5777afc8a7b5499d1a63c5a9eb102a9ef1a01092
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: release-R20-2268.B
Gerrit-Owner: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>

Dylan Reid (Code Review)

unread,
May 18, 2012, 11:52:56 AM5/18/12
to Taylor Hutt
Dylan Reid has posted comments on this change.

Change subject: autotest: sound_infrastructure: remove unused function
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/23033
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Taylor Hutt (Code Review)

unread,
May 18, 2012, 1:12:05 PM5/18/12
to Taylor Hutt, Dylan Reid
Taylor Hutt has posted comments on this change.

Change subject: autotest: sound_infrastructure: remove unused function
......................................................................


Patch Set 1: Verified

Partial fix for sound_infrastructure failure tests on R20

--
To view, visit https://gerrit.chromium.org/gerrit/23033
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5777afc8a7b5499d1a63c5a9eb102a9ef1a01092
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: release-R20-2268.B
Gerrit-Owner: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>

Taylor Hutt (Code Review)

unread,
May 18, 2012, 1:12:21 PM5/18/12
to Taylor Hutt, Dylan Reid
Taylor Hutt has posted comments on this change.

Change subject: autotest: sound_infrastructure: remove unused function
......................................................................




--
To view, visit https://gerrit.chromium.org/gerrit/23033
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5777afc8a7b5499d1a63c5a9eb102a9ef1a01092
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: release-R20-2268.B
Gerrit-Owner: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>

Mike Truty (Code Review)

unread,
May 18, 2012, 2:16:38 PM5/18/12
to Taylor Hutt, Mike Truty, Dylan Reid
Mike Truty has posted comments on this change.

Change subject: autotest: sound_infrastructure: remove unused function
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/23033
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5777afc8a7b5499d1a63c5a9eb102a9ef1a01092
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: release-R20-2268.B
Gerrit-Owner: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Gerrit-Reviewer: Mike Truty <tr...@chromium.org>
Gerrit-Reviewer: Taylor Hutt <th...@chromium.org>

Taylor Hutt (Code Review)

unread,
May 21, 2012, 9:34:06 AM5/21/12
to Taylor Hutt, Mike Truty, Dylan Reid
Taylor Hutt has submitted this change and it was merged.

Change subject: autotest: sound_infrastructure: remove unused function
......................................................................


autotest: sound_infrastructure: remove unused function

The load_asound_state() function is no longer used by this test, so it
can be removed.

BUG=none
TEST=Tested against 'stumpy'; test passes before & after change.
Change-Id: I5777afc8a7b5499d1a63c5a9eb102a9ef1a01092
Signed-off-by: Taylor Hutt <th...@chromium.org>
Reviewed-on: https://gerrit.chromium.org/gerrit/22821
Reviewed-by: Dylan Reid <dgr...@chromium.org>
---
M client/tests/sound_infrastructure/sound_infrastructure.py
1 file changed, 0 insertions(+), 4 deletions(-)

Approvals:
Dylan Reid: Looks good to me, but someone else must approve
Taylor Hutt: Verified
Mike Truty: Looks good to me, approved


--
To view, visit https://gerrit.chromium.org/gerrit/23033
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I5777afc8a7b5499d1a63c5a9eb102a9ef1a01092
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/autotest
Gerrit-Branch: release-R20-2268.B
Gerrit-Owner: Taylor Hutt <th...@chromium.org>
Gerrit-Reviewer: Dylan Reid <dgr...@chromium.org>
Reply all
Reply to author
Forward
0 new messages