UPSTREAM: ath9k: Disable ASPM only for AR9285 [chromiumos/third_party/kernel : release-R23-2913.B]

16 views
Skip to first unread message

Todd Broch (Code Review)

unread,
Sep 25, 2012, 12:22:23 PM9/25/12
to Sameer Nanda, Paul Stewart, Olof Johansson, Mandeep Singh Baines
Hello Sameer Nanda, Paul Stewart,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/33996

to review the following change.

Change subject: UPSTREAM: ath9k: Disable ASPM only for AR9285
......................................................................

UPSTREAM: ath9k: Disable ASPM only for AR9285

Currently, ASPM is disabled for all WLAN+BT combo chipsets
when BTCOEX is enabled. This is incorrect since the workaround
is required only for WB195, which is a AR9285+AR3011 combo
solution. Fix this by checking for the HW version when enabling
the workaround.

Cc: sta...@vger.kernel.org
Signed-off-by: Sujith Manoharan <c_ma...@qca.qualcomm.com>
Signed-off-by: Paul Stewart <ps...@chromium.org>

BUG=chrome-os-partner:14030
TEST=Install and run on 9462-based device. Observe that output
of "lspci -vvv -d 168c:0034" contains "ASPM L0s L1 Enabled".

Change-Id: I8052a176ce74eb830d46aa82a8149888745a0e6a
Reviewed-on: https://gerrit.chromium.org/gerrit/33790
Reviewed-by: Sameer Nanda <sna...@chromium.org>
Reviewed-by: Todd Broch <tbr...@chromium.org>
Commit-Ready: Paul Stewart <ps...@chromium.org>
Tested-by: Paul Stewart <ps...@chromium.org>
(cherry picked from commit aa6ac88f83ec58da7e2164aaaa94108bdb35d128)
---
M drivers/net/wireless/ath/ath9k_btcoex/pci.c
1 file changed, 3 insertions(+), 2 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/third_party/kernel refs/changes/96/33996/1
--
To view, visit https://gerrit.chromium.org/gerrit/33996
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8052a176ce74eb830d46aa82a8149888745a0e6a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Todd Broch <tbr...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Sameer Nanda <sna...@chromium.org>

Sameer Nanda (Code Review)

unread,
Sep 25, 2012, 12:50:53 PM9/25/12
to Todd Broch, Sameer Nanda, Olof Johansson, Paul Stewart
Sameer Nanda has posted comments on this change.

Change subject: UPSTREAM: ath9k: Disable ASPM only for AR9285
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/33996
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8052a176ce74eb830d46aa82a8149888745a0e6a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Todd Broch <tbr...@chromium.org>
Gerrit-Reviewer: Olof Johansson <ol...@chromium.org>

Olof Johansson (Code Review)

unread,
Sep 26, 2012, 11:17:44 AM9/26/12
to Todd Broch, Sameer Nanda, Paul Stewart
Olof Johansson has posted comments on this change.

Change subject: UPSTREAM: ath9k: Disable ASPM only for AR9285
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/33996
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8052a176ce74eb830d46aa82a8149888745a0e6a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Todd Broch <tbr...@chromium.org>
Gerrit-Reviewer: Olof Johansson <ol...@chromium.org>

Todd Broch (Code Review)

unread,
Sep 26, 2012, 11:19:04 AM9/26/12
to Sameer Nanda, Olof Johansson, Paul Stewart
Todd Broch has posted comments on this change.

Change subject: UPSTREAM: ath9k: Disable ASPM only for AR9285
......................................................................


Patch Set 1: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/33996
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8052a176ce74eb830d46aa82a8149888745a0e6a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Todd Broch <tbr...@chromium.org>
Gerrit-Reviewer: Olof Johansson <ol...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Sameer Nanda <sna...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>

Todd Broch (Code Review)

unread,
Sep 26, 2012, 11:19:05 AM9/26/12
to Sameer Nanda, Olof Johansson, Paul Stewart
Todd Broch has submitted this change and it was merged.

Change subject: UPSTREAM: ath9k: Disable ASPM only for AR9285
......................................................................


UPSTREAM: ath9k: Disable ASPM only for AR9285

Currently, ASPM is disabled for all WLAN+BT combo chipsets
when BTCOEX is enabled. This is incorrect since the workaround
is required only for WB195, which is a AR9285+AR3011 combo
solution. Fix this by checking for the HW version when enabling
the workaround.

Cc: sta...@vger.kernel.org
Signed-off-by: Sujith Manoharan <c_ma...@qca.qualcomm.com>
Signed-off-by: Paul Stewart <ps...@chromium.org>

BUG=chrome-os-partner:14030
TEST=Install and run on 9462-based device. Observe that output
of "lspci -vvv -d 168c:0034" contains "ASPM L0s L1 Enabled".

Change-Id: I8052a176ce74eb830d46aa82a8149888745a0e6a
Reviewed-on: https://gerrit.chromium.org/gerrit/33790
Reviewed-by: Sameer Nanda <sna...@chromium.org>
Reviewed-by: Todd Broch <tbr...@chromium.org>
Commit-Ready: Paul Stewart <ps...@chromium.org>
Tested-by: Paul Stewart <ps...@chromium.org>
(cherry picked from commit aa6ac88f83ec58da7e2164aaaa94108bdb35d128)
---
M drivers/net/wireless/ath/ath9k_btcoex/pci.c
1 file changed, 3 insertions(+), 2 deletions(-)

Approvals:
Sameer Nanda: Looks good to me, but someone else must approve
Olof Johansson: Looks good to me, approved
Todd Broch: Verified; Ready


--
To view, visit https://gerrit.chromium.org/gerrit/33996
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8052a176ce74eb830d46aa82a8149888745a0e6a
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: release-R23-2913.B
Gerrit-Owner: Todd Broch <tbr...@chromium.org>
Gerrit-Reviewer: Olof Johansson <ol...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Sameer Nanda <sna...@chromium.org>
Gerrit-Reviewer: Todd Broch <tbr...@chromium.org>
Reply all
Reply to author
Forward
0 new messages