Remove flimflam from the Chrome OS build and image! [chromiumos/overlays/chromiumos-overlay : master]

Darin Petkov (Code Review)

unread,

Nov 5, 2012, 6:59:25 AM11/5/12

to Darin Petkov

Darin Petkov has uploaded a new change for review.

Change subject: Remove flimflam from the Chrome OS build and image!
......................................................................

Remove flimflam from the Chrome OS build and image!

Note that /usr/local/lib/flimflam/test is still installed on the test
image by the flimflam-test ebuild.

BUG=chromium-os:32415
TEST=build base and test images, installed, verified connectivity --
ethernet, corp wifi, vpn. checked that flimflam files are not
installed. trybots.

Change-Id: I148bb27aaa0ae561646fdea3cd2109508a162693
---
M chromeos-base/autotest-factory/autotest-factory-9999.ebuild
R chromeos-base/chromeos/chromeos-0.0.1-r176.ebuild
M chromeos-base/chromeos/chromeos-0.0.1.ebuild
M chromeos-base/flimflam-test/flimflam-test-9999.ebuild
M eclass/cros-workon.eclass
M net-dialup/ppp/ppp-2.4.5-r3.ebuild
6 files changed, 6 insertions(+), 13 deletions(-)

git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/52/37352/1
--
To view, visit https://gerrit.chromium.org/gerrit/37352
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I148bb27aaa0ae561646fdea3cd2109508a162693
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>

Darin Petkov (Code Review)

unread,

Nov 5, 2012, 7:01:24 AM11/5/12

to Darin Petkov, Gerrit, Thieu Le, Ben Chan, mukesh agrawal, Paul Stewart

Darin Petkov has posted comments on this change.

Change subject: Remove flimflam from the Chrome OS build and image!
......................................................................

Patch Set 1: Verified

Who wants to have the honor to +2? :-)

--
To view, visit https://gerrit.chromium.org/gerrit/37352
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I148bb27aaa0ae561646fdea3cd2109508a162693
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>

Gerrit-Reviewer: Ben Chan <ben...@chromium.org>
Gerrit-Reviewer: Darin Petkov <pet...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Thieu Le <thi...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

Paul Stewart (Code Review)

unread,

Nov 5, 2012, 11:50:46 AM11/5/12

to Darin Petkov, Gerrit, Thieu Le, Ben Chan, mukesh agrawal

Paul Stewart has posted comments on this change.

Change subject: Remove flimflam from the Chrome OS build and image!
......................................................................

Patch Set 1: Looks good to me, approved

Cheers.

--
To view, visit https://gerrit.chromium.org/gerrit/37352
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment

Gerrit-Change-Id: I148bb27aaa0ae561646fdea3cd2109508a162693
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>

Darin Petkov (Code Review)

unread,

Nov 6, 2012, 4:09:16 AM11/6/12

to Darin Petkov, Gerrit, Thieu Le, Ben Chan, mukesh agrawal, Paul Stewart

Darin Petkov has posted comments on this change.

Change subject: Remove flimflam from the Chrome OS build and image!
......................................................................

Patch Set 2: Verified; Looks good to me, approved; Ready

Inherit +2.

--
To view, visit https://gerrit.chromium.org/gerrit/37352
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I148bb27aaa0ae561646fdea3cd2109508a162693
Gerrit-PatchSet: 2

Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Darin Petkov <pet...@chromium.org>

Reply all

Reply to author

Forward