build_image: use an array for excludes [chromiumos/platform/crosutils : master]

12 views
Skip to first unread message

Mike Frysinger (Code Review)

unread,
Nov 5, 2012, 5:18:43 PM11/5/12
to David James, Ryan Cui, Brian Harring, Chris Sosa, Mike Frysinger
Hello David James,

I'd like you to do a code review. Please visit

https://gerrit.chromium.org/gerrit/37377

to review the following change.

Change subject: build_image: use an array for excludes
......................................................................

build_image: use an array for excludes

This makes a follow up commit easier to document excludes.

BUG=chromium-os:22939
TEST=build_image for daisy installs same set of files

Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
---
M build_library/base_image_util.sh
1 file changed, 8 insertions(+), 2 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/platform/crosutils refs/changes/77/37377/1
--
To view, visit https://gerrit.chromium.org/gerrit/37377
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>

David James (Code Review)

unread,
Nov 5, 2012, 7:47:18 PM11/5/12
to Mike Frysinger, Gerrit
David James has posted comments on this change.

Change subject: build_image: use an array for excludes
......................................................................


Patch Set 1: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/37377
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>

Mike Frysinger (Code Review)

unread,
Nov 5, 2012, 10:21:16 PM11/5/12
to Mike Frysinger, Gerrit, David James
Mike Frysinger has posted comments on this change.

Change subject: build_image: use an array for excludes
......................................................................


Patch Set 1: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/37377
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I09a9b3fe6f8c1d1fd9dd4d094f2fb7c81ce24880
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/platform/crosutils
Gerrit-Branch: master
Gerrit-Owner: Mike Frysinger <vap...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Gerrit <chrom...@google.com>
Gerrit-Reviewer: Mike Frysinger <vap...@chromium.org>
Reply all
Reply to author
Forward
0 new messages