CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver [chromiumos/third_party/kernel : chromeos-4.4]

50 views
Skip to first unread message

Sathyanarayana Nujella (Gerrit)

unread,
Apr 27, 2018, 9:24:48 PM4/27/18
to Sathya Prakash M R, Naveen M

Sathyanarayana Nujella would like Sathya Prakash M R and Naveen M to review this change.

View Change

CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

This patch adds Kabylake I2S machine driver which uses:
Max98373 as speaker amp and DA7219 headset codec.

Also, adds kabylake kbl_da7219_max98373 machine driver entry
in to machine table.

BUG=b:73635449
TEST=Verified sound card binds and spk playback works

Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 775 insertions(+), 0 deletions(-)


To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
Gerrit-Change-Number: 1033465
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
Gerrit-Reviewer: Naveen M <nave...@intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
Gerrit-MessageType: newchange

Naveen M (Gerrit)

unread,
Apr 27, 2018, 10:00:44 PM4/27/18
to Sathyanarayana Nujella, Sathya Prakash M R

View Change

1 comment:

  • File sound/soc/intel/skylake/skl.c:

    • Patch Set #1, Line 1031:

      static struct sst_codecs kbl_7219_98373_codecs = {
      .num_codecs = 1,
      .codecs = {"MX98373"}
      };

      This entry should go as a separate patch..
      I understand the patch-set is temporary but once we have the upstream commits for these, we can just update and get it merged.

To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/third_party/kernel
Gerrit-Branch: chromeos-4.4
Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
Gerrit-Change-Number: 1033465
Gerrit-PatchSet: 1
Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
Gerrit-Reviewer: Naveen M <nave...@intel.com>
Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
Gerrit-Comment-Date: Sat, 28 Apr 2018 02:00:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Sathyanarayana Nujella (Gerrit)

unread,
Apr 27, 2018, 10:06:21 PM4/27/18
to Naveen M, Sathya Prakash M R

(1 comment)

Yes, thanks. once upstream patches are ready, want to reduce number of patches to revert. So, including all in one.

View Change

    To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

    Gerrit-Project: chromiumos/third_party/kernel
    Gerrit-Branch: chromeos-4.4
    Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
    Gerrit-Change-Number: 1033465
    Gerrit-PatchSet: 1
    Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
    Gerrit-Reviewer: Naveen M <nave...@intel.com>
    Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
    Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
    Gerrit-Comment-Date: Sat, 28 Apr 2018 02:06:18 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: No
    Gerrit-MessageType: comment

    Naveen M (Gerrit)

    unread,
    Apr 28, 2018, 11:26:40 AM4/28/18
    to Sathyanarayana Nujella, Sathya Prakash M R

    Patch set 1:Code-Review +1

    View Change

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 1
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Comment-Date: Sat, 28 Apr 2018 15:25:33 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      Gerrit-MessageType: comment

      Sathyanarayana Nujella (Gerrit)

      unread,
      May 4, 2018, 11:53:24 PM5/4/18
      to Sathya Prakash M R, Naveen M

      Sathyanarayana Nujella uploaded patch set #2 to this change.

      View Change

      CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

      This patch adds Kabylake I2S machine driver which uses:
      Max98373 as speaker amp and DA7219 headset codec.

      Also, adds kabylake kbl_da7219_max98373 machine driver entry
      in to machine table.

      BUG=b:73635449
      TEST=Verified sound card binds and spk playback works

      Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
      Signed-off-by: Naveen Manohar <nave...@intel.com>
      Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      ---
      M sound/soc/intel/Kconfig
      M sound/soc/intel/boards/Makefile
      A sound/soc/intel/boards/kbl_da7219_max98373.c
      M sound/soc/intel/skylake/skl.c
      4 files changed, 994 insertions(+), 0 deletions(-)

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 2
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-MessageType: newpatchset

      Sathyanarayana Nujella (Gerrit)

      unread,
      May 4, 2018, 11:57:53 PM5/4/18
      to Sathya Prakash M R, Naveen M

      Sathyanarayana Nujella uploaded patch set #3 to this change.

      View Change

      CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

      This patch adds Kabylake I2S machine driver for the below two configurations:
      1. Max98373 as speaker amp and DA7219 headset codec.
      2. Max98373 speaker amp

      Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
      machine driver entries in to machine table.


      BUG=b:73635449
      TEST=Verified sound card binds and spk playback works

      Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
      Signed-off-by: Naveen Manohar <nave...@intel.com>
      Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      ---
      M sound/soc/intel/Kconfig
      M sound/soc/intel/boards/Makefile
      A sound/soc/intel/boards/kbl_da7219_max98373.c
      M sound/soc/intel/skylake/skl.c
      4 files changed, 994 insertions(+), 0 deletions(-)

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 3
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>

      Naveen M (Gerrit)

      unread,
      May 5, 2018, 9:09:29 AM5/5/18
      to Sathyanarayana Nujella, Sathya Prakash M R

      View Change

      1 comment:

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 3
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Comment-Date: Sat, 05 May 2018 13:09:20 +0000

      Sathyanarayana Nujella (Gerrit)

      unread,
      May 25, 2018, 5:39:22 PM5/25/18
      to Sathya Prakash M R, Naveen M

      Sathyanarayana Nujella uploaded patch set #4 to this change.

      View Change

      CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

      This patch adds Kabylake I2S machine driver for the below two configurations:
      1. Max98373 as speaker amp and DA7219 headset codec.
      2. Max98373 speaker amp

      Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
      machine driver entries in to machine table.


      BUG=b:73635449
      TEST=Verified sound card binds and spk playback works

      Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
      Signed-off-by: Naveen Manohar <nave...@intel.com>
      Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      ---
      M sound/soc/intel/Kconfig
      M sound/soc/intel/boards/Makefile
      A sound/soc/intel/boards/kbl_da7219_max98373.c
      M sound/soc/intel/skylake/skl.c
      4 files changed, 999 insertions(+), 0 deletions(-)

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>

      Sathyanarayana Nujella (Gerrit)

      unread,
      May 25, 2018, 5:42:02 PM5/25/18
      to Sathyanarayana Nujella, Naveen M, Sathya Prakash M R

      View Change

      1 comment:

        • There are a set of changes that replaced KEY_MEDIA usage for BTN_0 with KEY_PLAYPAUSE. […]

          Updated. Thanks.

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
      Gerrit-Comment-Date: Fri, 25 May 2018 21:41:58 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Naveen M <nave...@intel.com>
      Gerrit-MessageType: comment

      Naveen M (Gerrit)

      unread,
      May 30, 2018, 11:35:31 PM5/30/18
      to Sathyanarayana Nujella, Ben Zhang, Benson Leung, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

      View Change

      1 comment:

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 4
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
      Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-CC: Benson Leung <ble...@google.com>
      Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
      Gerrit-Comment-Date: Thu, 31 May 2018 03:35:24 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Gerrit-MessageType: comment

      Sathyanarayana Nujella (Gerrit)

      unread,
      Jun 6, 2018, 6:16:39 PM6/6/18
      to Sathya Prakash M R, Naveen M, Benson Leung, Ben Zhang, Grant Grundler, Benson Leung, Sathyanarayana Nujella, Michael W Mason

      Sathyanarayana Nujella uploaded patch set #5 to this change.

      View Change

      CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

      This patch adds Kabylake I2S machine driver for the below two configurations:
      1. Max98373 as speaker amp and DA7219 headset codec.
      2. Max98373 speaker amp

      Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
      machine driver entries in to machine table.


      BUG=b:73635449
      TEST=Verified sound card binds and spk playback works

      Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
      Signed-off-by: Naveen Manohar <nave...@intel.com>
      Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      ---
      M sound/soc/intel/Kconfig
      M sound/soc/intel/boards/Makefile
      A sound/soc/intel/boards/kbl_da7219_max98373.c
      M sound/soc/intel/skylake/skl.c
      4 files changed, 1,002 insertions(+), 0 deletions(-)

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 5
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
      Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
      Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-CC: Benson Leung <ble...@google.com>
      Gerrit-CC: Michael W Mason <michael...@intel.com>
      Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
      Gerrit-MessageType: newpatchset

      Sathyanarayana Nujella (Gerrit)

      unread,
      Jun 6, 2018, 6:16:41 PM6/6/18
      to Grant Grundler, Benson Leung, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

      View Change

      1 comment:

        • Description says in I2S mode, but configured in TDM..

          Updated module_description. Thanks!

      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

      Gerrit-Project: chromiumos/third_party/kernel
      Gerrit-Branch: chromeos-4.4
      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
      Gerrit-Change-Number: 1033465
      Gerrit-PatchSet: 5
      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
      Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
      Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
      Gerrit-Reviewer: Naveen M <nave...@intel.com>
      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
      Gerrit-CC: Benson Leung <ble...@google.com>
      Gerrit-CC: Michael W Mason <michael...@intel.com>
      Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
      Gerrit-Comment-Date: Wed, 06 Jun 2018 22:15:36 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No

      Grant Grundler (Gerrit)

      unread,
      Jun 7, 2018, 1:22:37 PM6/7/18
      to Sathyanarayana Nujella, Grant Grundler, Benson Leung, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

      I took a quick look through this and it looks ok to me - but I'm no expert in audio subsystem. Is there an ETA when this will land upstream?
      Has this been posted upstream?

      Patch set 5:Code-Review +1

      View Change

        To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

        Gerrit-Project: chromiumos/third_party/kernel
        Gerrit-Branch: chromeos-4.4
        Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
        Gerrit-Change-Number: 1033465
        Gerrit-PatchSet: 5
        Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
        Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
        Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
        Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
        Gerrit-Reviewer: Naveen M <nave...@intel.com>
        Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
        Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
        Gerrit-CC: Benson Leung <ble...@google.com>
        Gerrit-CC: Michael W Mason <michael...@intel.com>
        Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
        Gerrit-Comment-Date: Thu, 07 Jun 2018 17:22:27 +0000

        Grant Grundler (Gerrit)

        unread,
        Jun 7, 2018, 1:27:52 PM6/7/18
        to Sathyanarayana Nujella, Grant Grundler, Benson Leung, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

        I forgot to mention: if this has been posted upstream and "pwclient" can list a link to the patch and the upstream conversation, then we can change to "tag" from "CHROMIUM" to "FROMLIST".

        If it looks like upstream maintainer will accept this patch soon, I don't mind waiting to change the tag to "UPSTREAM" as NaveenM was pointing out.

        View Change

          To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

          Gerrit-Project: chromiumos/third_party/kernel
          Gerrit-Branch: chromeos-4.4
          Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
          Gerrit-Change-Number: 1033465
          Gerrit-PatchSet: 5
          Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
          Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
          Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
          Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
          Gerrit-Reviewer: Naveen M <nave...@intel.com>
          Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
          Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
          Gerrit-CC: Benson Leung <ble...@google.com>
          Gerrit-CC: Michael W Mason <michael...@intel.com>
          Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
          Gerrit-Comment-Date: Thu, 07 Jun 2018 17:27:47 +0000

          Grant Grundler (Gerrit)

          unread,
          Jun 7, 2018, 1:36:47 PM6/7/18
          to Sathyanarayana Nujella, Grant Grundler, Benson Leung, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R
          checkpatch is quite unhappy with the whitespace use in this patch:
          WARNING: please, no space before tabs
          #105: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:25:
          +#define KBL_DIALOG_CODEC_DAI ^I"da7219-hifi"$

          WARNING: please, no space before tabs
          #107: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:27:
          +#define MAXIM_DEV0_NAME ^I"i2c-MX98373:00"$
          ...
          ERROR: code indent should use tabs where possible
          #673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
          + .init = kabylake_da7219_fe_init,$

          WARNING: please, no spaces at the start of a line
          #673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
          + .init = kabylake_da7219_fe_init,$

          ERROR: code indent should use tabs where possible
          #674: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:594:
          + .trigger = {$
          ...

          Can you please fix this (and other checkpatch warnings) before submitting upstream?

          View Change

            To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

            Gerrit-Project: chromiumos/third_party/kernel
            Gerrit-Branch: chromeos-4.4
            Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
            Gerrit-Change-Number: 1033465
            Gerrit-PatchSet: 5
            Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
            Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
            Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
            Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
            Gerrit-Reviewer: Naveen M <nave...@intel.com>
            Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
            Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
            Gerrit-CC: Benson Leung <ble...@google.com>
            Gerrit-CC: Michael W Mason <michael...@intel.com>
            Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
            Gerrit-Comment-Date: Thu, 07 Jun 2018 17:36:44 +0000

            Benson Leung (Gerrit)

            unread,
            Jun 7, 2018, 1:38:50 PM6/7/18
            to Sathyanarayana Nujella, Benson Leung, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

            Patch Set 5:

            I forgot to mention: if this has been posted upstream and "pwclient" can list a link to the patch and the upstream conversation, then we can change to "tag" from "CHROMIUM" to "FROMLIST".

            If it looks like upstream maintainer will accept this patch soon, I don't mind waiting to change the tag to "UPSTREAM" as NaveenM was pointing out.

            If the maintainer has it in their tree, but it hasn't been merged by Linus yet, we can use the FROMGIT tag.
            https://www.chromium.org/chromium-os/how-tos-and-troubleshooting/kernel-faq#TOC-UPSTREAM-BACKPORT-FROMLIST-and-you

            View Change

              To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

              Gerrit-Project: chromiumos/third_party/kernel
              Gerrit-Branch: chromeos-4.4
              Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
              Gerrit-Change-Number: 1033465
              Gerrit-PatchSet: 5
              Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
              Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
              Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
              Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
              Gerrit-Reviewer: Naveen M <nave...@intel.com>
              Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
              Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
              Gerrit-CC: Benson Leung <ble...@google.com>
              Gerrit-CC: Michael W Mason <michael...@intel.com>
              Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
              Gerrit-Comment-Date: Thu, 07 Jun 2018 17:38:45 +0000

              Sathyanarayana Nujella (Gerrit)

              unread,
              Jun 7, 2018, 2:02:18 PM6/7/18
              to Grant Grundler, Benson Leung, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

              Patch Set 5: Code-Review+1

              I took a quick look through this and it looks ok to me - but I'm no expert in audio subsystem. Is there an ETA when this will land upstream?
              Has this been posted upstream?

              For Nocturne & Atlas, we are trying different new features like AEC capture & Waves etc. For this, we are anticipating changes in m/c driver. We are in the middle of enabling those new features for these platforms. We believe by end of this month or a week earlier, we will finish enabling those features. As soon as it is done, we will work on upstream and their review comments. So, meanwhile we want to have CPFE enabled with Audio. Thank you.

              View Change

                To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                Gerrit-Project: chromiumos/third_party/kernel
                Gerrit-Branch: chromeos-4.4
                Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                Gerrit-Change-Number: 1033465
                Gerrit-PatchSet: 6
                Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                Gerrit-Reviewer: Naveen M <nave...@intel.com>
                Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                Gerrit-CC: Benson Leung <ble...@google.com>
                Gerrit-CC: Michael W Mason <michael...@intel.com>
                Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                Gerrit-Comment-Date: Thu, 07 Jun 2018 18:02:15 +0000

                Sathyanarayana Nujella (Gerrit)

                unread,
                Jun 7, 2018, 2:03:29 PM6/7/18
                to Grant Grundler, Benson Leung, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                Patch Set 5:

                I forgot to mention: if this has been posted upstream and "pwclient" can list a link to the patch and the upstream conversation, then we can change to "tag" from "CHROMIUM" to "FROMLIST".

                If it looks like upstream maintainer will accept this patch soon, I don't mind waiting to change the tag to "UPSTREAM" as NaveenM was pointing out.

                As soon as it is posted in upstream, we will revert this single patch and post all dependent patches with Tag: UPSTREAM/FROMLIST based on acceptance in upstream. Thank you!

                View Change

                  To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                  Gerrit-Project: chromiumos/third_party/kernel
                  Gerrit-Branch: chromeos-4.4
                  Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                  Gerrit-Change-Number: 1033465
                  Gerrit-PatchSet: 6
                  Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                  Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                  Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                  Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                  Gerrit-Reviewer: Naveen M <nave...@intel.com>
                  Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                  Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                  Gerrit-CC: Benson Leung <ble...@google.com>
                  Gerrit-CC: Michael W Mason <michael...@intel.com>
                  Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                  Gerrit-Comment-Date: Thu, 07 Jun 2018 18:03:26 +0000

                  Sathyanarayana Nujella (Gerrit)

                  unread,
                  Jun 7, 2018, 2:05:05 PM6/7/18
                  to Grant Grundler, Benson Leung, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                  Patch Set 5:

                  checkpatch is quite unhappy with the whitespace use in this patch:
                  WARNING: please, no space before tabs
                  #105: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:25:
                  +#define KBL_DIALOG_CODEC_DAI ^I"da7219-hifi"$

                  WARNING: please, no space before tabs
                  #107: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:27:
                  +#define MAXIM_DEV0_NAME ^I"i2c-MX98373:00"$
                  ...
                  ERROR: code indent should use tabs where possible
                  #673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
                  + .init = kabylake_da7219_fe_init,$

                  WARNING: please, no spaces at the start of a line
                  #673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
                  + .init = kabylake_da7219_fe_init,$

                  ERROR: code indent should use tabs where possible
                  #674: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:594:
                  + .trigger = {$
                  ...

                  Can you please fix this (and other checkpatch warnings) before submitting upstream?

                  Working on fixing this now and will update this patch.
                  From next on-wards, will cross check. Thanks!

                  View Change

                    To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                    Gerrit-Project: chromiumos/third_party/kernel
                    Gerrit-Branch: chromeos-4.4
                    Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                    Gerrit-Change-Number: 1033465
                    Gerrit-PatchSet: 6
                    Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                    Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                    Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                    Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                    Gerrit-Reviewer: Naveen M <nave...@intel.com>
                    Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                    Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                    Gerrit-CC: Benson Leung <ble...@google.com>
                    Gerrit-CC: Michael W Mason <michael...@intel.com>
                    Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                    Gerrit-Comment-Date: Thu, 07 Jun 2018 18:04:59 +0000

                    Sathyanarayana Nujella (Gerrit)

                    unread,
                    Jun 7, 2018, 3:12:05 PM6/7/18
                    to Sathya Prakash M R, Naveen M, Benson Leung, HARSHAPRIYA N, Ben Zhang, Grant Grundler, Benson Leung, Sathyanarayana Nujella, Michael W Mason

                    Sathyanarayana Nujella uploaded patch set #7 to this change.

                    View Change

                    CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

                    This patch adds Kabylake I2S machine driver for the below two configurations:
                    1. Max98373 as speaker amp and DA7219 headset codec.
                    2. Max98373 speaker amp

                    Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
                    machine driver entries in to machine table.


                    BUG=b:73635449
                    TEST=Verified sound card binds and spk playback works

                    Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
                    Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
                    Signed-off-by: Naveen Manohar <nave...@intel.com>
                    Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                    ---
                    M sound/soc/intel/Kconfig
                    M sound/soc/intel/boards/Makefile
                    A sound/soc/intel/boards/kbl_da7219_max98373.c
                    M sound/soc/intel/skylake/skl.c
                    4 files changed, 1,003 insertions(+), 2 deletions(-)

                    To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                    Gerrit-Project: chromiumos/third_party/kernel
                    Gerrit-Branch: chromeos-4.4
                    Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                    Gerrit-Change-Number: 1033465
                    Gerrit-PatchSet: 7
                    Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                    Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                    Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                    Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                    Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                    Gerrit-Reviewer: Naveen M <nave...@intel.com>
                    Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                    Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                    Gerrit-CC: Benson Leung <ble...@google.com>
                    Gerrit-CC: Michael W Mason <michael...@intel.com>
                    Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                    Gerrit-MessageType: newpatchset

                    Sathyanarayana Nujella (Gerrit)

                    unread,
                    Jun 7, 2018, 3:13:57 PM6/7/18
                    to HARSHAPRIYA N, Benson Leung, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                    All checkpatch errors are fixed now. Thanks for review.

                    View Change

                      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                      Gerrit-Project: chromiumos/third_party/kernel
                      Gerrit-Branch: chromeos-4.4
                      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                      Gerrit-Change-Number: 1033465
                      Gerrit-PatchSet: 7
                      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                      Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                      Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                      Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                      Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                      Gerrit-Reviewer: Naveen M <nave...@intel.com>
                      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                      Gerrit-CC: Benson Leung <ble...@google.com>
                      Gerrit-CC: Michael W Mason <michael...@intel.com>
                      Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                      Gerrit-Comment-Date: Thu, 07 Jun 2018 19:13:52 +0000

                      Benson Leung (Gerrit)

                      unread,
                      Jun 7, 2018, 4:18:51 PM6/7/18
                      to Sathyanarayana Nujella, Benson Leung, HARSHAPRIYA N, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                      View Change

                      1 comment:



                        • static struct sst_codecs kbl_7219_98373_codecs = {
                          .num_codecs = 1,
                          .codecs = {"MX98373"}

                        • Why are there two tabs for these lines instead of one?

                      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                      Gerrit-Project: chromiumos/third_party/kernel
                      Gerrit-Branch: chromeos-4.4
                      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                      Gerrit-Change-Number: 1033465
                      Gerrit-PatchSet: 7
                      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                      Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                      Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                      Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                      Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                      Gerrit-Reviewer: Naveen M <nave...@intel.com>
                      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                      Gerrit-CC: Benson Leung <ble...@google.com>
                      Gerrit-CC: Michael W Mason <michael...@intel.com>
                      Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                      Gerrit-Comment-Date: Thu, 07 Jun 2018 20:18:47 +0000
                      Gerrit-HasComments: Yes
                      Gerrit-Has-Labels: No
                      Gerrit-MessageType: comment

                      Sathyanarayana Nujella (Gerrit)

                      unread,
                      Jun 7, 2018, 5:04:31 PM6/7/18
                      to Sathya Prakash M R, Naveen M, Benson Leung, HARSHAPRIYA N, Ben Zhang, Grant Grundler, Benson Leung, Sathyanarayana Nujella, Michael W Mason

                      Sathyanarayana Nujella uploaded patch set #8 to this change.

                      View Change

                      CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

                      This patch adds Kabylake I2S machine driver for the below two configurations:
                      1. Max98373 as speaker amp and DA7219 headset codec.
                      2. Max98373 speaker amp

                      Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
                      machine driver entries in to machine table.


                      BUG=b:73635449
                      TEST=Verified sound card binds and spk playback works

                      Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
                      Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
                      Signed-off-by: Naveen Manohar <nave...@intel.com>
                      Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                      ---
                      M sound/soc/intel/Kconfig
                      M sound/soc/intel/boards/Makefile
                      A sound/soc/intel/boards/kbl_da7219_max98373.c
                      M sound/soc/intel/skylake/skl.c
                      4 files changed, 1,003 insertions(+), 2 deletions(-)

                      To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                      Gerrit-Project: chromiumos/third_party/kernel
                      Gerrit-Branch: chromeos-4.4
                      Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                      Gerrit-Change-Number: 1033465
                      Gerrit-PatchSet: 8
                      Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                      Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                      Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                      Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                      Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                      Gerrit-Reviewer: Naveen M <nave...@intel.com>
                      Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                      Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                      Gerrit-CC: Benson Leung <ble...@google.com>
                      Gerrit-CC: Michael W Mason <michael...@intel.com>
                      Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                      Gerrit-MessageType: newpatchset

                      Sathyanarayana Nujella (Gerrit)

                      unread,
                      Jun 7, 2018, 5:08:11 PM6/7/18
                      to Benson Leung, HARSHAPRIYA N, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                      Patch Set 7:

                      (1 comment)

                      Removed two tabs and kept only one. Yes, not needed. Thanks!

                      View Change

                        To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                        Gerrit-Project: chromiumos/third_party/kernel
                        Gerrit-Branch: chromeos-4.4
                        Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                        Gerrit-Change-Number: 1033465
                        Gerrit-PatchSet: 8
                        Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                        Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                        Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                        Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                        Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                        Gerrit-Reviewer: Naveen M <nave...@intel.com>
                        Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                        Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                        Gerrit-CC: Benson Leung <ble...@google.com>
                        Gerrit-CC: Michael W Mason <michael...@intel.com>
                        Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                        Gerrit-Comment-Date: Thu, 07 Jun 2018 21:06:08 +0000

                        Sathyanarayana Nujella (Gerrit)

                        unread,
                        Jun 7, 2018, 5:08:40 PM6/7/18
                        to Benson Leung, HARSHAPRIYA N, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                        View Change

                        1 comment:

                          • Patch Set #7, Line 1027:

                            	.num_codecs = 1,
                            .codecs = {"MX98357A"}
                            };

                            static struct sst_codecs kbl_7219_98373_codecs = {
                            .num_codecs = 1,
                            .codecs = {"MX98373"}

                            Why are there two tabs for these lines instead of one?

                          • Done

                        To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                        Gerrit-Project: chromiumos/third_party/kernel
                        Gerrit-Branch: chromeos-4.4
                        Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                        Gerrit-Change-Number: 1033465
                        Gerrit-PatchSet: 8
                        Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                        Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                        Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                        Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                        Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                        Gerrit-Reviewer: Naveen M <nave...@intel.com>
                        Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                        Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                        Gerrit-CC: Benson Leung <ble...@google.com>
                        Gerrit-CC: Michael W Mason <michael...@intel.com>
                        Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                        Gerrit-Comment-Date: Thu, 07 Jun 2018 21:07:16 +0000
                        Gerrit-HasComments: Yes
                        Gerrit-Has-Labels: No
                        Comment-In-Reply-To: Benson Leung <ble...@chromium.org>
                        Gerrit-MessageType: comment

                        Benson Leung (Gerrit)

                        unread,
                        Jun 8, 2018, 6:52:28 PM6/8/18
                        to Sathyanarayana Nujella, Benson Leung, HARSHAPRIYA N, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                        Patch set 8:Code-Review +2

                        View Change

                          To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                          Gerrit-Project: chromiumos/third_party/kernel
                          Gerrit-Branch: chromeos-4.4
                          Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                          Gerrit-Change-Number: 1033465
                          Gerrit-PatchSet: 8
                          Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                          Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                          Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                          Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                          Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                          Gerrit-Reviewer: Naveen M <nave...@intel.com>
                          Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                          Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                          Gerrit-CC: Benson Leung <ble...@google.com>
                          Gerrit-CC: Michael W Mason <michael...@intel.com>
                          Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                          Gerrit-Comment-Date: Fri, 08 Jun 2018 22:52:24 +0000

                          Sathyanarayana Nujella (Gerrit)

                          unread,
                          Jun 8, 2018, 7:46:21 PM6/8/18
                          to Benson Leung, HARSHAPRIYA N, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                          Patch set 8:Verified +1Commit-Queue +1

                          View Change

                            To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                            Gerrit-Project: chromiumos/third_party/kernel
                            Gerrit-Branch: chromeos-4.4
                            Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                            Gerrit-Change-Number: 1033465
                            Gerrit-PatchSet: 8
                            Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                            Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                            Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                            Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                            Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                            Gerrit-Reviewer: Naveen M <nave...@intel.com>
                            Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                            Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                            Gerrit-CC: Benson Leung <ble...@google.com>
                            Gerrit-CC: Michael W Mason <michael...@intel.com>
                            Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                            Gerrit-Comment-Date: Fri, 08 Jun 2018 23:45:31 +0000

                            ChromeOS bot (Gerrit)

                            unread,
                            Jun 9, 2018, 12:50:44 AM6/9/18
                            to Sathyanarayana Nujella, Sathya Prakash M R, Naveen M, Benson Leung, HARSHAPRIYA N, Ben Zhang, Grant Grundler, ChromeOS Commit Bot, Benson Leung, Sathyanarayana Nujella, Michael W Mason

                            ChromeOS bot uploaded patch set #9 to the change originally created by Sathyanarayana Nujella.

                            View Change

                            CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver

                            This patch adds Kabylake I2S machine driver for the below two configurations:
                            1. Max98373 as speaker amp and DA7219 headset codec.
                            2. Max98373 speaker amp

                            Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
                            machine driver entries in to machine table.

                            BUG=b:73635449
                            TEST=Verified sound card binds and spk playback works

                            Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
                            Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
                            Signed-off-by: Naveen Manohar <nave...@intel.com>
                            Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                            Reviewed-on: https://chromium-review.googlesource.com/1033465
                            Reviewed-by: Benson Leung <ble...@chromium.org>

                            ---
                            M sound/soc/intel/Kconfig
                            M sound/soc/intel/boards/Makefile
                            A sound/soc/intel/boards/kbl_da7219_max98373.c
                            M sound/soc/intel/skylake/skl.c
                            4 files changed, 1,003 insertions(+), 2 deletions(-)

                            To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                            Gerrit-Project: chromiumos/third_party/kernel
                            Gerrit-Branch: chromeos-4.4
                            Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                            Gerrit-Change-Number: 1033465
                            Gerrit-PatchSet: 9
                            Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                            Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                            Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                            Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                            Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                            Gerrit-Reviewer: Naveen M <nave...@intel.com>
                            Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                            Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                            Gerrit-CC: Benson Leung <ble...@google.com>
                            Gerrit-CC: ChromeOS Commit Bot <chromeos-...@chromium.org>
                            Gerrit-CC: Michael W Mason <michael...@intel.com>
                            Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                            Gerrit-MessageType: newpatchset

                            ChromeOS bot (Gerrit)

                            unread,
                            Jun 9, 2018, 12:50:46 AM6/9/18
                            to Sathyanarayana Nujella, ChromeOS Commit Bot, Benson Leung, HARSHAPRIYA N, Grant Grundler, Michael W Mason, Naveen M, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                            ChromeOS bot merged this change.

                            Gerrit-MessageType: merged

                            Naveen M (Gerrit)

                            unread,
                            Aug 14, 2018, 2:53:02 AM8/14/18
                            to Sathyanarayana Nujella, ChromeOS bot, ChromeOS Commit Bot, Benson Leung, HARSHAPRIYA N, Grant Grundler, Michael W Mason, Ben Zhang, Benson Leung, Sathyanarayana Nujella, Sathya Prakash M R

                            View Change

                            1 comment:

                            • File sound/soc/intel/boards/kbl_da7219_max98373.c:

                              • Patch Set #9, Line 700:

                                [KBL_DPCM_AUDIO_CP] = {
                                .name = "Kbl Audio Capture Port",
                                .stream_name = "Audio Record",
                                .cpu_dai_name = "System Pin",
                                .platform_name = "0000:00:1f.3",
                                .dynamic = 1,
                                .codec_name = "snd-soc-dummy",
                                .codec_dai_name = "snd-soc-dummy-dai",
                                .nonatomic = 1,
                                .trigger = {
                                SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
                                .dpcm_capture = 1,
                                .ops = &kabylake_da7219_fe_ops,
                                }

                                Is this needed for nocturne ?

                            To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.

                            Gerrit-Project: chromiumos/third_party/kernel
                            Gerrit-Branch: chromeos-4.4
                            Gerrit-Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
                            Gerrit-Change-Number: 1033465
                            Gerrit-PatchSet: 9
                            Gerrit-Owner: Sathyanarayana Nujella <sathyanaray...@intel.com>
                            Gerrit-Reviewer: Ben Zhang <be...@chromium.org>
                            Gerrit-Reviewer: Benson Leung <ble...@chromium.org>
                            Gerrit-Reviewer: Grant Grundler <grun...@chromium.org>
                            Gerrit-Reviewer: HARSHAPRIYA N <harsha...@intel.com>
                            Gerrit-Reviewer: Naveen M <nave...@intel.com>
                            Gerrit-Reviewer: Sathya Prakash M R <sathya.pr...@intel.com>
                            Gerrit-Reviewer: Sathyanarayana Nujella <sathyanaray...@intel.com>
                            Gerrit-CC: Benson Leung <ble...@google.com>
                            Gerrit-CC: ChromeOS Commit Bot <chromeos-...@chromium.org>
                            Gerrit-CC: Michael W Mason <michael...@intel.com>
                            Gerrit-CC: Sathyanarayana Nujella <sathyanaray...@intel.corp-partner.google.com>
                            Gerrit-Comment-Date: Tue, 14 Aug 2018 06:52:55 +0000
                            Gerrit-HasComments: Yes
                            Gerrit-Has-Labels: No
                            Gerrit-MessageType: comment