CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver [chromiumos/third_party/kernel : chromeos-4.4]
Sathyanarayana Nujella (Gerrit)
Sathyanarayana Nujella would like Sathya Prakash M R and Naveen M to review this change.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver which uses:
Max98373 as speaker amp and DA7219 headset codec.
Also, adds kabylake kbl_da7219_max98373 machine driver entry
in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 775 insertions(+), 0 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Naveen M (Gerrit)
1 comment:
File sound/soc/intel/skylake/skl.c:
static struct sst_codecs kbl_7219_98373_codecs = {
.num_codecs = 1,
.codecs = {"MX98373"}
};This entry should go as a separate patch..
I understand the patch-set is temporary but once we have the upstream commits for these, we can just update and get it merged.
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
(1 comment)
Yes, thanks. once upstream patches are ready, want to reduce number of patches to revert. So, including all in one.
Naveen M (Gerrit)
Patch set 1:Code-Review +1
Sathyanarayana Nujella (Gerrit)
Sathyanarayana Nujella uploaded patch set #2 to this change.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver which uses:
Max98373 as speaker amp and DA7219 headset codec.
Also, adds kabylake kbl_da7219_max98373 machine driver entry
in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 994 insertions(+), 0 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
Sathyanarayana Nujella uploaded patch set #3 to this change.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver for the below two configurations:
1. Max98373 as speaker amp and DA7219 headset codec.
2. Max98373 speaker amp
Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
machine driver entries in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 994 insertions(+), 0 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Naveen M (Gerrit)
1 comment:
File sound/soc/intel/boards/kbl_da7219_max98373.c:
Patch Set #3, Line 255:
KEY_MEDIAThere are a set of changes that replaced KEY_MEDIA usage for BTN_0 with KEY_PLAYPAUSE. See https://lkml.org/lkml/2017/11/22/586
KEY_MEDIA wont respond any more, please chnage to KEY_PLAYPAUSE
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
Sathyanarayana Nujella uploaded patch set #4 to this change.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver for the below two configurations:
1. Max98373 as speaker amp and DA7219 headset codec.
2. Max98373 speaker amp
Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
machine driver entries in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 999 insertions(+), 0 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
1 comment:
There are a set of changes that replaced KEY_MEDIA usage for BTN_0 with KEY_PLAYPAUSE. […]
Updated. Thanks.
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Naveen M (Gerrit)
1 comment:
File sound/soc/intel/boards/kbl_da7219_max98373.c:
Patch Set #4, Line 957:
in I2S modeDescription says in I2S mode, but configured in TDM..
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
Sathyanarayana Nujella uploaded patch set #5 to this change.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver for the below two configurations:
1. Max98373 as speaker amp and DA7219 headset codec.
2. Max98373 speaker amp
Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
machine driver entries in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 1,002 insertions(+), 0 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
1 comment:
Description says in I2S mode, but configured in TDM..
Updated module_description. Thanks!
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Grant Grundler (Gerrit)
I took a quick look through this and it looks ok to me - but I'm no expert in audio subsystem. Is there an ETA when this will land upstream?
Has this been posted upstream?
Patch set 5:Code-Review +1
Grant Grundler (Gerrit)
I forgot to mention: if this has been posted upstream and "pwclient" can list a link to the patch and the upstream conversation, then we can change to "tag" from "CHROMIUM" to "FROMLIST".
If it looks like upstream maintainer will accept this patch soon, I don't mind waiting to change the tag to "UPSTREAM" as NaveenM was pointing out.
Grant Grundler (Gerrit)
checkpatch is quite unhappy with the whitespace use in this patch:
WARNING: please, no space before tabs
#105: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:25:
+#define KBL_DIALOG_CODEC_DAI ^I"da7219-hifi"$
WARNING: please, no space before tabs
#107: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:27:
+#define MAXIM_DEV0_NAME ^I"i2c-MX98373:00"$
...
ERROR: code indent should use tabs where possible
#673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
+ .init = kabylake_da7219_fe_init,$
WARNING: please, no spaces at the start of a line
#673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
+ .init = kabylake_da7219_fe_init,$
ERROR: code indent should use tabs where possible
#674: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:594:
+ .trigger = {$
...
Can you please fix this (and other checkpatch warnings) before submitting upstream?
Benson Leung (Gerrit)
Patch Set 5:
I forgot to mention: if this has been posted upstream and "pwclient" can list a link to the patch and the upstream conversation, then we can change to "tag" from "CHROMIUM" to "FROMLIST".
If it looks like upstream maintainer will accept this patch soon, I don't mind waiting to change the tag to "UPSTREAM" as NaveenM was pointing out.
If the maintainer has it in their tree, but it hasn't been merged by Linus yet, we can use the FROMGIT tag.
https://www.chromium.org/chromium-os/how-tos-and-troubleshooting/kernel-faq#TOC-UPSTREAM-BACKPORT-FROMLIST-and-you
Sathyanarayana Nujella (Gerrit)
Patch Set 5: Code-Review+1
I took a quick look through this and it looks ok to me - but I'm no expert in audio subsystem. Is there an ETA when this will land upstream?
Has this been posted upstream?
For Nocturne & Atlas, we are trying different new features like AEC capture & Waves etc. For this, we are anticipating changes in m/c driver. We are in the middle of enabling those new features for these platforms. We believe by end of this month or a week earlier, we will finish enabling those features. As soon as it is done, we will work on upstream and their review comments. So, meanwhile we want to have CPFE enabled with Audio. Thank you.
Sathyanarayana Nujella (Gerrit)
Patch Set 5:
I forgot to mention: if this has been posted upstream and "pwclient" can list a link to the patch and the upstream conversation, then we can change to "tag" from "CHROMIUM" to "FROMLIST".
If it looks like upstream maintainer will accept this patch soon, I don't mind waiting to change the tag to "UPSTREAM" as NaveenM was pointing out.
As soon as it is posted in upstream, we will revert this single patch and post all dependent patches with Tag: UPSTREAM/FROMLIST based on acceptance in upstream. Thank you!
Sathyanarayana Nujella (Gerrit)
Patch Set 5:
checkpatch is quite unhappy with the whitespace use in this patch:
WARNING: please, no space before tabs
#105: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:25:
+#define KBL_DIALOG_CODEC_DAI ^I"da7219-hifi"$
WARNING: please, no space before tabs
#107: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:27:
+#define MAXIM_DEV0_NAME ^I"i2c-MX98373:00"$
...
ERROR: code indent should use tabs where possible
#673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
+ .init = kabylake_da7219_fe_init,$
WARNING: please, no spaces at the start of a line
#673: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:593:
+ .init = kabylake_da7219_fe_init,$
ERROR: code indent should use tabs where possible
#674: FILE: sound/soc/intel/boards/kbl_da7219_max98373.c:594:
+ .trigger = {$
...Can you please fix this (and other checkpatch warnings) before submitting upstream?
Working on fixing this now and will update this patch.
From next on-wards, will cross check. Thanks!
Sathyanarayana Nujella (Gerrit)
Sathyanarayana Nujella uploaded patch set #7 to this change.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver for the below two configurations:
1. Max98373 as speaker amp and DA7219 headset codec.
2. Max98373 speaker amp
Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
machine driver entries in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 1,003 insertions(+), 2 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
All checkpatch errors are fixed now. Thanks for review.
Benson Leung (Gerrit)
1 comment:
File sound/soc/intel/skylake/skl.c:
.num_codecs = 1,
.codecs = {"MX98357A"}
};
static struct sst_codecs kbl_7219_98373_codecs = {
.num_codecs = 1,
.codecs = {"MX98373"}
Why are there two tabs for these lines instead of one?
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
Sathyanarayana Nujella uploaded patch set #8 to this change.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver for the below two configurations:
1. Max98373 as speaker amp and DA7219 headset codec.
2. Max98373 speaker amp
Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
machine driver entries in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 1,003 insertions(+), 2 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathyanarayana Nujella (Gerrit)
Patch Set 7:
(1 comment)
Removed two tabs and kept only one. Yes, not needed. Thanks!
Sathyanarayana Nujella (Gerrit)
1 comment:
.num_codecs = 1,
.codecs = {"MX98357A"}
};
static struct sst_codecs kbl_7219_98373_codecs = {
.num_codecs = 1,
.codecs = {"MX98373"}Why are there two tabs for these lines instead of one?
Done
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Benson Leung (Gerrit)
Patch set 8:Code-Review +2
Sathyanarayana Nujella (Gerrit)
Patch set 8:Verified +1Commit-Queue +1
ChromeOS bot (Gerrit)
ChromeOS bot uploaded patch set #9 to the change originally created by Sathyanarayana Nujella.
CHROMIUM: ASoC: Intel: Kbl: Add kabylake Max98373 machine driver
This patch adds Kabylake I2S machine driver for the below two configurations:
1. Max98373 as speaker amp and DA7219 headset codec.
2. Max98373 speaker amp
Also, adds kabylake kbl_da7219_max98373 and kbl_max98373
machine driver entries in to machine table.
BUG=b:73635449
TEST=Verified sound card binds and spk playback works
Signed-off-by: Sathyanarayana Nujella <sathyanaray...@intel.com>
Signed-off-by: Sathya Prakash M R <sathya.pr...@intel.com>
Signed-off-by: Naveen Manohar <nave...@intel.com>
Change-Id: I1d00cb79ca9052d37551c8595148989c1c7f085b
Reviewed-on: https://chromium-review.googlesource.com/1033465
Reviewed-by: Benson Leung <ble...@chromium.org>
---
M sound/soc/intel/Kconfig
M sound/soc/intel/boards/Makefile
A sound/soc/intel/boards/kbl_da7219_max98373.c
M sound/soc/intel/skylake/skl.c
4 files changed, 1,003 insertions(+), 2 deletions(-)
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
ChromeOS bot (Gerrit)
ChromeOS bot merged this change.
Naveen M (Gerrit)
1 comment:
File sound/soc/intel/boards/kbl_da7219_max98373.c:
[KBL_DPCM_AUDIO_CP] = {
.name = "Kbl Audio Capture Port",
.stream_name = "Audio Record",
.cpu_dai_name = "System Pin",
.platform_name = "0000:00:1f.3",
.dynamic = 1,
.codec_name = "snd-soc-dummy",
.codec_dai_name = "snd-soc-dummy-dai",
.nonatomic = 1,
.trigger = {
SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_capture = 1,
.ops = &kabylake_da7219_fe_ops,
}Is this needed for nocturne ?
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.
Sathya Prakash M R (Gerrit)
1 comment:
[KBL_DPCM_AUDIO_CP] = {
.name = "Kbl Audio Capture Port",
.stream_name = "Audio Record",
.cpu_dai_name = "System Pin",
.platform_name = "0000:00:1f.3",
.dynamic = 1,
.codec_name = "snd-soc-dummy",
.codec_dai_name = "snd-soc-dummy-dai",
.nonatomic = 1,
.trigger = {
SND_SOC_DPCM_TRIGGER_POST, SND_SOC_DPCM_TRIGGER_POST},
.dpcm_capture = 1,
.ops = &kabylake_da7219_fe_ops,
}Is this needed for nocturne ?
Thanks for the tip, will submit a fix and take care while posting upstream
To view, visit change 1033465. To unsubscribe, or for help writing mail filters, visit settings.