Re: Modify postinstall to avoid x86-specific dependencies. (issue2742009)
6 views
Skip to first unread message
wfri...@chromium.org
Jun 11, 2010, 8:29:49 PM6/11/10
to pri...@codeaurora.org, chromium-...@chromium.org, cros.ap...@codeaurora.org, pga...@codeaurora.org, robo...@chromium.org
Comments.
http://codereview.chromium.org/2742009/diff/1/2
File chromeos-postinst (right):
http://codereview.chromium.org/2742009/diff/1/2#newcode17
chromeos-postinst:17: ROOT_DEV=echo "${INSTALL_DEV}" | sed
's/p*[0-9]*//g'
Can you source /usr/sbin/chromeos-common.sh and use
ROOT_DEV=$(get_block_dev_from_partition_dev ${INSTALL_DEV}) instead?
That function already solves this problem.
wfri...@chromium.org
Jun 15, 2010, 6:46:01 PM6/15/10
to pri...@codeaurora.org, chromium-...@chromium.org, cros.ap...@codeaurora.org, pga...@codeaurora.org, robo...@chromium.org
Reply all
Reply to author
Forward
0 new messages