Chromiumos-overlay: Enable certain tools for all platforms t... [chromiumos/overlays/chromiumos-overlay : master]

0 views
Skip to first unread message

Wade Guthrie (Code Review)

unread,
May 16, 2012, 1:11:06 PM5/16/12
to Wade Guthrie
Wade Guthrie has uploaded a new change for review.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................

Chromiumos-overlay: Enable certain tools for all platforms they support.

A few of the tools in the chromeos-test-0.1.0.ebuild were marked for
x86-only even though those tools worked on other architectures. This CL
enables those tools on all of the platforms they are marked as
supporting in their own ebuild files.

BUG=None.
TEST=Trybots.

Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
---
R chromeos-base/chromeos-test/chromeos-test-0.1.0-r48.ebuild
M chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild
2 files changed, 4 insertions(+), 4 deletions(-)


git pull ssh://gerrit.chromium.org:29418/chromiumos/overlays/chromiumos-overlay refs/changes/27/22827/1
--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>

Wade Guthrie (Code Review)

unread,
May 16, 2012, 1:12:36 PM5/16/12
to Wade Guthrie
Wade Guthrie has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 1: I would prefer that you didn't submit this

This is for trybot testing. I'll add reviewers when/if it works in that test.

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>
Gerrit-Reviewer: Wade Guthrie <w...@chromium.org>

Wade Guthrie (Code Review)

unread,
May 16, 2012, 2:48:08 PM5/16/12
to Wade Guthrie
Wade Guthrie has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 1: No score

Works in amd64-generic-paladin, x86-generic-paladin, and arm-tegra2-paladin. Ready for review.

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>
Gerrit-Reviewer: Wade Guthrie <w...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 2:51:19 PM5/16/12
to Wade Guthrie, David James, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 1: (1 inline comment)

....................................................
File chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild
Line 73: sys-apps/pciutils
pciutils might still not be useful to ARM. You may want to do as below here.

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Wade Guthrie <w...@chromium.org>
Gerrit-Reviewer: mukesh agrawal <qui...@chromium.org>

mukesh agrawal (Code Review)

unread,
May 16, 2012, 4:16:25 PM5/16/12
to Wade Guthrie, David James, Paul Stewart
mukesh agrawal has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 1: Looks good to me, but someone else must approve

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>

Wade Guthrie (Code Review)

unread,
May 16, 2012, 4:37:28 PM5/16/12
to Wade Guthrie, David James, Richard Barnette, mukesh agrawal, Paul Stewart
Wade Guthrie has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 1: (1 inline comment)

PTAL

....................................................
File chromeos-base/chromeos-test/chromeos-test-0.1.0.ebuild
Line 73: sys-apps/pciutils
Done

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 1
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>
Gerrit-Reviewer: David James <david...@chromium.org>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Richard Barnette <jrbar...@chromium.org>

Paul Stewart (Code Review)

unread,
May 16, 2012, 4:53:47 PM5/16/12
to Wade Guthrie, David James, Richard Barnette, mukesh agrawal
Paul Stewart has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 2: Looks good to me, approved

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>

Wade Guthrie (Code Review)

unread,
May 16, 2012, 4:58:20 PM5/16/12
to Wade Guthrie, David James, Richard Barnette, mukesh agrawal, Paul Stewart
Wade Guthrie has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 2: Verified; Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>

Wade Guthrie (Code Review)

unread,
May 16, 2012, 6:40:06 PM5/16/12
to Wade Guthrie, David James, Richard Barnette, mukesh agrawal, Paul Stewart
Wade Guthrie has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 2: Ready

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>

David James (Code Review)

unread,
May 17, 2012, 4:05:58 PM5/17/12
to Wade Guthrie, Richard Barnette, mukesh agrawal, Paul Stewart
David James has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 2: Looks good to me, but someone else must approve

It looks like you just got unlucky twice... this CL looks fine

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>

Wade Guthrie (Code Review)

unread,
May 18, 2012, 12:27:26 PM5/18/12
to Wade Guthrie, David James, Richard Barnette, mukesh agrawal, Paul Stewart
Wade Guthrie has posted comments on this change.

Change subject: Chromiumos-overlay: Enable certain tools for all platforms they support.
......................................................................


Patch Set 2: Ready

Thanks, David.

--
To view, visit https://gerrit.chromium.org/gerrit/22827
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1c0596c6630abee4845467fdc739e31bc3effc1
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/overlays/chromiumos-overlay
Gerrit-Branch: master
Gerrit-Owner: Wade Guthrie <w...@chromium.org>
Reply all
Reply to author
Forward
0 new messages