Busted "process for contributing" link

[Mark Larson (Google)]

I'm looking for the instructions for how to submit a patch to chromium os.

From http://dev.chromium.org/chromium-os there's a link to "Process for contributing" that leads to http://dev.chromium.org/developers/contributing-code

This page is good for Chromium, but seems out-of-date for Chromium OS. 

Does someone want to take on the task of creating a page relevant for Chromium OS? (Eg, using gerrit instead of gcl and rietveld.)

--Mark

[Mark Larson (Google)]

On a related note...

http://dev.chromium.org/chromium-os/developer-guide/gerrit-guide is totally Googler-ChromeOS-developer centric. 

There's a big red warning to use your chromium.org account for gerrit.chromium.org. What if you don't have a chromium.org account? Either these instructions need to be labeled "FOR GOOGLERS ONLY" or we need to edit them to tell other people how to submit patches for review. 

The root problem is "if someone who's not a committer wants to submit a patch, to what page should I refer them?" If that documentation already exists, it's not easy to find.

--Mark

[Mike Frysinger]

the developer guide covers everything:
http://dev.chromium.org/chromium-os/developer-guide
-mike

[Guillaume Brunerie]

Yes, there is a small paragraph about how non committers should submit a patch in the developer guide, but:

- It is said that patches must be submitted to chromium-os-dev (with an outdated link, by the way). This seems to be false, patches should not be submitted to chromium-os-dev.
- It is not clear that creating a code review on Gerrit is open to anyone (in particular because there are other pages on the wiki insisting about using a @chromium.org account on Gerrit, as Mark noticed)

- I started contributing a few days ago, and I had to run the command

    git config review.gerrit.chromium.org/gerrit.username USERNAME

(where USERNAME is my Gerrit username) to make `repo upload` happy because I do not use the same username as my email address. People with a @chromium.org account are most likely using the same username, but it’s not the case for other people, so this should be explained somewhere.

Guillaume

2011/8/31 Mike Frysinger <vap...@chromium.org>

the developer guide covers everything:
http://dev.chromium.org/chromium-os/developer-guide
-mike

--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en

[Patrick Wenz]

This is what I stumbled across here:
http://groups.google.com/a/chromium.org/group/chromium-os-dev/browse_thread/thread/8892602003fdd7f4/4c9ec5654aaf4c6d?lnk=raot#4c9ec5654aaf4c6d"
Didn't read this post in time. I'd be great if you could clarify on
this stuff.

Regards, Patrick.

On Aug 31, 10:03 am, Guillaume Brunerie <guillaume.brune...@gmail.com>
wrote:

> Yes, there is a small paragraph about how non committers should submit a
> patch in the developer guide, but:
>
> - It is said that patches must be submitted to chromium-os-dev (with an
> outdated link, by the way). This seems to be false, patches should not be
> submitted to chromium-os-dev.
> - It is not clear that creating a code review on Gerrit is open to anyone
> (in particular because there are other pages on the wiki insisting about
> using a @chromium.org account on Gerrit, as Mark noticed)
> - I started contributing a few days ago, and I had to run the command
>     git config review.gerrit.chromium.org/gerrit.username USERNAME
> (where USERNAME is my Gerrit username) to make `repo upload` happy because I
> do not use the same username as my email address. People with a @
> chromium.org account are most likely using the same username, but it’s not
> the case for other people, so this should be explained somewhere.
>
> Guillaume
>
> 2011/8/31 Mike Frysinger <vap...@chromium.org>
>
>
>
>
>
>
>
> > the developer guide covers everything:
> >http://dev.chromium.org/chromium-os/developer-guide
> > -mike
>
> > --

> > Chromium OS Developers mailing list: chromium-os-...@chromium.org

[Mike Frysinger]

On Wed, Aug 31, 2011 at 04:03, Guillaume Brunerie wrote:
> Yes, there is a small paragraph about how non committers should submit a
> patch in the developer guide, but:

you asked for how to submit a patch. i gave you a link to the
details. yes, there is a small section specific to non-committers,
but overall that documentation is the same.

> - It is said that patches must be submitted to chromium-os-dev (with an
> outdated link, by the way).

link works just fine for me
http://groups.google.com/group/chromium-os-dev

> - It is not clear that creating a code review on Gerrit is open to anyone
> (in particular because there are other pages on the wiki insisting about
> using a @chromium.org account on Gerrit, as Mark noticed)
> - I started contributing a few days ago, and I had to run the command
>     git config review.gerrit.chromium.org/gerrit.username USERNAME
> (where USERNAME is my Gerrit username) to make `repo upload` happy because I
> do not use the same username as my email address. People with a
> @chromium.org account are most likely using the same username, but it’s not
> the case for other people, so this should be explained somewhere.

bugs in documentation really should be submitted as a bug
-mike

[Guillaume Brunerie]

Le 31 août 2011 15:45, "Mike Frysinger" <vap...@chromium.org> a écrit :
>
> On Wed, Aug 31, 2011 at 04:03, Guillaume Brunerie wrote:
> > Yes, there is a small paragraph about how non committers should submit a
> > patch in the developer guide, but:
>
> you asked for how to submit a patch.  i gave you a link to the
> details.  yes, there is a small section specific to non-committers,
> but overall that documentation is the same.
>
> > - It is said that patches must be submitted to chromium-os-dev (with an
> > outdated link, by the way).
>
> link works just fine for me
> http://groups.google.com/group/chromium-os-dev

I said "outdated", not that it does not work.
This is the former chromium-os-dev mailing list (look at the dates of the messages), the new one is here:
http://groups.google.com/a/chromium.org/group/chromium-os-dev

> > - It is not clear that creating a code review on Gerrit is open to anyone
> > (in particular because there are other pages on the wiki insisting about
> > using a @chromium.org account on Gerrit, as Mark noticed)
> > - I started contributing a few days ago, and I had to run the command
> >     git config review.gerrit.chromium.org/gerrit.username USERNAME
> > (where USERNAME is my Gerrit username) to make `repo upload` happy because I
> > do not use the same username as my email address. People with a
> > @chromium.org account are most likely using the same username, but it’s not
> > the case for other people, so this should be explained somewhere.
>
> bugs in documentation really should be submitted as a bug

Will do it as soon as I can have Internet on my computer (not before friday), unless someone submit it (or fix it) before.

Guillaume

[Mike Frysinger]

On Wed, Aug 31, 2011 at 10:22, Guillaume Brunerie wrote:

> Le 31 août 2011 15:45, "Mike Frysinger" a écrit :
>> On Wed, Aug 31, 2011 at 04:03, Guillaume Brunerie wrote:
>> > Yes, there is a small paragraph about how non committers should submit a
>> > patch in the developer guide, but:
>>
>> you asked for how to submit a patch.  i gave you a link to the
>> details.  yes, there is a small section specific to non-committers,
>> but overall that documentation is the same.
>>
>> > - It is said that patches must be submitted to chromium-os-dev (with an
>> > outdated link, by the way).
>>
>> link works just fine for me
>> http://groups.google.com/group/chromium-os-dev
>
> I said "outdated", not that it does not work.

a lot of people use "outdated" synchronously with "broken"

> This is the former chromium-os-dev mailing list (look at the dates of the
> messages), the new one is here:

ive updated the page to use the new link, thanks
-mike