chroot install fails in building update_engine-0.0.3-r4048

[scott worley]

Hi,

Non-google person here:

While installing ChromiumOS development environment on a new system (Debian 11 notebook), I am getting an error during chroot build:

update_engine-0.0.3-r4048: #include <kiosk-app/dbus-proxies.h> file not found

Does anyone have a pointer on what may be happening?

Thanks

[Mike Frysinger]

usually this is a parallel build issue.  try emerging system_api by hand and then re-run build_packages.

-mike

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
https://groups.google.com/a/chromium.org/group/chromium-os-dev

[Haouati, Nizar]

Hi Mike,

 

I am also facing the same issue.

I am too Non-google person.

 

After running

repo init -u https://chromium.googlesource.com/chromiumos/manifest.git --repo-url https://chromium.googlesource.com/external/repo.git

repo sync -j8

cros_sdk --enter --no-ns-pid  => cros sdk fail due to update engine

If I try again cros_sdk, then I am able to enter cros_sdk, but still “emerge chromeos-base/update_engine” will fail with same error

>>> 02:21:59 Failed to emerge chromeos-base/update_engine-0.0.3-r4048, Log file:

>>> 02:21:59   /var/log/portage/chromeos-base:update_engine-0.0.3-r4048:20220505-091912.log

…

11:42:07 >>> Compiling source in /var/tmp/portage/chromeos-base/update_engine-0.0.3-r4048/work/update_engine-0.0.3/platform2/update_engine ...

11:42:07.695: INFO: run: ninja -C /var/cache/portage/chromeos-base/update_engine/out/Default -j 4 update_engine:all

…

FAILED: obj/update_engine/cros/libpayload_generator.real_system_state.o

…

In file included from ../../../../../../tmp/portage/chromeos-base/update_engine-0.0.3-r4048/work/update_engine-0.0.3/platform2/update_engine/cros/real_system_state.cc:17:

../../../../../../tmp/portage/chromeos-base/update_engine-0.0.3-r4048/work/update_engine-0.0.3/platform2/update_engine/cros/real_system_state.h:26:10: fatal error: 'kiosk-app/dbus-proxies.h' file not found

#include <kiosk-app/dbus-proxies.h>

         ^~~~~~~~~~~~~~~~~~~~~~~~~~

1 error generated.

 

Full log is attached in file update_engine_fail.log

 

I tried your recommendation to emerging system_api

sudo emerge system_api  => PASS, see attached logs emerge_system_api_then_update_engine.log

then sudo emerge chromeos-base/update_engine fail the same error

 

 

Question:

Is there a way to force in build scripts “-j 1” ?

I couldn’t identify the script that generate build command for “chromeos-base/update_engine” with parallel “-j 4”

if it is the root cause then chromeos-base/update_engine better always force “-j 1” build
12:06:38.328: INFO: run: ninja -C /var/tmp/portage/chromeos-base/system_api-0.0.1-r4711/work/build/out/Default -j 4 system_api:all

 

 

Regards,

Nizar

---
To unsubscribe from this group and stop receiving emails from it, send an email to chromium-os-d...@chromium.org.

[Allen Webb]

I have a fix for that error:
https://chromium-review.googlesource.com/c/aosp/platform/system/update_engine/+/3631018

[scott worley]

Thanks. Still fails with same error. 

Either operator error(me), 10 year old notebook, or OS.  Tried Fedora 35, Ubuntu (disaster), and Debian 10.  No evidence in OS logs of something going wrong. HW tests don't show any issues.

After trying since last Friday, I will try the setup for building ChromiumOS EC firmware outside the chroot environment.  I hope those instructions still work with the new CrOS EC + Zephyr.

[Allen Webb]

For the fix to apply the ebuild needs to be upgraded, we have some workflows for taking care of that when doing local development, but it might be easiest to wait for the fix to land.

If you do not want to wait, you need to use the "cros-workon start" script for update_engine.

[Haouati, Nizar]

Hi Allen,

 

I cherry-picked your CL 3631018

cros_workon --host start chromeos-base/update_engine

then sudo emerge chromeos-base/update_engine

Still failing the same error

 

I verified that it is emerging the src code +CL 3631018 (update_engine-9999) rather overlay (update_engine-0.0.3-r4048 specific commit ID)

>>> 15:13:14 Emerging (1 of 1) chromeos-base/update_engine-9999::chromiumos

…

15:13:18.951: INFO: run: ninja -C /var/cache/portage/chromeos-base/update_engine/out/Default -j 4 update_engine:all

…

In file included from ../../../../../../tmp/portage/chromeos-base/update_engine-9999/work/update_engine-9999/platform2/update_engine/cros/real_system_state.cc:17:

../../../../../../tmp/portage/chromeos-base/update_engine-9999/work/update_engine-9999/platform2/update_engine/cros/real_system_state.h:26:10: fatal error: 'kiosk-app/dbus-proxies.h' file not found

#include <kiosk-app/dbus-proxies.h>

 

Do you now a way to force 1 build instance “-j 1” of update_engine to check Mike hypothese about // build “-j 4” ?

 

Regards,

Nizar

 

From: 'Allen Webb' via Chromium OS Development <chromiu...@chromium.org>
Sent: Thursday, May 5, 2022 1:13 PM
To: scott worley <dsw...@gmail.com>
Cc: Chromium OS Development <chromiu...@chromium.org>
Subject: Re: [cros-dev] chroot install fails in building update_engine-0.0.3-r4048

 

For the fix to apply the ebuild needs to be upgraded, we have some workflows for taking care of that when doing local development, but it might be easiest to wait for the fix to land.

[Allen Webb]

I wasn't able to reproduce the error locally, but it did show up in our build infrastructure. Tomorrow I will take a closer look at the error message and see if I need to adjust my fix to cover targets that are still missing the pkg_dep.

[Allen Webb]

I am still not able to reproduce the issue. One problem that might be related is we recently upgraded dev-cpp/abseil-cpp which has >100 pkgconfig files with 8 redundant Cflags which amount to >800 command line parameters. I have a patch that excludes those CFLAGS from everything except absl_config (which the other sub libraries require):
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3630468

In my most recent test run the missing dbus-proxies.h errors went away, so there might be some kind of flag overflow going on. It is really hard to say what the underlying cause is unless I can get a local setup that reproduces the issue and investigate the cause.

[Haouati, Nizar]

I tried also CFLAGS CL https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/3630468

it didn’t work, same update_engine failure.

With Allen suggestion, I created bug https://issuetracker.google.com/231691000 cros_sdk creation fails in building update_engine-0.0.3-r4048

To record this issue and keep track of debugging trials record.

[Allen Webb]

There was a missing dependency in the BUILD.gn leading to a race. The fix is here: https://crrev.com/c/3632632

The bug was introduced in November of 2020.

[Haouati, Nizar]

I confirm the resolution of the issue with https://crrev.com/c/3632632

You can try Scott cherrypick CL on your system.

cros_workon --host start chromeos-base/update_engine

sudo emerge chromeos-base/update_engine

 

Just a note to explain:

Depending on the host machine CPU thread number capable, you may fall or not into this // build race issue

libpayload_generator was missing the update_engine-dbus-kiosk-app- dependency client

but in case you have other // build thread that build execute update_engine-dbus-kiosk-app-client in advance to libpayload_generator => then you will not face the issue !

[scott worley]

Hi Nizar,

Thanks for the info.

I checked CL and it was merged.  Started the development environment install from scratch and everything built.

Thanks Alan for fixing this!