Simple Chrome workflow is not applying some ebuild patches

[Simon Que]

Hi,

I am having trouble with building Chrome using the Simple Chrome workflow. There are some patches that are not being applied and it results in a compile error. See below.

It's possible that my environment is out of date but I sync'ed both Chrome and Chrome OS recently.

Simon

---------- Forwarded message ----------
From: Caroline Tice <cmt...@google.com>
Date: Wed, Oct 28, 2015 at 2:18 PM
Subject: Re: [chromium-dev] Compile errors in Chrome GPU code (DRM_FORMAT_MT21, V4L2_EVENT_SRC_CH_PIXELFORMAT)
To: sq...@chromium.org


I found the definition for DRM_FORMAT_M21; it appears to be in a patch
we apply in ChromeOS

src/third_party/chromiumos-overlay/x11-libs/libdrm/files/drm_mediatek-0003-Add-Mediatek-proprietary-formats.patch:

From db2a5b48c410628e5a654293b650f87391b3925a Mon Sep 17 00:00:00 2001
From: Chiawen Lee <chiaw...@mediatek.com>
Date: Wed, 18 Mar 2015 10:14:39 +0800
Subject: [PATCH 5/6] Add Mediatek proprietary formats

Add DRM_FORMAT_MT12 and DRM_FORMAT_MT21 for Mediatek Properity
video block format

Signed-off-by: Chiawen Lee <chiaw...@mediatek.com>
---
 include/drm/drm_fourcc.h | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/include/drm/drm_fourcc.h b/include/drm/drm_fourcc.h
index 63a80ca..59d3f87 100644
--- a/include/drm/drm_fourcc.h
+++ b/include/drm/drm_fourcc.h
@@ -107,6 +107,9 @@
 #define DRM_FORMAT_NV16 fourcc_code('N', 'V', '1', '6') /* 2x1
subsampled Cr:Cb plane */
 #define DRM_FORMAT_NV61 fourcc_code('N', 'V', '6', '1') /* 2x1
subsampled Cb:Cr plane */

+#define DRM_FORMAT_MT12 fourcc_code('M', 'T', '1', '2') /* Mediatek
Block Mode */
+#define DRM_FORMAT_MT21 fourcc_code('M', 'T', '2', '1') /* Mediatek
Block Mode */
+
 /*
  * 3 plane YCbCr
  * index 0: Y plane, [7:0] Y
--
2.1.2



My guess is that somehow the patch(es) is (are) failing to be properly
applied in the simple chrome workflow...


-- Caroline
cmt...@google.com

On Wed, Oct 28, 2015 at 2:13 PM, Simon Que <sq...@chromium.org> wrote:
> I'm getting some build errors in the GPU code for Chrome:
>
> ../../content/common/gpu/media/v4l2_device.cc:113:14: error:
> 'DRM_FORMAT_MT21' was not declared in this scope
>        return DRM_FORMAT_MT21;
> ../../content/common/gpu/media/v4l2_jpeg_decode_accelerator.cc:521:43:
> error: 'V4L2_EVENT_SRC_CH_PIXELFORMAT' was not declared in this scope
>            (V4L2_EVENT_SRC_CH_RESOLUTION | V4L2_EVENT_SRC_CH_PIXELFORMAT)) {
>
> I'm using the simple chrome workflow for Chrome OS (go/simplechrome), but
> this is not Chrome OS-specific code.
>
> I can't find either of these identifiers using Chromium CodeSearch.
>
> Simon
>

> --
> --
> Chromium Developers mailing list: chromi...@chromium.org
> View archives, change email options, or unsubscribe:
> http://groups.google.com/a/chromium.org/group/chromium-dev

[Mike Frysinger]

by design, Simple Chrome does not apply patches.  it builds the source in your source checkout and that is it.  if you want custom patches you'll need to apply them yourself.

as for patches to sysroot libraries, make sure your tree is up to date and you aren't forcing an older version.

if things still aren't working, please post the actual commands you're running including the output.  that includes the `cros chrome-sdk` command.

-mike

--
--
Chromium OS Developers mailing list: chromiu...@chromium.org

View archives, change email options, or unsubscribe:

http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en

[Simon Que]

I see the problem. The patches were applied to my Chrome OS chroot, but I didn't run "gclient runhooks" after entering the chrome-sdk chroot with --chroot pointing to my local chroot, so it was using include paths from the chrome-sdk tarball. Now it works.