Building Chromium in Chromium OS with CHROME_ORIGIN set

[Jonathan Kliegman]

If you don't build Chromium in Chromium OS by setting CHROME_ORIGIN you can ignore the rest of this message.  I've also sent this to both Chromium and Chromium OS mailing lists so please remove the one you aren't on when responding if you want to avoid bounces.

I've made a change to how build_packages works when building Chromium in Chrome OS. 

Previously if you set CHROME_ORIGIN you had to manually emerge chromeos-chrome (or set flags in files such as package.mask).  With this change you can call build_packages directly and it will properly emerge Chromium according to the value in CHROME_ORIGIN.

For more details you can see the CL at:

http://codereview.chromium.org/3555017/show

I'll be checking this in shortly (Thursday so people have a day to review/think about this).  I first wanted to make sure there weren't any objections or that this change would break anyones workflow if it went live.  

-Jon

[Greg Spencer]

Yay!  Thanks for this.

-Greg.

--
Chromium OS Developers mailing list: chromiu...@chromium.org
View archives, change email options, or unsubscribe:
http://groups.google.com/a/chromium.org/group/chromium-os-dev?hl=en

[Anton Vayvod]

I thought it worked for me for weeks already.

I do the following:

./enter_chroot.sh --chrome_root=...

declare -x CHROME_ORIGIN=LOCAL_SOURCE  // this is in .bashrc of chroot

./build_packages --fast --jobs 25 --retries=3 --nowithautotest --nowithtest

And it worked, at least last week. Is this change about something else (i.e. "export CHROME_ORIGIN=LOCAL_SOURCE" seemed to not work for build_packages)?

Thanks!

--

[Jonathan Kliegman]

Most of the time what you did would use the prebuilt binary for Chrome, not a local build.  There could be cases where it would do what you want but those required other things to be setup which people weren't aware of.

If you want to check that you actually built chrome locally, you can validate by going to your chrome_root directory and looking for a ${board}_out directory where it built your code.  

-Jon

[Jonathan Kliegman]

This CL has just been pushed. Thanks for all on the feedback and comments.

-Jon