CHROMIUM: iwl7000: disable U-APSD by default [chromiumos/third_party/kernel-next : chromeos-3.10]

[chrome-internal-fetch (Gerrit)]

chrome-internal-fetch has submitted this change and it was merged.

Change subject: CHROMIUM: iwl7000: disable U-APSD by default
......................................................................


CHROMIUM: iwl7000: disable U-APSD by default

With a significant number of deployed APs, enabling U-APSD leads to the
AP never using aggregation sessions (likely due to the complexities
involved in handling U-APSD in those.) This obviously results in a large
drop in throughput with such APs.

On the other hand, U-APSD can result in some power consumption benefits,
but for now just disable it to get performance with affected APs back
up.

BUG=chrome-os-partner:31397
TEST=connect to Aruba network and check download speed

Change-Id: Ie1fd35f660a33f323394d3afa699e5a5c7185234
Signed-off-by: Johannes Berg <johann...@intel.com>
Reviewed-on: https://chromium-review.googlesource.com/215882
Reviewed-by: Paul Stewart <ps...@chromium.org>
Commit-Queue: Paul Stewart <ps...@chromium.org>
Tested-by: Paul Stewart <ps...@chromium.org>
---
M drivers/net/wireless-3.8/iwl7000/iwlwifi/iwl-drv.c
1 file changed, 7 insertions(+), 1 deletion(-)

Approvals:
Paul Stewart: Looks good to me, approved; Ready; Verified



diff --git a/drivers/net/wireless-3.8/iwl7000/iwlwifi/iwl-drv.c
b/drivers/net/wireless-3.8/iwl7000/iwlwifi/iwl-drv.c
index 4c5df92..ced72c2 100644
--- a/drivers/net/wireless-3.8/iwl7000/iwlwifi/iwl-drv.c
+++ b/drivers/net/wireless-3.8/iwl7000/iwlwifi/iwl-drv.c
@@ -1497,7 +1497,9 @@
.bt_coex_active = true,
.power_level = IWL_POWER_INDEX_1,
.wd_disable = true,
- .uapsd_disable = false,
+#ifndef CPTCFG_IWLWIFI_UAPSD
+ .uapsd_disable = true,
+#endif /* CPTCFG_IWLWIFI_UAPSD */
/* the rest are 0 by default */
};
IWL_EXPORT_SYMBOL(iwlwifi_mod_params);
@@ -1670,7 +1672,11 @@

module_param_named(uapsd_disable, iwlwifi_mod_params.uapsd_disable,
bool, S_IRUGO);
+#ifdef CPTCFG_IWLWIFI_UAPSD
MODULE_PARM_DESC(uapsd_disable, "disable U-APSD functionality (default:
N)");
+#else
+MODULE_PARM_DESC(uapsd_disable, "disable U-APSD functionality (default:
Y)");
+#endif

/*
* set bt_coex_active to true, uCode will do kill/defer

--
To view, visit https://chromium-review.googlesource.com/215882
To unsubscribe, visit https://chromium-review.googlesource.com/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie1fd35f660a33f323394d3afa699e5a5c7185234
Gerrit-PatchSet: 2
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.10
Gerrit-Owner: Johannes Berg <johann...@intel.com>
Gerrit-Reviewer: Johannes Berg <johann...@intel.com>
Gerrit-Reviewer: Paul Stewart <ps...@chromium.org>
Gerrit-Reviewer: Sameer Nanda <sna...@chromium.org>
Gerrit-Reviewer: chrome-internal-fetch <chrome-int...@google.com>