CHROMIUM: cpuset: initialize requested cpus for root to possible_cpus [chromiumos/third_party/kernel : release-R83-13020.B-chromeos-3.18]
7 views
Skip to first unread message
Commit Bot (Gerrit)
Apr 8, 2020, 9:33:14 AM4/8/20
to Sonny Rao, Kazuhiro Inaba
Commit Bot submitted this change.
Approvals:
Kazuhiro Inaba: Looks good to me, approved; Commit; Verified; Send CL to CQ automatically after approval
CHROMIUM: cpuset: initialize requested cpus for root to possible_cpus
The previous commits which retained cpuset across hotplug events
weren't properly initializing the requested cpuset for the root
cpuset. This later caused issues on systems which only had two
possible cpus instead of four possible, where no tasks could be added
because child cpusets weren't properly identified as belonging to the
root.
BUG=b:153224277
TEST=boot, check that /sys/fs/cgroup/cpuset/chrome/tasks is populated
Signed-off-by: Sonny Rao <sonn...@chromium.org>
Change-Id: If7dbe4b0f7f85bfadeb78093808fddd579fa8f3b
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2138721
Reviewed-by: Joel Fernandes <joe...@google.com>
(cherry picked from commit cfb6e7219ecfb2e559a35799bc9c81220d8c446b)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/2141575
Reviewed-by: Kazuhiro Inaba <kin...@chromium.org>
Commit-Queue: Kazuhiro Inaba <kin...@chromium.org>
Tested-by: Kazuhiro Inaba <kin...@chromium.org>
Auto-Submit: Kazuhiro Inaba <kin...@chromium.org>
---
M kernel/cpuset.c
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/cpuset.c b/kernel/cpuset.c
index aeb2dcb..db9d216 100644
--- a/kernel/cpuset.c
+++ b/kernel/cpuset.c
@@ -2093,7 +2093,7 @@
BUG();
cpumask_setall(top_cpuset.cpus_allowed);
- cpumask_setall(top_cpuset.cpus_requested);
+ cpumask_copy(top_cpuset.cpus_requested, cpu_possible_mask);
nodes_setall(top_cpuset.mems_allowed);
cpumask_setall(top_cpuset.effective_cpus);
nodes_setall(top_cpuset.effective_mems);
To view, visit change 2141575. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages