UPSTREAM: ARM: EXYNOS: fix compilation error introduced due ... [chromiumos/third_party/kernel-next : chromeos-3.8]

1 view
Skip to first unread message

Doug Anderson (Code Review)

unread,
May 21, 2013, 10:13:17 PM5/21/13
to Arun Kumar K, Thomas Abraham, ChromeBot, Prashanth Godrehal, Alim Akhtar, Sunil Mazhavanchery, Abhilash Kesavan
Doug Anderson has submitted this change and it was merged.

Change subject: UPSTREAM: ARM: EXYNOS: fix compilation error introduced due to common clock migration
......................................................................


UPSTREAM: ARM: EXYNOS: fix compilation error introduced due to common clock migration

The functions exynos4_clk_init and exynos4_clk_register_fixed_ext
are applicable only on Exynos4 non-dt platforms. But when building
Exynos5 platforms without including Exynos4 platforms, the following
errors show up.

arch/arm/mach-exynos/built-in.o: In function `exynos_init_time':
arch/arm/mach-exynos/common.c:446: undefined reference to `exynos4_clk_init'
arch/arm/mach-exynos/common.c:447: undefined reference to `exynos4_clk_register_fixed_ext'

Fix this compilation errors by marking these calls as Exynos4 specific.

BUG=chrome-os-partner:19183
TEST=Built and booted snow board and saw login screen

Signed-off-by: Thomas Abraham <thom...@samsung.com>
Signed-off-by: Kukjin Kim <kgen...@samsung.com>
(cherry picked from commit 296f3f2c9322480400338f71d8c118107f9a7f20)

Change-Id: I0346ff848294dd217a5ca43a1ff7647f7cf9025b
Reviewed-on: https://gerrit.chromium.org/gerrit/50650
Reviewed-by: Doug Anderson <dian...@chromium.org>
Tested-by: Doug Anderson <dian...@chromium.org>
Commit-Queue: Doug Anderson <dian...@chromium.org>
---
M arch/arm/mach-exynos/common.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
Doug Anderson: Looks good to me, approved; Ready; Verified


--
To view, visit https://gerrit.chromium.org/gerrit/50650
To unsubscribe, visit https://gerrit.chromium.org/gerrit/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0346ff848294dd217a5ca43a1ff7647f7cf9025b
Gerrit-PatchSet: 11
Gerrit-Project: chromiumos/third_party/kernel-next
Gerrit-Branch: chromeos-3.8
Gerrit-Owner: Arun Kumar K <aru...@samsung.com>
Gerrit-Reviewer: Abhilash Kesavan <a.ke...@samsung.com>
Gerrit-Reviewer: Alim Akhtar <alim....@samsung.com>
Gerrit-Reviewer: ChromeBot <chrom...@google.com>
Gerrit-Reviewer: Doug Anderson <dian...@chromium.org>
Gerrit-Reviewer: Prashanth Godrehal <prash...@samsung.com>
Gerrit-Reviewer: Sunil Mazhavanchery <sun...@samsung.com>
Gerrit-Reviewer: Thomas Abraham <thom...@samsung.com>
Reply all
Reply to author
Forward
0 new messages