Fix proto loading for local scripts. [chromiumos/config : master]

5 views

Skip to first unread message

Commit Bot (Gerrit)

unread,

Apr 8, 2020, 10:53:16 AM4/8/20

to David Burger, Andrew Lamb

Commit Bot submitted this change.

Approvals:
  Andrew Lamb: Looks good to me, approved; Commit; Verified
  David Burger: Send CL to CQ automatically after approval

Fix proto loading for local scripts.

Fix proto loading for local scripts as the protos blow chunks if
referenced before registered, for example:

$ pwd
/usr/local/google/home/dburger/chromiumos/src/project/zork/dalboz
dburger@wildcat$ gen_config config.star
[P242943 07:12:28.612 generate.go:94 I] Generating configs...
Traceback (most recent call last):
  //config.star:3:1: in <toplevel>
Error: cannot load //config/util/config_bundle.star: Traceback (most recent call last):
  //config/util/config_bundle.star:6:1: in <toplevel>
Error: cannot load @proto//payload/config_bundle.proto: loading
payload/config_bundle.proto: proto: not found

BUG=None
TEST=gen_config config.star in a project

Change-Id: Icfbbe42083cd48c705a3f6cd02f12566a40a4044
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/config/+/2142160
Auto-Submit: David Burger <dbu...@chromium.org>
Reviewed-by: Andrew Lamb <andre...@chromium.org>
Commit-Queue: Andrew Lamb <andre...@chromium.org>
Tested-by: Andrew Lamb <andre...@chromium.org>
---
M util/brand_config.star
M util/build_target.star
M util/component.star
M util/config_bundle.star
M util/design.star
M util/device_brand.star
M util/hw_topology.star
M util/partner.star
M util/program.star
M util/sw_config.star
10 files changed, 35 insertions(+), 25 deletions(-)

To view, visit change 2142160. To unsubscribe, or for help writing mail filters, visit settings.

Reply all

Reply to author

Forward

0 new messages