pd_faft: ensure servo v4 and servo micro setup [chromiumos/third_party/autotest : master]

[Commit Bot (Gerrit)]

Commit Bot submitted this change.

View Change

Approvals: Wai-Hong Tam: Looks good to me, approved Eric Yilun Lin: Commit; Verified

pd_faft: ensure servo v4 and servo micro setup

Servo v4 and servo micro is mandantory for PD FAFT.

BUG=b:146025802
TEST=Ensure the setup is checked.

Change-Id: I965dabccc4ae9789557ca1bcf00410c81ac5fce2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/autotest/+/2124167
Tested-by: Eric Yilun Lin <yl...@chromium.org>
Reviewed-by: Wai-Hong Tam <wai...@google.com>
Commit-Queue: Eric Yilun Lin <yl...@chromium.org>
---
M server/cros/faft/firmware_test.py
1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/server/cros/faft/firmware_test.py b/server/cros/faft/firmware_test.py
index 7257dec..f7870a6 100644
--- a/server/cros/faft/firmware_test.py
+++ b/server/cros/faft/firmware_test.py
@@ -499,13 +499,21 @@
 
         self.mark_setup_done('usb_check')
 
-    def setup_pdtester(self, flip_cc=False, dts_mode=False):
+    def setup_pdtester(self, flip_cc=False, dts_mode=False, pd_faft=True):
         """Setup the PDTester to a given state.
 
         @param flip_cc: True to flip CC polarity; False to not flip it.
         @param dts_mode: True to config PDTester to DTS mode; False to not.
+        @param pd_faft: True to config PD FAFT setup.
         @raise TestError: If Servo v4 not setup properly.
         """
+
+        # PD FAFT is only tested with servo V4 with servo micro.
+        if pd_faft and self.pdtester.servo_type != 'servo_v4_with_servo_micro':
+            raise error.TestError('servo_v4_with_servo_micro is a mandatory '
+                                  'setup for PD FAFT. Got %s.'
+                                  % self.pdtester.servo_type)
+
         # Servo v4 by default has dts_mode enabled. Enabling dts_mode affects
         # the behaviors of what PD FAFT tests. So we want it disabled.
         if 'servo_v4' in self.pdtester.servo_type:

To view, visit change 2124167. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/third_party/autotest

Gerrit-Branch: master

Gerrit-Change-Id: I965dabccc4ae9789557ca1bcf00410c81ac5fce2

Gerrit-Change-Number: 2124167

Gerrit-PatchSet: 2

Gerrit-Owner: Eric Yilun Lin <yl...@chromium.org>

Gerrit-Reviewer: Commit Bot <commi...@chromium.org>

Gerrit-Reviewer: Eric Yilun Lin <yl...@chromium.org>

Gerrit-Reviewer: Wai-Hong Tam <wai...@google.com>

Gerrit-MessageType: merged