CRAS: Fix undefined reference in {audio_thread,timing}_unittest [chromiumos/third_party/adhd : master]

0 views
Skip to first unread message

Commit Bot (Gerrit)

unread,
Apr 8, 2020, 9:30:26 AM4/8/20
to Chih-Yang Hsia, Hsinyu Chao, Cheng-Yi Chiang

Commit Bot submitted this change.

View Change

Approvals: Hsinyu Chao: Looks good to me, approved Chih-Yang Hsia: Commit; Verified
CRAS: Fix undefined reference in {audio_thread,timing}_unittest

Build fails from
a563d702d439fdcef7fe8259a959604a73101d3a

BUG=None
TEST=Run commands under adhd/cras
CC=clang CXX=clang++ ./configure
make -j$(nproc) check

Change-Id: I990e0e9017412418222b17a1c5a1754980b0d8d1
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/2141574
Reviewed-by: Hsinyu Chao <hyc...@chromium.org>
Commit-Queue: Chih-Yang Hsia <paul...@chromium.org>
Tested-by: Chih-Yang Hsia <paul...@chromium.org>
---
M cras/src/tests/audio_thread_unittest.cc
M cras/src/tests/timing_unittest.cc
2 files changed, 11 insertions(+), 0 deletions(-)

diff --git a/cras/src/tests/audio_thread_unittest.cc b/cras/src/tests/audio_thread_unittest.cc
index 74fd2cd..0280a1e 100644
--- a/cras/src/tests/audio_thread_unittest.cc
+++ b/cras/src/tests/audio_thread_unittest.cc
@@ -1444,6 +1444,11 @@
return 0;
}

+float input_data_get_software_gain_scaler(struct input_data* data,
+ float idev_sw_gain_scaler,
+ struct cras_rstream* stream) {
+ return 1.0;
+}
} // extern "C"

int main(int argc, char** argv) {
diff --git a/cras/src/tests/timing_unittest.cc b/cras/src/tests/timing_unittest.cc
index 0033217..087c93d 100644
--- a/cras/src/tests/timing_unittest.cc
+++ b/cras/src/tests/timing_unittest.cc
@@ -1163,6 +1163,12 @@
return 0;
}

+float input_data_get_software_gain_scaler(struct input_data* data,
+ float idev_sw_gain_scaler,
+ struct cras_rstream* stream) {
+ return 1.0;
+}
+
struct cras_audio_format* cras_rstream_post_processing_format(
const struct cras_rstream* stream,
void* dev_ptr) {

To view, visit change 2141574. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/third_party/adhd
Gerrit-Branch: master
Gerrit-Change-Id: I990e0e9017412418222b17a1c5a1754980b0d8d1
Gerrit-Change-Number: 2141574
Gerrit-PatchSet: 4
Gerrit-Owner: Chih-Yang Hsia <paul...@chromium.org>
Gerrit-Reviewer: Cheng-Yi Chiang <cych...@chromium.org>
Gerrit-Reviewer: Chih-Yang Hsia <paul...@chromium.org>
Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
Gerrit-Reviewer: Hsinyu Chao <hyc...@chromium.org>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages