smbfs: Request credentials on authentication failure [chromiumos/platform2 : master]
23 views
Skip to first unread message
Commit Bot (Gerrit)
Apr 8, 2020, 12:15:17 PM4/8/20
to Anand Mistry, Sergei Datsenko, Tricium, Josh Simmons
Commit Bot submitted this change.
Approvals:
Sergei Datsenko: Looks good to me, approved
Anand Mistry: Commit; Verified
smbfs: Request credentials on authentication failure
In some situations, such as policy pre-configured shares, the SMB share
is mounted without authentication credentials. When the share is
accessed and fails with an authentication error, credentials must be
requested from the user. The SmbFsDelegate, provided by the
browser at mount time, is used to request those credentials.
If the SMB share has been successfully queried at least once, don't
request credentials since it is assumed the current ones are correct.
Also don't request credentials if Kerberos is being used, since Kerberos
credentials are derived from profile information which is assumed to be
correct at mount time.
BUG=chromium:1054704
TEST=cros_run_unit_tests --board=chell --packages smbfs
TEST=Enable smbfs and define an enterprise policy with a preconfigured
SMB share that requires user/password. Open Files App and browse
preconfigured share. User should be requested for
username/password.
Change-Id: Ide76a97a32f886e815649c6493041143ad4ae11e
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2136980
Tested-by: Anand Mistry <ami...@chromium.org>
Commit-Queue: Anand Mistry <ami...@chromium.org>
Reviewed-by: Sergei Datsenko <da...@chromium.org>
---
M smbfs/mojo_session.cc
M smbfs/mojo_session.h
M smbfs/mojom/smbfs.mojom
M smbfs/smb_filesystem.cc
M smbfs/smb_filesystem.h
M smbfs/smb_filesystem_test.cc
M smbfs/smbfs_bootstrap_impl_test.cc
M smbfs/smbfs_daemon.cc
8 files changed, 305 insertions(+), 21 deletions(-)
To view, visit change 2136980. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages