wificell: router: Port rng_configure from Autotest. [chromiumos/platform/tast-tests : master]

4 views
Skip to first unread message

Commit Bot (Gerrit)

unread,
Apr 8, 2020, 8:52:04 AM4/8/20
to Yen-lin Lai, Brian Norris, Keigo Oka, Shuo-Peng Liao

Commit Bot submitted this change.

View Change

Approvals: Shuo-Peng Liao: Looks good to me, approved Brian Norris: Looks good to me, approved Keigo Oka: Looks good to me, approved Yen-lin Lai: Commit; Verified
wificell: router: Port rng_configure from Autotest.

In Autotest, we select tpm-rng if available to avoid "Not enough
entropy" problem of on-chip rng in Gale.
(original cl: crrev.com/c/1162969)

Also port the logic to Tast.

BUG=chromium:1034875,chromium:774808
TEST=`tast run $DUT wifi.SimpleConnect\*` and then `cat
/sys/class/misc/hw_random/rng_current` to see if the router is using
tpm-rng.

Change-Id: I069e7e1009a77be999960483664fcdcc653fff1c
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast-tests/+/2119773
Tested-by: Yen-lin Lai <yenl...@google.com>
Commit-Queue: Yen-lin Lai <yenl...@google.com>
Reviewed-by: Brian Norris <brian...@chromium.org>
Reviewed-by: Keigo Oka <o...@chromium.org>
Reviewed-by: Shuo-Peng Liao <dean...@chromium.org>
---
M src/chromiumos/tast/remote/wificell/fileutil/utils.go
M src/chromiumos/tast/remote/wificell/router.go
2 files changed, 82 insertions(+), 1 deletion(-)


To view, visit change 2119773. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform/tast-tests
Gerrit-Branch: master
Gerrit-Change-Id: I069e7e1009a77be999960483664fcdcc653fff1c
Gerrit-Change-Number: 2119773
Gerrit-PatchSet: 10
Gerrit-Owner: Yen-lin Lai <yenl...@google.com>
Gerrit-Reviewer: Brian Norris <brian...@chromium.org>
Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
Gerrit-Reviewer: Keigo Oka <o...@chromium.org>
Gerrit-Reviewer: Shuo-Peng Liao <dean...@chromium.org>
Gerrit-Reviewer: Yen-lin Lai <yenl...@google.com>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages