tast: Remove android_all SoftwareDep support [chromiumos/platform/tast : master]

14 views
Skip to first unread message

Commit Bot (Gerrit)

unread,
Apr 8, 2020, 10:52:58 AM4/8/20
to Yusuke Sato, Hidehiko Abe

Commit Bot submitted this change.

View Change

Approvals: Hidehiko Abe: Looks good to me, approved Yusuke Sato: Commit; Verified
tast: Remove android_all SoftwareDep support

We're removing container R support, and once it's done, android_all
is equivalent to android_p.

BUG=b:147608538
TEST=try

Cq-Depend: chromium:2125568, chromium:2125567
Change-Id: I4d58fbf8e5ba83a525f276d01d8d017a3ea5bcd2
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/tast/+/2125384
Reviewed-by: Hidehiko Abe <hide...@chromium.org>
Commit-Queue: Yusuke Sato <yus...@chromium.org>
Tested-by: Yusuke Sato <yus...@chromium.org>
---
M docs/test_dependencies.md
M src/chromiumos/tast/cmd/local_test_runner/main.go
2 files changed, 0 insertions(+), 3 deletions(-)

diff --git a/docs/test_dependencies.md b/docs/test_dependencies.md
index 30bf6c3..285c033 100644
--- a/docs/test_dependencies.md
+++ b/docs/test_dependencies.md
@@ -21,8 +21,6 @@
Any version of Android can be used. Prefer this over `android_vm_r` if possible.
* `android_vm_p` - `android_vm` feature that runs in P VM. Don't use in new code.
* `android_vm_r` - `android_vm` feature that runs in R VM.
-* `android_all` - The ability to [run Android apps] in container. Any version
- of Android can be used. Don't use in new code. Support `android_vm_r` instead.
* `android_p` - The ability to [run Android apps] that require Android P.
* `arc` - The ability to [run Android apps] in any way, in VM or container,
with any Android version. This is intended to be used to run non-ARC tests
diff --git a/src/chromiumos/tast/cmd/local_test_runner/main.go b/src/chromiumos/tast/cmd/local_test_runner/main.go
index 518af76..1f2d851 100644
--- a/src/chromiumos/tast/cmd/local_test_runner/main.go
+++ b/src/chromiumos/tast/cmd/local_test_runner/main.go
@@ -66,7 +66,6 @@
"android_vm_p": `arc && arcvm && "android-vm-pi"`,
// TODO(b/146584985): update to use R flags
"android_vm_r": `arc && arcvm && "android-vm-master"`,
- "android_all": `arc && arcpp`,
"android_p": `arc && "android-container-pi"`,
"arc": `arc`,
"arc_camera1": `"arc-camera1"`,

To view, visit change 2125384. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform/tast
Gerrit-Branch: master
Gerrit-Change-Id: I4d58fbf8e5ba83a525f276d01d8d017a3ea5bcd2
Gerrit-Change-Number: 2125384
Gerrit-PatchSet: 3
Gerrit-Owner: Yusuke Sato <yus...@chromium.org>
Gerrit-Reviewer: Commit Bot <commi...@chromium.org>
Gerrit-Reviewer: Hidehiko Abe <hide...@chromium.org>
Gerrit-Reviewer: Yusuke Sato <yus...@chromium.org>
Gerrit-MessageType: merged
Reply all
Reply to author
Forward
0 new messages