camera: Register portrait mode reprocess request [chromiumos/platform2 : release-R81-12871.B]

[Commit Bot (Gerrit)]

Commit Bot submitted this change.

View Change

Approvals: Ren-Pei Zeng: Looks good to me, approved; Commit; Verified

camera: Register portrait mode reprocess request

Register portrait mode reprocess requests. Frame Number Mapper keeps the
frame number mappings and the states of them. Failing to register a
capture request would result in the states not being updated and staying
in memory, causing memory leaks.

BUG=chromium:1067793
TEST=Tested on krane with portrait mode + ZSL and verified the error
messages no longer show up.

Change-Id: I186a4ec22e3190f922080e29b3cd0f956020654a
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2136985
Tested-by: Jasmine Chen <lni...@google.com>
Auto-Submit: Jasmine Chen <lni...@google.com>
Reviewed-by: Hung-yu Wu <hy...@chromium.org>
Commit-Queue: Jasmine Chen <lni...@google.com>
(cherry picked from commit 252ebeb44626c3abc5dda7e96cfdc95fdcc4258b)
Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2141402
Reviewed-by: Ren-Pei Zeng <kam...@chromium.org>
Commit-Queue: Ren-Pei Zeng <kam...@chromium.org>
Tested-by: Ren-Pei Zeng <kam...@chromium.org>
---
M camera/hal_adapter/camera_device_adapter.cc
1 file changed, 3 insertions(+), 0 deletions(-)

diff --git a/camera/hal_adapter/camera_device_adapter.cc b/camera/hal_adapter/camera_device_adapter.cc
index 4364b38..eec3dd3 100644
--- a/camera/hal_adapter/camera_device_adapter.cc
+++ b/camera/hal_adapter/camera_device_adapter.cc
@@ -989,6 +989,9 @@
     std::unique_ptr<Camera3CaptureRequest> req,
     base::Callback<void(int32_t)> callback) {
   VLOGF_ENTER();
+  frame_number_mapper_.RegisterCaptureRequest(req.get(),
+                                              /*is_request_split=*/false,
+                                              /*is_request_added=*/false);
   callback.Run(
       camera_device_->ops->process_capture_request(camera_device_, req.get()));
 }

To view, visit change 2141402. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: chromiumos/platform2

Gerrit-Branch: release-R81-12871.B

Gerrit-Change-Id: I186a4ec22e3190f922080e29b3cd0f956020654a

Gerrit-Change-Number: 2141402

Gerrit-PatchSet: 2

Gerrit-Owner: Ren-Pei Zeng <kam...@chromium.org>

Gerrit-Reviewer: Commit Bot <commi...@chromium.org>

Gerrit-Reviewer: Jasmine Chen <lni...@google.com>

Gerrit-Reviewer: Ren-Pei Zeng <kam...@chromium.org>

Gerrit-MessageType: merged